From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Rosin <peda@axentia.se>, Stefan Lengfeld <contact@stefanchrist.eu>, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Wolfram Sang <wsa+renesas@sang-engineering.com> Subject: [PATCH 10/12] i2c: stu300: use xfer_atomic callback to bail out early Date: Wed, 3 Apr 2019 14:40:17 +0200 [thread overview] Message-ID: <20190403124019.8947-11-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> Use the new callback to reject atomic transfers. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-stu300.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 5503fa171df0..743c161b22c5 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b/drivers/i2c/busses/i2c-stu300.c @@ -328,12 +328,6 @@ static int stu300_start_and_await_event(struct stu300_dev *dev, { int ret; - if (unlikely(irqs_disabled())) { - /* TODO: implement polling for this case if need be. */ - WARN(1, "irqs are disabled, cannot poll for event\n"); - return -EIO; - } - /* Lock command issue, fill in an event we wait for */ spin_lock_irq(&dev->cmd_issue_lock); init_completion(&dev->cmd_complete); @@ -380,13 +374,6 @@ static int stu300_await_event(struct stu300_dev *dev, { int ret; - if (unlikely(irqs_disabled())) { - /* TODO: implement polling for this case if need be. */ - dev_err(&dev->pdev->dev, "irqs are disabled on this " - "system!\n"); - return -EIO; - } - /* Is it already here? */ spin_lock_irq(&dev->cmd_issue_lock); dev->cmd_err = STU300_ERROR_NONE; @@ -846,6 +833,13 @@ static int stu300_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, return num; } +static int stu300_xfer_todo(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) +{ + /* TODO: implement polling for this case if need be. */ + WARN(1, "%s: atomic transfers not implemented\n", dev_name(&adap->dev)); + return -EOPNOTSUPP; +} + static u32 stu300_func(struct i2c_adapter *adap) { /* This is the simplest thing you can think of... */ @@ -853,8 +847,9 @@ static u32 stu300_func(struct i2c_adapter *adap) } static const struct i2c_algorithm stu300_algo = { - .master_xfer = stu300_xfer, - .functionality = stu300_func, + .master_xfer = stu300_xfer, + .master_xfer_atomic = stu300_xfer_todo, + .functionality = stu300_func, }; static const struct i2c_adapter_quirks stu300_quirks = { -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-tegra@vger.kernel.org, Stefan Lengfeld <contact@stefanchrist.eu>, linux-omap@vger.kernel.org, Peter Rosin <peda@axentia.se>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/12] i2c: stu300: use xfer_atomic callback to bail out early Date: Wed, 3 Apr 2019 14:40:17 +0200 [thread overview] Message-ID: <20190403124019.8947-11-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> Use the new callback to reject atomic transfers. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-stu300.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 5503fa171df0..743c161b22c5 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b/drivers/i2c/busses/i2c-stu300.c @@ -328,12 +328,6 @@ static int stu300_start_and_await_event(struct stu300_dev *dev, { int ret; - if (unlikely(irqs_disabled())) { - /* TODO: implement polling for this case if need be. */ - WARN(1, "irqs are disabled, cannot poll for event\n"); - return -EIO; - } - /* Lock command issue, fill in an event we wait for */ spin_lock_irq(&dev->cmd_issue_lock); init_completion(&dev->cmd_complete); @@ -380,13 +374,6 @@ static int stu300_await_event(struct stu300_dev *dev, { int ret; - if (unlikely(irqs_disabled())) { - /* TODO: implement polling for this case if need be. */ - dev_err(&dev->pdev->dev, "irqs are disabled on this " - "system!\n"); - return -EIO; - } - /* Is it already here? */ spin_lock_irq(&dev->cmd_issue_lock); dev->cmd_err = STU300_ERROR_NONE; @@ -846,6 +833,13 @@ static int stu300_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, return num; } +static int stu300_xfer_todo(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) +{ + /* TODO: implement polling for this case if need be. */ + WARN(1, "%s: atomic transfers not implemented\n", dev_name(&adap->dev)); + return -EOPNOTSUPP; +} + static u32 stu300_func(struct i2c_adapter *adap) { /* This is the simplest thing you can think of... */ @@ -853,8 +847,9 @@ static u32 stu300_func(struct i2c_adapter *adap) } static const struct i2c_algorithm stu300_algo = { - .master_xfer = stu300_xfer, - .functionality = stu300_func, + .master_xfer = stu300_xfer, + .master_xfer_atomic = stu300_xfer_todo, + .functionality = stu300_func, }; static const struct i2c_adapter_quirks stu300_quirks = { -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-03 12:40 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-03 12:40 [PATCH 00/12] i2c: core: introduce atomic transfers Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 12:40 ` [PATCH 01/12] i2c: remove use of in_atomic() Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-15 12:40 ` Andy Shevchenko 2019-04-15 12:40 ` Andy Shevchenko 2019-04-15 21:55 ` Stefan Lengfeld 2019-04-15 21:55 ` Stefan Lengfeld 2019-04-15 21:55 ` Stefan Lengfeld 2019-04-16 10:48 ` Wolfram Sang 2019-04-16 10:48 ` Wolfram Sang 2019-04-03 12:40 ` [PATCH 02/12] i2c: core: use I2C locking behaviour also for SMBUS Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-15 12:39 ` Andy Shevchenko 2019-04-15 12:39 ` Andy Shevchenko 2019-04-15 12:39 ` Andy Shevchenko 2019-04-03 12:40 ` [PATCH 03/12] i2c: core: introduce callbacks for atomic transfers Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-15 12:39 ` Andy Shevchenko 2019-04-15 12:39 ` Andy Shevchenko 2019-04-15 21:57 ` Stefan Lengfeld 2019-04-15 21:57 ` Stefan Lengfeld 2019-04-03 12:40 ` [PATCH 04/12] i2c: mux: populate the new *_atomic callbacks Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 15:17 ` Peter Rosin 2019-04-03 15:17 ` Peter Rosin 2019-04-03 15:17 ` Peter Rosin 2019-04-15 12:04 ` Wolfram Sang 2019-04-15 12:04 ` Wolfram Sang 2019-04-15 12:04 ` Wolfram Sang 2019-04-15 12:44 ` Andy Shevchenko 2019-04-15 12:44 ` Andy Shevchenko 2019-04-03 12:40 ` [PATCH 05/12] i2c: demux: handle the new atomic callbacks Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-15 12:37 ` Andy Shevchenko 2019-04-15 12:37 ` Andy Shevchenko 2019-04-03 12:40 ` [PATCH 06/12] i2c: omap: Add the master_xfer_irqless hook Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-15 22:05 ` Stefan Lengfeld 2019-04-15 22:05 ` Stefan Lengfeld 2019-04-16 10:52 ` Wolfram Sang 2019-04-16 10:52 ` Wolfram Sang 2019-04-03 12:40 ` [PATCH 07/12] i2c: tegra-bpmp: convert to use new atomic callbacks Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 12:40 ` [PATCH 08/12] i2c: ocores: refactor setup for polling Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-05 15:09 ` Peter Korsgaard 2019-04-05 15:09 ` Peter Korsgaard 2019-04-05 19:00 ` Andrew Lunn 2019-04-05 19:00 ` Andrew Lunn 2019-04-03 12:40 ` [PATCH 09/12] i2c: ocores: enable atomic xfers Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-05 19:20 ` Andrew Lunn 2019-04-05 19:20 ` Andrew Lunn 2019-04-03 12:40 ` Wolfram Sang [this message] 2019-04-03 12:40 ` [PATCH 10/12] i2c: stu300: use xfer_atomic callback to bail out early Wolfram Sang 2019-04-04 15:38 ` Linus Walleij 2019-04-04 15:38 ` Linus Walleij 2019-04-03 12:40 ` [PATCH 11/12] i2c: algo: bit: add flag to whitelist atomic transfers Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-03 12:40 ` [PATCH 12/12] i2c: gpio: flag atomic capability if possible Wolfram Sang 2019-04-03 12:40 ` Wolfram Sang 2019-04-04 15:40 ` Linus Walleij 2019-04-04 15:40 ` Linus Walleij 2019-04-15 12:38 ` Andy Shevchenko 2019-04-15 12:38 ` Andy Shevchenko 2019-04-03 13:15 ` [PATCH 00/12] i2c: core: introduce atomic transfers Andy Shevchenko 2019-04-03 13:15 ` Andy Shevchenko 2019-04-15 12:06 ` Wolfram Sang 2019-04-15 12:06 ` Wolfram Sang 2019-04-15 12:35 ` Andy Shevchenko 2019-04-15 12:35 ` Andy Shevchenko 2019-04-15 12:48 ` Andy Shevchenko 2019-04-15 12:48 ` Andy Shevchenko 2019-04-15 12:50 ` Wolfram Sang 2019-04-15 12:50 ` Wolfram Sang 2019-04-15 12:10 ` Wolfram Sang 2019-04-15 12:10 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190403124019.8947-11-wsa+renesas@sang-engineering.com \ --to=wsa+renesas@sang-engineering.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=contact@stefanchrist.eu \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=peda@axentia.se \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.