From: Julien Grall <julien.grall@arm.com> To: xen-devel@lists.xenproject.org Cc: "Stefano Stabellini" <sstabellini@kernel.org>, "Wei Liu" <wei.liu2@citrix.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "George Dunlap" <george.dunlap@eu.citrix.com>, "Andrew Cooper" <andrew.cooper3@citrix.com>, "Tim Deegan" <tim@xen.org>, "Gang Wei" <gang.wei@intel.com>, oleksandr_tyshchenko@epam.com, "Julien Grall" <julien.grall@arm.com>, "Tamas K Lengyel" <tamas@tklengyel.com>, "Jan Beulich" <jbeulich@suse.com>, "Shane Wang" <shane.wang@intel.com>, andrii_anisov@epam.com, "Ian Jackson" <ian.jackson@eu.citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: [PATCH 00/14] xen/arm: Properly disable M2P on Arm. Date: Tue, 7 May 2019 16:14:44 +0100 [thread overview] Message-ID: <20190507151458.29350-1-julien.grall@arm.com> (raw) Hi all, Arm never supported a M2P yet there are some helpers implemented to deal with the common code. However, the implementation of mfn_to_gmfn is completely bogus. This series aims to properly disable the M2P on Arm. See patch #8 for the rationale regarding the lack of M2P on Arm. While looking at the code, I also continued to convert some code to use typesafe MFN/GFN. Cheers, Julien Grall (14): xen/arm: Use mfn_to_pdx instead of pfn_to_pdx when possible xen/x86: Constify the parameter "d" in mfn_to_gfn xen/x86: Make mfn_to_gfn typesafe xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn xen/grant-table: Make arch specific macros typesafe xen: Convert hotplug page function to use typesafe MFN xen: Convert is_xen_fixed_mfn to use typesafe MFN xen: Convert is_xen_heap_mfn to use typesafe MFN xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call xen: Remove mfn_to_gmfn macro xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function xen/x86: pv: Convert update_intpte() to use typesafe MFN xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P xen/arch/arm/mm.c | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/cpu/mcheck/mcaction.c | 20 ++++--- xen/arch/x86/domain.c | 34 ++++++----- xen/arch/x86/mm.c | 115 ++++++++++++++++++------------------ xen/arch/x86/mm/mem_sharing.c | 19 +++--- xen/arch/x86/mm/p2m-pod.c | 4 +- xen/arch/x86/mm/p2m-pt.c | 37 ++++++------ xen/arch/x86/mm/p2m.c | 70 +++++++++++----------- xen/arch/x86/mm/paging.c | 4 +- xen/arch/x86/mm/shadow/common.c | 31 ++++++---- xen/arch/x86/mm/shadow/multi.c | 6 +- xen/arch/x86/pv/dom0_build.c | 6 +- xen/arch/x86/pv/emul-priv-op.c | 4 +- xen/arch/x86/pv/grant_table.c | 6 +- xen/arch/x86/pv/mm.h | 6 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/tboot.c | 2 +- xen/arch/x86/x86_64/traps.c | 41 ++++++------- xen/common/Kconfig | 3 + xen/common/domctl.c | 2 +- xen/common/grant_table.c | 4 +- xen/common/memory.c | 6 +- xen/common/page_alloc.c | 28 ++++----- xen/common/sysctl.c | 14 ++--- xen/drivers/passthrough/iommu.c | 13 ++-- xen/drivers/passthrough/x86/iommu.c | 16 ++--- xen/include/asm-arm/domain.h | 5 ++ xen/include/asm-arm/grant_table.h | 12 ++-- xen/include/asm-arm/mm.h | 31 +++------- xen/include/asm-x86/grant_table.h | 19 +++--- xen/include/asm-x86/mm.h | 46 +++++++-------- xen/include/asm-x86/p2m.h | 6 +- xen/include/public/domctl.h | 4 ++ xen/include/xen/domain.h | 8 +++ xen/include/xen/mm.h | 20 ++++++- 36 files changed, 344 insertions(+), 303 deletions(-) -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: xen-devel@lists.xenproject.org Cc: "Stefano Stabellini" <sstabellini@kernel.org>, "Wei Liu" <wei.liu2@citrix.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "George Dunlap" <george.dunlap@eu.citrix.com>, "Andrew Cooper" <andrew.cooper3@citrix.com>, "Tim Deegan" <tim@xen.org>, "Gang Wei" <gang.wei@intel.com>, oleksandr_tyshchenko@epam.com, "Julien Grall" <julien.grall@arm.com>, "Tamas K Lengyel" <tamas@tklengyel.com>, "Jan Beulich" <jbeulich@suse.com>, "Shane Wang" <shane.wang@intel.com>, andrii_anisov@epam.com, "Ian Jackson" <ian.jackson@eu.citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: [Xen-devel] [PATCH 00/14] xen/arm: Properly disable M2P on Arm. Date: Tue, 7 May 2019 16:14:44 +0100 [thread overview] Message-ID: <20190507151458.29350-1-julien.grall@arm.com> (raw) Message-ID: <20190507151444.rWf63qmCothUwOijEEh0vlQhjTOhnl0HIGxFetuh2_U@z> (raw) Hi all, Arm never supported a M2P yet there are some helpers implemented to deal with the common code. However, the implementation of mfn_to_gmfn is completely bogus. This series aims to properly disable the M2P on Arm. See patch #8 for the rationale regarding the lack of M2P on Arm. While looking at the code, I also continued to convert some code to use typesafe MFN/GFN. Cheers, Julien Grall (14): xen/arm: Use mfn_to_pdx instead of pfn_to_pdx when possible xen/x86: Constify the parameter "d" in mfn_to_gfn xen/x86: Make mfn_to_gfn typesafe xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn xen/grant-table: Make arch specific macros typesafe xen: Convert hotplug page function to use typesafe MFN xen: Convert is_xen_fixed_mfn to use typesafe MFN xen: Convert is_xen_heap_mfn to use typesafe MFN xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call xen: Remove mfn_to_gmfn macro xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function xen/x86: pv: Convert update_intpte() to use typesafe MFN xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P xen/arch/arm/mm.c | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/cpu/mcheck/mcaction.c | 20 ++++--- xen/arch/x86/domain.c | 34 ++++++----- xen/arch/x86/mm.c | 115 ++++++++++++++++++------------------ xen/arch/x86/mm/mem_sharing.c | 19 +++--- xen/arch/x86/mm/p2m-pod.c | 4 +- xen/arch/x86/mm/p2m-pt.c | 37 ++++++------ xen/arch/x86/mm/p2m.c | 70 +++++++++++----------- xen/arch/x86/mm/paging.c | 4 +- xen/arch/x86/mm/shadow/common.c | 31 ++++++---- xen/arch/x86/mm/shadow/multi.c | 6 +- xen/arch/x86/pv/dom0_build.c | 6 +- xen/arch/x86/pv/emul-priv-op.c | 4 +- xen/arch/x86/pv/grant_table.c | 6 +- xen/arch/x86/pv/mm.h | 6 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/tboot.c | 2 +- xen/arch/x86/x86_64/traps.c | 41 ++++++------- xen/common/Kconfig | 3 + xen/common/domctl.c | 2 +- xen/common/grant_table.c | 4 +- xen/common/memory.c | 6 +- xen/common/page_alloc.c | 28 ++++----- xen/common/sysctl.c | 14 ++--- xen/drivers/passthrough/iommu.c | 13 ++-- xen/drivers/passthrough/x86/iommu.c | 16 ++--- xen/include/asm-arm/domain.h | 5 ++ xen/include/asm-arm/grant_table.h | 12 ++-- xen/include/asm-arm/mm.h | 31 +++------- xen/include/asm-x86/grant_table.h | 19 +++--- xen/include/asm-x86/mm.h | 46 +++++++-------- xen/include/asm-x86/p2m.h | 6 +- xen/include/public/domctl.h | 4 ++ xen/include/xen/domain.h | 8 +++ xen/include/xen/mm.h | 20 ++++++- 36 files changed, 344 insertions(+), 303 deletions(-) -- 2.11.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-05-07 15:15 UTC|newest] Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-07 15:14 Julien Grall [this message] 2019-05-07 15:14 ` [Xen-devel] [PATCH 00/14] xen/arm: Properly disable M2P on Arm Julien Grall 2019-05-07 15:14 ` [PATCH 01/14] xen/arm: Use mfn_to_pdx instead of pfn_to_pdx when possible Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-09 17:50 ` Stefano Stabellini 2019-05-09 17:50 ` [Xen-devel] " Stefano Stabellini 2019-05-07 15:14 ` [PATCH 02/14] xen/x86: Constify the parameter "d" in mfn_to_gfn Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 03/14] xen/x86: Make mfn_to_gfn typesafe Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-10 11:35 ` Jan Beulich 2019-05-10 11:35 ` [Xen-devel] " Jan Beulich 2019-05-10 13:02 ` Julien Grall 2019-05-10 13:02 ` [Xen-devel] " Julien Grall 2019-05-10 13:24 ` Jan Beulich 2019-05-10 13:24 ` [Xen-devel] " Jan Beulich 2019-05-10 13:25 ` Julien Grall 2019-05-10 13:25 ` [Xen-devel] " Julien Grall 2019-05-20 15:13 ` Julien Grall 2019-05-20 15:13 ` [Xen-devel] " Julien Grall 2019-05-28 17:29 ` George Dunlap 2019-05-28 17:29 ` [Xen-devel] " George Dunlap 2019-05-29 11:39 ` Julien Grall 2019-05-29 11:39 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 04/14] xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-10 12:15 ` Jan Beulich 2019-05-10 12:15 ` [Xen-devel] " Jan Beulich 2019-05-10 13:07 ` Julien Grall 2019-05-10 13:07 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 05/14] xen/grant-table: Make arch specific macros typesafe Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-09 17:54 ` Stefano Stabellini 2019-05-09 17:54 ` [Xen-devel] " Stefano Stabellini 2019-05-07 15:14 ` [PATCH 06/14] xen: Convert hotplug page function to use typesafe MFN Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-09 18:01 ` Stefano Stabellini 2019-05-09 18:01 ` [Xen-devel] " Stefano Stabellini 2019-05-09 18:10 ` Julien Grall 2019-05-09 18:10 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 07/14] xen: Convert is_xen_fixed_mfn " Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-24 15:16 ` George Dunlap 2019-05-24 15:16 ` [Xen-devel] " George Dunlap 2019-05-07 15:14 ` [PATCH 08/14] xen: Convert is_xen_heap_mfn " Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-24 15:15 ` George Dunlap 2019-05-24 15:15 ` [Xen-devel] " George Dunlap 2019-05-07 15:14 ` [PATCH 09/14] xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-09 18:06 ` Stefano Stabellini 2019-05-09 18:06 ` [Xen-devel] " Stefano Stabellini 2019-05-09 18:12 ` Julien Grall 2019-05-09 18:12 ` [Xen-devel] " Julien Grall 2019-05-09 18:16 ` Stefano Stabellini 2019-05-09 18:16 ` [Xen-devel] " Stefano Stabellini 2019-05-09 18:29 ` Julien Grall 2019-05-09 18:29 ` [Xen-devel] " Julien Grall 2019-05-09 19:49 ` Stefano Stabellini 2019-05-09 19:49 ` [Xen-devel] " Stefano Stabellini 2019-05-10 12:31 ` Jan Beulich 2019-05-10 12:31 ` [Xen-devel] " Jan Beulich 2019-05-10 13:22 ` Julien Grall 2019-05-10 13:22 ` [Xen-devel] " Julien Grall 2019-05-10 13:32 ` Jan Beulich 2019-05-10 13:32 ` [Xen-devel] " Jan Beulich 2019-05-10 13:41 ` Julien Grall 2019-05-10 13:41 ` [Xen-devel] " Julien Grall 2019-05-10 13:45 ` Jan Beulich 2019-05-10 13:45 ` [Xen-devel] " Jan Beulich 2019-05-10 14:04 ` Julien Grall 2019-05-10 14:04 ` [Xen-devel] " Julien Grall 2019-05-10 14:19 ` Jan Beulich 2019-05-10 14:19 ` [Xen-devel] " Jan Beulich 2019-05-10 14:34 ` Julien Grall 2019-05-10 14:34 ` [Xen-devel] " Julien Grall 2019-05-22 16:03 ` Julien Grall 2019-05-22 16:03 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 10/14] xen: Remove mfn_to_gmfn macro Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 11/14] xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-10 12:43 ` Jan Beulich 2019-05-10 12:43 ` [Xen-devel] " Jan Beulich 2019-05-10 13:27 ` Julien Grall 2019-05-10 13:27 ` [Xen-devel] " Julien Grall 2019-05-10 13:35 ` Jan Beulich 2019-05-10 13:35 ` [Xen-devel] " Jan Beulich 2019-05-10 13:41 ` Julien Grall 2019-05-10 13:41 ` [Xen-devel] " Julien Grall 2019-05-10 13:48 ` Jan Beulich 2019-05-10 13:48 ` [Xen-devel] " Jan Beulich 2019-05-10 14:05 ` Julien Grall 2019-05-10 14:05 ` [Xen-devel] " Julien Grall 2019-05-10 14:21 ` Jan Beulich 2019-05-10 14:21 ` [Xen-devel] " Jan Beulich 2019-05-10 14:48 ` Julien Grall 2019-05-10 14:48 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 12/14] xen/x86: pv: Convert update_intpte() to use typesafe MFN Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-10 12:54 ` Jan Beulich 2019-05-10 12:54 ` [Xen-devel] " Jan Beulich 2019-05-10 13:28 ` Julien Grall 2019-05-10 13:28 ` [Xen-devel] " Julien Grall 2019-05-07 15:14 ` [PATCH 13/14] xen/mm: Convert {s, g}et_gpfn_from_mfn() " Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-07 20:27 ` Tamas K Lengyel 2019-05-07 20:27 ` [Xen-devel] " Tamas K Lengyel 2019-05-09 18:19 ` Stefano Stabellini 2019-05-09 18:19 ` [Xen-devel] " Stefano Stabellini 2019-05-10 13:21 ` Jan Beulich 2019-05-10 13:21 ` [Xen-devel] " Jan Beulich 2019-05-10 13:27 ` Andrew Cooper 2019-05-10 13:27 ` [Xen-devel] " Andrew Cooper 2019-05-10 13:34 ` Julien Grall 2019-05-10 13:34 ` [Xen-devel] " Julien Grall 2019-05-10 13:41 ` Jan Beulich 2019-05-10 13:41 ` [Xen-devel] " Jan Beulich 2019-05-10 13:46 ` Julien Grall 2019-05-10 13:46 ` [Xen-devel] " Julien Grall 2019-05-10 14:02 ` Jan Beulich 2019-05-10 14:02 ` [Xen-devel] " Jan Beulich 2019-05-10 14:05 ` Andrew Cooper 2019-05-10 14:05 ` [Xen-devel] " Andrew Cooper 2019-05-10 14:08 ` Julien Grall 2019-05-10 14:08 ` [Xen-devel] " Julien Grall 2019-05-10 14:09 ` Andrew Cooper 2019-05-10 14:09 ` [Xen-devel] " Andrew Cooper 2019-05-10 14:14 ` Jan Beulich 2019-05-10 14:14 ` [Xen-devel] " Jan Beulich 2019-05-10 14:27 ` Andrew Cooper 2019-05-10 14:27 ` [Xen-devel] " Andrew Cooper 2019-05-24 16:24 ` George Dunlap 2019-05-24 16:24 ` [Xen-devel] " George Dunlap 2019-05-29 16:27 ` Julien Grall 2019-05-29 16:27 ` [Xen-devel] " Julien Grall 2019-05-29 16:29 ` George Dunlap 2019-05-29 16:29 ` [Xen-devel] " George Dunlap 2019-05-24 16:35 ` George Dunlap 2019-05-24 16:35 ` [Xen-devel] " George Dunlap 2019-05-07 15:14 ` [PATCH 14/14] xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P Julien Grall 2019-05-07 15:14 ` [Xen-devel] " Julien Grall 2019-05-09 18:20 ` Stefano Stabellini 2019-05-09 18:20 ` [Xen-devel] " Stefano Stabellini 2019-05-10 13:28 ` Jan Beulich 2019-05-10 13:28 ` [Xen-devel] " Jan Beulich 2019-05-10 13:29 ` Julien Grall 2019-05-10 13:29 ` [Xen-devel] " Julien Grall 2019-05-10 13:37 ` Jan Beulich 2019-05-10 13:37 ` [Xen-devel] " Jan Beulich 2019-05-10 13:38 ` Julien Grall 2019-05-10 13:38 ` [Xen-devel] " Julien Grall 2019-05-24 16:51 ` George Dunlap 2019-05-24 16:51 ` [Xen-devel] " George Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190507151458.29350-1-julien.grall@arm.com \ --to=julien.grall@arm.com \ --cc=andrew.cooper3@citrix.com \ --cc=andrii_anisov@epam.com \ --cc=gang.wei@intel.com \ --cc=george.dunlap@eu.citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=jbeulich@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=oleksandr_tyshchenko@epam.com \ --cc=roger.pau@citrix.com \ --cc=shane.wang@intel.com \ --cc=sstabellini@kernel.org \ --cc=tamas@tklengyel.com \ --cc=tim@xen.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.