All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH v2 11/14] drm/i915: Simplfy LVDS crtc_mask setup
Date: Mon,  8 Jul 2019 19:20:45 +0300	[thread overview]
Message-ID: <20190708162048.4286-12-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20190708162048.4286-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We don't need to special case PCH vs. gen4 when setting up the LVDS
crtc_mask. Just claim pipes A|B|C work and intel_encoder_crtcs() drop
out any crtc that doesn't exist.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_lvds.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
index 765091a9835c..e79dcc891b80 100644
--- a/drivers/gpu/drm/i915/display/intel_lvds.c
+++ b/drivers/gpu/drm/i915/display/intel_lvds.c
@@ -901,10 +901,8 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
 	intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
 	intel_encoder->port = PORT_NONE;
 	intel_encoder->cloneable = 0;
-	if (HAS_PCH_SPLIT(dev_priv))
+	if (INTEL_GEN(dev_priv) >= 4)
 		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C);
-	else if (IS_GEN(dev_priv, 4))
-		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B);
 	else
 		intel_encoder->crtc_mask = BIT(PIPE_B);
 
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-07-08 16:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 16:20 [PATCH v2 00/14] drm: Try to fix encoder possible_clones/crtc Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 01/14] drm: Include the encoder itself in possible_clones Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 02/14] drm/gma500: Sanitize possible_clones Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 03/14] drm/sti: Remove pointless casts Ville Syrjala
2019-07-09  7:48   ` Benjamin Gaignard
2019-07-08 16:20 ` [PATCH v2 04/14] drm/sti: Try to fix up the tvout possible clones Ville Syrjala
2019-07-09  7:48   ` Benjamin Gaignard
2019-07-08 16:20 ` [PATCH v2 05/14] drm/exynos: Use drm_encoder_mask() Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 06/14] drm/imx: Remove the bogus possible_clones setup Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 07/14] drm/i915: Polish " Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 08/14] drm/i915: Populate possible_crtcs correctly Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 09/14] drm/i915: Fix DP-MST crtc_mask Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 10/14] drm/i915: Clean up encoder->crtc_mask setup Ville Syrjala
2019-07-08 16:20 ` Ville Syrjala [this message]
2019-07-08 16:20 ` [PATCH v2 12/14] drm/i915: s/crtc_mask/pipe_mask/ Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 13/14] drm: Validate encoder->possible_clones Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 14/14] drm: Validate encoder->possible_crtcs Ville Syrjala
2019-07-08 17:25 ` ✓ Fi.CI.BAT: success for drm: Try to fix encoder possible_clones/crtc Patchwork
2019-07-09  5:01 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708162048.4286-12-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.