From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/4] MCR fixes
Date: Tue, 9 Jul 2019 22:06:16 +0100 [thread overview]
Message-ID: <20190709210620.15805-1-tvrtko.ursulin@linux.intel.com> (raw)
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
A few bugs in programming the MCR register sneaked in past review.
First of all fls() usage is wrong and suffers from off-by-one problem.
Secondly the assert in WaProgramMgsrForL3BankSpecificMmioReads is also wrong
due inverted logic.
With MCR programming fixed we can stop ignoring the engine workarounds
verification of GEN8_L3SQCREG4.
Tvrtko Ursulin (4):
drm/i915: Fix GEN8_MCR_SELECTOR programming
drm/i915: Fix WaProgramMgsrForL3BankSpecificMmioReads
drm/i915: Move intel_calculate_mcr_s_ss_select to intel_sseu.c
drm/i915/icl: Verify engine workarounds in GEN8_L3SQCREG4
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 19 --------
drivers/gpu/drm/i915/gt/intel_sseu.c | 24 ++++++++++
drivers/gpu/drm/i915/gt/intel_sseu.h | 2 +
drivers/gpu/drm/i915/gt/intel_workarounds.c | 53 ++++++++-------------
drivers/gpu/drm/i915/i915_drv.h | 2 -
5 files changed, 45 insertions(+), 55 deletions(-)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2019-07-09 21:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 21:06 Tvrtko Ursulin [this message]
2019-07-09 21:06 ` [PATCH 1/4] drm/i915: Fix GEN8_MCR_SELECTOR programming Tvrtko Ursulin
2019-07-09 21:09 ` Chris Wilson
2019-07-10 6:21 ` Tvrtko Ursulin
2019-07-09 21:06 ` [PATCH 2/4] drm/i915: Fix WaProgramMgsrForL3BankSpecificMmioReads Tvrtko Ursulin
2019-07-09 21:11 ` Chris Wilson
2019-07-11 9:15 ` Tvrtko Ursulin
2019-07-11 15:59 ` [PATCH v2 " Tvrtko Ursulin
2019-07-11 23:51 ` Summers, Stuart
2019-07-12 5:32 ` Tvrtko Ursulin
2019-07-09 21:06 ` [PATCH 3/4] drm/i915: Move intel_calculate_mcr_s_ss_select to intel_sseu.c Tvrtko Ursulin
2019-07-09 21:12 ` Chris Wilson
2019-07-09 21:06 ` [PATCH 4/4] drm/i915/icl: Verify engine workarounds in GEN8_L3SQCREG4 Tvrtko Ursulin
2019-07-09 21:12 ` Chris Wilson
2019-07-09 22:18 ` ✓ Fi.CI.BAT: success for MCR fixes Patchwork
2019-07-11 8:53 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-11 19:05 ` ✓ Fi.CI.BAT: success for MCR fixes (rev2) Patchwork
2019-07-12 22:17 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709210620.15805-1-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.