From: Ben Dooks <ben.dooks@codethink.co.uk> To: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Cc: linux-kernel@lists.codethink.co.uk, Ben Dooks <ben.dooks@codethink.co.uk> Subject: [PATCH v4 4/7] ASoC: tegra: disable rx_fifo after disable stream Date: Mon, 7 Oct 2019 16:31:33 +0100 [thread overview] Message-ID: <20191007153136.4920-5-ben.dooks@codethink.co.uk> (raw) In-Reply-To: <20191007153136.4920-1-ben.dooks@codethink.co.uk> We see odd FIFO overruns with this, we assume the best thing to do is to disable the RX I2S frontend first, and then disable the FIFO that is using it. This also fixes an issue where using multi-word frames (TDM) have partial samples stuck in the FIFO which then get read out when the next capture is started. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- sound/soc/tegra/tegra30_i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c index 7382f7949bf4..f87ab1e36369 100644 --- a/sound/soc/tegra/tegra30_i2s.c +++ b/sound/soc/tegra/tegra30_i2s.c @@ -236,9 +236,9 @@ static void tegra30_i2s_start_capture(struct tegra30_i2s *i2s) static void tegra30_i2s_stop_capture(struct tegra30_i2s *i2s) { - tegra30_ahub_disable_rx_fifo(i2s->capture_fifo_cif); regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, TEGRA30_I2S_CTRL_XFER_EN_RX, 0); + tegra30_ahub_disable_rx_fifo(i2s->capture_fifo_cif); } static int tegra30_i2s_trigger(struct snd_pcm_substream *substream, int cmd, -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk> To: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com> Cc: linux-kernel@lists.codethink.co.uk, Ben Dooks <ben.dooks@codethink.co.uk> Subject: [alsa-devel] [PATCH v4 4/7] ASoC: tegra: disable rx_fifo after disable stream Date: Mon, 7 Oct 2019 16:31:33 +0100 [thread overview] Message-ID: <20191007153136.4920-5-ben.dooks@codethink.co.uk> (raw) In-Reply-To: <20191007153136.4920-1-ben.dooks@codethink.co.uk> We see odd FIFO overruns with this, we assume the best thing to do is to disable the RX I2S frontend first, and then disable the FIFO that is using it. This also fixes an issue where using multi-word frames (TDM) have partial samples stuck in the FIFO which then get read out when the next capture is started. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- sound/soc/tegra/tegra30_i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c index 7382f7949bf4..f87ab1e36369 100644 --- a/sound/soc/tegra/tegra30_i2s.c +++ b/sound/soc/tegra/tegra30_i2s.c @@ -236,9 +236,9 @@ static void tegra30_i2s_start_capture(struct tegra30_i2s *i2s) static void tegra30_i2s_stop_capture(struct tegra30_i2s *i2s) { - tegra30_ahub_disable_rx_fifo(i2s->capture_fifo_cif); regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, TEGRA30_I2S_CTRL_XFER_EN_RX, 0); + tegra30_ahub_disable_rx_fifo(i2s->capture_fifo_cif); } static int tegra30_i2s_trigger(struct snd_pcm_substream *substream, int cmd, -- 2.23.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-07 15:31 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-07 15:31 tegra30 tdm support Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks 2019-10-07 15:31 ` [PATCH v4 1/7] ASoC: tegra: add a TDM configuration callback Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks 2019-10-07 15:31 ` [PATCH v4 2/7] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks 2019-10-07 15:31 ` [PATCH v4 3/7] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks 2019-10-08 15:29 ` Dmitry Osipenko 2019-10-08 15:29 ` [alsa-devel] " Dmitry Osipenko 2019-10-17 16:23 ` Ben Dooks 2019-10-17 16:23 ` [alsa-devel] " Ben Dooks 2019-10-17 17:38 ` Dmitry Osipenko 2019-10-17 17:38 ` [alsa-devel] " Dmitry Osipenko 2019-10-24 16:11 ` Jon Hunter 2019-10-24 16:11 ` [alsa-devel] " Jon Hunter 2019-11-05 11:58 ` Ben Dooks 2019-11-05 11:58 ` [alsa-devel] " Ben Dooks 2019-10-07 15:31 ` Ben Dooks [this message] 2019-10-07 15:31 ` [alsa-devel] [PATCH v4 4/7] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks 2019-10-07 15:31 ` [PATCH v4 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks 2019-10-07 15:31 ` [PATCH v4 6/7] ASoC: tegra: config fifos on hw_param changes Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks 2019-10-07 15:31 ` [PATCH v4 7/7] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks 2019-10-07 15:31 ` [alsa-devel] " Ben Dooks
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191007153136.4920-5-ben.dooks@codethink.co.uk \ --to=ben.dooks@codethink.co.uk \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=jonathanh@nvidia.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@lists.codethink.co.uk \ --cc=linux-tegra@vger.kernel.org \ --cc=perex@perex.cz \ --cc=thierry.reding@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.