From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org
Subject: [PATCH 08/10] image-fuzzer: Encode file name and file format to bytes
Date: Wed, 16 Oct 2019 16:24:28 -0300 [thread overview]
Message-ID: <20191016192430.25098-9-ehabkost@redhat.com> (raw)
In-Reply-To: <20191016192430.25098-1-ehabkost@redhat.com>
Callers of create_image() will pass strings as arguments, but the
Image class will expect bytes objects to be provided. Encode
them inside create_image().
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/image-fuzzer/qcow2/layout.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/image-fuzzer/qcow2/layout.py b/tests/image-fuzzer/qcow2/layout.py
index a0fd53c7ad..01bff4d05e 100644
--- a/tests/image-fuzzer/qcow2/layout.py
+++ b/tests/image-fuzzer/qcow2/layout.py
@@ -602,8 +602,8 @@ class Image(object):
def create_image(test_img_path, backing_file_name=None, backing_file_fmt=None,
fields_to_fuzz=None):
"""Create a fuzzed image and write it to the specified file."""
- image = Image(backing_file_name)
- image.set_backing_file_format(backing_file_fmt)
+ image = Image(backing_file_name.encode())
+ image.set_backing_file_format(backing_file_fmt.encode())
image.create_feature_name_table()
image.set_end_of_extension_area()
image.create_l_structures()
--
2.21.0
next prev parent reply other threads:[~2019-10-16 19:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 19:24 [PATCH 00/10] image-fuzzer: Port to Python 3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 01/10] image-fuzzer: Open image files in binary mode Eduardo Habkost
2019-10-17 9:55 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file Eduardo Habkost
2019-10-17 9:56 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 03/10] image-fuzzer: Explicitly use integer division operator Eduardo Habkost
2019-10-16 19:24 ` [PATCH 04/10] image-fuzzer: Use io.StringIO Eduardo Habkost
2019-10-16 19:24 ` [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__() Eduardo Habkost
2019-10-17 21:08 ` John Snow
2019-10-16 19:24 ` [PATCH 06/10] image-fuzzer: Return bytes objects on string fuzzing functions Eduardo Habkost
2019-10-16 19:24 ` [PATCH 07/10] image-fuzzer: Use bytes constant for field values Eduardo Habkost
2019-10-17 9:55 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` Eduardo Habkost [this message]
2019-10-16 19:24 ` [PATCH 09/10] image-fuzzer: Run using python3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 10/10] image-fuzzer: Use errors parameter of subprocess.Popen() Eduardo Habkost
2019-10-17 21:11 ` [PATCH 00/10] image-fuzzer: Port to Python 3 John Snow
2019-10-17 21:29 ` Eduardo Habkost
2019-10-17 22:41 ` John Snow
2019-10-22 20:26 ` Eduardo Habkost
2019-10-23 15:42 ` John Snow
2019-11-05 15:35 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016192430.25098-9-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.