From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Esteban Bosse" <estebanbosse@gmail.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Eduardo Habkost" <ehabkost@redhat.com>, "Paul Durrant" <paul@xen.org>, "Aleksandar Markovic" <amarkovic@wavecomp.com>, "Michael S. Tsirkin" <mst@redhat.com>, xen-devel@lists.xenproject.org, "Hervé Poussineau" <hpoussin@reactos.org>, "Igor Mammedov" <imammedo@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net>, "Richard Henderson" <rth@twiddle.net> Subject: [PATCH v3 17/20] hw/pci-host/piix: Fix code style issues Date: Sat, 26 Oct 2019 20:01:40 +0200 [thread overview] Message-ID: <20191026180143.7369-18-philmd@redhat.com> (raw) In-Reply-To: <20191026180143.7369-1-philmd@redhat.com> We will move this code, fix its style first. Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> Reviewed-by: Esteban Bosse <estebanbosse@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/pci-host/piix.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 95b04122fa..1544c4726b 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -133,9 +133,10 @@ static PCIINTxRoute piix3_route_intx_pin_to_irq(void *opaque, int pci_intx); static void piix3_write_config_xen(PCIDevice *dev, uint32_t address, uint32_t val, int len); -/* return the global irq number corresponding to a given device irq - pin. We could also use the bus number to have a more precise - mapping. */ +/* + * Return the global irq number corresponding to a given device irq + * pin. We could also use the bus number to have a more precise mapping. + */ static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) { int slot_addend; -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Esteban Bosse" <estebanbosse@gmail.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Eduardo Habkost" <ehabkost@redhat.com>, "Paul Durrant" <paul@xen.org>, "Aleksandar Markovic" <amarkovic@wavecomp.com>, "Michael S. Tsirkin" <mst@redhat.com>, xen-devel@lists.xenproject.org, "Hervé Poussineau" <hpoussin@reactos.org>, "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>, "Igor Mammedov" <imammedo@redhat.com>, "Anthony Perard" <anthony.perard@citrix.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net>, "Richard Henderson" <rth@twiddle.net> Subject: [Xen-devel] [PATCH v3 17/20] hw/pci-host/piix: Fix code style issues Date: Sat, 26 Oct 2019 20:01:40 +0200 [thread overview] Message-ID: <20191026180143.7369-18-philmd@redhat.com> (raw) In-Reply-To: <20191026180143.7369-1-philmd@redhat.com> We will move this code, fix its style first. Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> Reviewed-by: Esteban Bosse <estebanbosse@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/pci-host/piix.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 95b04122fa..1544c4726b 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -133,9 +133,10 @@ static PCIINTxRoute piix3_route_intx_pin_to_irq(void *opaque, int pci_intx); static void piix3_write_config_xen(PCIDevice *dev, uint32_t address, uint32_t val, int len); -/* return the global irq number corresponding to a given device irq - pin. We could also use the bus number to have a more precise - mapping. */ +/* + * Return the global irq number corresponding to a given device irq + * pin. We could also use the bus number to have a more precise mapping. + */ static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) { int slot_addend; -- 2.21.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-26 18:14 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-26 18:01 [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 01/20] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 02/20] piix4: Add the Reset Control Register Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 03/20] piix4: Add an i8259 Interrupt Controller as specified in datasheet Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 04/20] Revert "irq: introduce qemu_irq_proxy()" Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 05/20] piix4: Rename PIIX4 object to piix4-isa Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 06/20] piix4: Add an i8257 DMA Controller as specified in datasheet Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 07/20] piix4: Add an i8254 PIT " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 08/20] piix4: Add a MC146818 RTC " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 09/20] hw/mips/mips_malta: Create IDE hard drive array dynamically Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 10/20] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create() Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 11/20] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 12/20] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 13/20] hw/pci-host/piix: Extract piix3_create() Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 14/20] hw/pci-host/piix: Move RCR_IOPORT register definition Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 15/20] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 16/20] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` Philippe Mathieu-Daudé [this message] 2019-10-26 18:01 ` [Xen-devel] [PATCH v3 17/20] hw/pci-host/piix: Fix code style issues Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 18/20] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 19/20] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx' Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-26 18:01 ` [PATCH v3 20/20] hw/pci-host/i440fx: Remove the last PIIX3 traces Philippe Mathieu-Daudé 2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-27 7:44 ` [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Aleksandar Markovic 2019-10-27 7:44 ` [Xen-devel] " Aleksandar Markovic 2019-10-30 9:53 ` Philippe Mathieu-Daudé 2019-10-30 9:53 ` [Xen-devel] " Philippe Mathieu-Daudé 2019-10-30 13:48 ` Aleksandar Markovic 2019-10-30 13:48 ` [Xen-devel] " Aleksandar Markovic 2019-10-30 12:41 ` no-reply 2019-10-30 12:41 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191026180143.7369-18-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=aleksandar.rikalo@rt-rk.com \ --cc=amarkovic@wavecomp.com \ --cc=anthony.perard@citrix.com \ --cc=aurelien@aurel32.net \ --cc=ehabkost@redhat.com \ --cc=estebanbosse@gmail.com \ --cc=hpoussin@reactos.org \ --cc=imammedo@redhat.com \ --cc=mst@redhat.com \ --cc=paul@xen.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.