From: Mihail Atanassov <Mihail.Atanassov@arm.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>, nd <nd@arm.com>,
Mihail Atanassov <Mihail.Atanassov@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Brian Starkey <Brian.Starkey@arm.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"james qian wang (Arm Technology China)"
<james.qian.wang@arm.com>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/5] drm/komeda: Improve IRQ error event prints
Date: Thu, 7 Nov 2019 11:42:25 +0000 [thread overview]
Message-ID: <20191107114155.54307-1-mihail.atanassov@arm.com> (raw)
Hi everyone,
Sending out a v2 of the series since I had missed out a couple of issues
checkpatch caught.
Changes since v1 [https://patchwork.freedesktop.org/series/68325/]:
- Fixed a couple of checkpatch issues in 2/5 and 5/5
v1's cover letter:
This is a smallish series that tries to remove some build-time
configurability in komeda and replace it with a debugfs control. Later
patches in the series add some extra functionality which I found useful
during my debugging sessions, so I figured I'd bake it in.
I've preserved the default behaviour as if CONFIG_KOMEDA_ERROR_PRINT
were enabled, so production kernels can have some feedback from the
driver when things are going south.
1: Introduce the err_verbosity debugfs node for komeda; this keeps the
default of printing error events once per frame.
2: Drop CONFIG_KOMEDA_ERROR_PRINT since output can be disabled at
runtime
3: Add a drm state dump on event. It's quite chatty so I left it only
for error events; printing all that once per frame every vsync floods my
serial terminal, so no info + state combination.
4: Add lower-severity categories to the event printer
5: Normally these events fire only once per pageflip, but sometimes it's
useful to see them all as they come in.
These patches are overall quite tiny, and I was considering just
squashing them into one, but I opted to keep them separate for an easier
review experience; please let me know whether you prefer a single patch.
Thanks!
Mihail Atanassov (5):
drm/komeda: Add debugfs node to control error verbosity
drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
drm/komeda: Optionally dump DRM state on interrupts
drm/komeda: Add option to print WARN- and INFO-level IRQ events
drm/komeda: add rate limiting disable to err_verbosity
drivers/gpu/drm/arm/display/Kconfig | 6 ----
drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--
.../gpu/drm/arm/display/komeda/komeda_dev.c | 4 +++
.../gpu/drm/arm/display/komeda/komeda_dev.h | 30 +++++++++++++++----
.../gpu/drm/arm/display/komeda/komeda_event.c | 23 +++++++++++---
.../gpu/drm/arm/display/komeda/komeda_kms.c | 2 +-
6 files changed, 51 insertions(+), 19 deletions(-)
--
2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Mihail Atanassov <Mihail.Atanassov@arm.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"james qian wang (Arm Technology China)"
<james.qian.wang@arm.com>,
"Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: [PATCH v2 0/5] drm/komeda: Improve IRQ error event prints
Date: Thu, 7 Nov 2019 11:42:25 +0000 [thread overview]
Message-ID: <20191107114155.54307-1-mihail.atanassov@arm.com> (raw)
Hi everyone,
Sending out a v2 of the series since I had missed out a couple of issues
checkpatch caught.
Changes since v1 [https://patchwork.freedesktop.org/series/68325/]:
- Fixed a couple of checkpatch issues in 2/5 and 5/5
v1's cover letter:
This is a smallish series that tries to remove some build-time
configurability in komeda and replace it with a debugfs control. Later
patches in the series add some extra functionality which I found useful
during my debugging sessions, so I figured I'd bake it in.
I've preserved the default behaviour as if CONFIG_KOMEDA_ERROR_PRINT
were enabled, so production kernels can have some feedback from the
driver when things are going south.
1: Introduce the err_verbosity debugfs node for komeda; this keeps the
default of printing error events once per frame.
2: Drop CONFIG_KOMEDA_ERROR_PRINT since output can be disabled at
runtime
3: Add a drm state dump on event. It's quite chatty so I left it only
for error events; printing all that once per frame every vsync floods my
serial terminal, so no info + state combination.
4: Add lower-severity categories to the event printer
5: Normally these events fire only once per pageflip, but sometimes it's
useful to see them all as they come in.
These patches are overall quite tiny, and I was considering just
squashing them into one, but I opted to keep them separate for an easier
review experience; please let me know whether you prefer a single patch.
Thanks!
Mihail Atanassov (5):
drm/komeda: Add debugfs node to control error verbosity
drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
drm/komeda: Optionally dump DRM state on interrupts
drm/komeda: Add option to print WARN- and INFO-level IRQ events
drm/komeda: add rate limiting disable to err_verbosity
drivers/gpu/drm/arm/display/Kconfig | 6 ----
drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--
.../gpu/drm/arm/display/komeda/komeda_dev.c | 4 +++
.../gpu/drm/arm/display/komeda/komeda_dev.h | 30 +++++++++++++++----
.../gpu/drm/arm/display/komeda/komeda_event.c | 23 +++++++++++---
.../gpu/drm/arm/display/komeda/komeda_kms.c | 2 +-
6 files changed, 51 insertions(+), 19 deletions(-)
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mihail Atanassov <Mihail.Atanassov@arm.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"james qian wang \(Arm Technology China\)"
<james.qian.wang@arm.com>,
"Lowry Li \(Arm Technology China\)" <Lowry.Li@arm.com>,
nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: [PATCH v2 0/5] drm/komeda: Improve IRQ error event prints
Date: Thu, 7 Nov 2019 11:42:25 +0000 [thread overview]
Message-ID: <20191107114155.54307-1-mihail.atanassov@arm.com> (raw)
Message-ID: <20191107114225.x4w_mmAQ2jvKMVXfSVYjkvWAGmJva4F-tNA90La2iKU@z> (raw)
Hi everyone,
Sending out a v2 of the series since I had missed out a couple of issues
checkpatch caught.
Changes since v1 [https://patchwork.freedesktop.org/series/68325/]:
- Fixed a couple of checkpatch issues in 2/5 and 5/5
v1's cover letter:
This is a smallish series that tries to remove some build-time
configurability in komeda and replace it with a debugfs control. Later
patches in the series add some extra functionality which I found useful
during my debugging sessions, so I figured I'd bake it in.
I've preserved the default behaviour as if CONFIG_KOMEDA_ERROR_PRINT
were enabled, so production kernels can have some feedback from the
driver when things are going south.
1: Introduce the err_verbosity debugfs node for komeda; this keeps the
default of printing error events once per frame.
2: Drop CONFIG_KOMEDA_ERROR_PRINT since output can be disabled at
runtime
3: Add a drm state dump on event. It's quite chatty so I left it only
for error events; printing all that once per frame every vsync floods my
serial terminal, so no info + state combination.
4: Add lower-severity categories to the event printer
5: Normally these events fire only once per pageflip, but sometimes it's
useful to see them all as they come in.
These patches are overall quite tiny, and I was considering just
squashing them into one, but I opted to keep them separate for an easier
review experience; please let me know whether you prefer a single patch.
Thanks!
Mihail Atanassov (5):
drm/komeda: Add debugfs node to control error verbosity
drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
drm/komeda: Optionally dump DRM state on interrupts
drm/komeda: Add option to print WARN- and INFO-level IRQ events
drm/komeda: add rate limiting disable to err_verbosity
drivers/gpu/drm/arm/display/Kconfig | 6 ----
drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--
.../gpu/drm/arm/display/komeda/komeda_dev.c | 4 +++
.../gpu/drm/arm/display/komeda/komeda_dev.h | 30 +++++++++++++++----
.../gpu/drm/arm/display/komeda/komeda_event.c | 23 +++++++++++---
.../gpu/drm/arm/display/komeda/komeda_kms.c | 2 +-
6 files changed, 51 insertions(+), 19 deletions(-)
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2019-11-07 11:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:42 Mihail Atanassov [this message]
2019-11-07 11:42 ` [PATCH v2 0/5] drm/komeda: Improve IRQ error event prints Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` [PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-11 15:52 ` Liviu Dudau
2019-11-11 15:52 ` Liviu Dudau
2019-11-07 11:42 ` [PATCH v2 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` [PATCH v2 3/5] drm/komeda: Optionally dump DRM state on interrupts Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` [PATCH v2 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-07 11:42 ` Mihail Atanassov
2019-11-11 15:53 ` Liviu Dudau
2019-11-11 15:53 ` Liviu Dudau
2019-11-12 13:00 ` Mihail Atanassov
2019-11-12 13:00 ` Mihail Atanassov
2019-11-12 13:00 ` Mihail Atanassov
2019-11-12 18:24 ` Daniel Vetter
2019-11-12 18:24 ` Daniel Vetter
2019-11-12 18:24 ` Daniel Vetter
2019-11-13 1:42 ` james qian wang (Arm Technology China)
2019-11-13 1:42 ` james qian wang (Arm Technology China)
2019-11-13 1:42 ` james qian wang (Arm Technology China)
2019-11-13 13:43 ` Mihail Atanassov
2019-11-13 13:43 ` Mihail Atanassov
2019-11-13 13:43 ` Mihail Atanassov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107114155.54307-1-mihail.atanassov@arm.com \
--to=mihail.atanassov@arm.com \
--cc=Brian.Starkey@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lowry.Li@arm.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nd@arm.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.