From: Roman Bolshakov <r.bolshakov@yadro.com>
To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: linux@yadro.com, Roman Bolshakov <r.bolshakov@yadro.com>,
Quinn Tran <qutran@marvell.com>,
Himanshu Madhani <hmadhani@marvell.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH v3 12/13] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI
Date: Mon, 25 Nov 2019 16:57:01 +0000 [thread overview]
Message-ID: <20191125165702.1013-13-r.bolshakov@yadro.com> (raw)
In-Reply-To: <20191125165702.1013-1-r.bolshakov@yadro.com>
PORT UPDATE asynchronous event is generated on the host that issues PLOGI
ELS (in the case of higher WWPN). In that case, the event shouldn't be
handled as it sets unwanted DPC flags (i.e. LOOP_RESYNC_NEEDED) that
trigger link flap.
Ignore the event if the host has higher WWPN, but handle otherwise.
Cc: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
drivers/scsi/qla2xxx/qla_mbx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 4eb88c3ee08e..bb6811b94683 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -3920,6 +3920,7 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,
vha->d_id.b24 = 0;
vha->d_id.b.al_pa = 1;
ha->flags.n2n_bigger = 1;
+ ha->flags.n2n_ae = 0;
id.b.al_pa = 2;
ql_dbg(ql_dbg_async, vha, 0x5075,
@@ -3930,6 +3931,7 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,
"Format 1: Remote login - Waiting for WWPN %8phC.\n",
rptid_entry->u.f1.port_name);
ha->flags.n2n_bigger = 0;
+ ha->flags.n2n_ae = 1;
}
qla24xx_post_newsess_work(vha, &id,
rptid_entry->u.f1.port_name,
@@ -3941,7 +3943,6 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,
/* if our portname is higher then initiate N2N login */
set_bit(N2N_LOGIN_NEEDED, &vha->dpc_flags);
- ha->flags.n2n_ae = 1;
return;
break;
case TOPO_FL:
--
2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>
Cc: <linux@yadro.com>, Roman Bolshakov <r.bolshakov@yadro.com>,
Quinn Tran <qutran@marvell.com>,
Himanshu Madhani <hmadhani@marvell.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH v3 12/13] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI
Date: Mon, 25 Nov 2019 19:57:01 +0300 [thread overview]
Message-ID: <20191125165702.1013-13-r.bolshakov@yadro.com> (raw)
In-Reply-To: <20191125165702.1013-1-r.bolshakov@yadro.com>
PORT UPDATE asynchronous event is generated on the host that issues PLOGI
ELS (in the case of higher WWPN). In that case, the event shouldn't be
handled as it sets unwanted DPC flags (i.e. LOOP_RESYNC_NEEDED) that
trigger link flap.
Ignore the event if the host has higher WWPN, but handle otherwise.
Cc: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
drivers/scsi/qla2xxx/qla_mbx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 4eb88c3ee08e..bb6811b94683 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -3920,6 +3920,7 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,
vha->d_id.b24 = 0;
vha->d_id.b.al_pa = 1;
ha->flags.n2n_bigger = 1;
+ ha->flags.n2n_ae = 0;
id.b.al_pa = 2;
ql_dbg(ql_dbg_async, vha, 0x5075,
@@ -3930,6 +3931,7 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,
"Format 1: Remote login - Waiting for WWPN %8phC.\n",
rptid_entry->u.f1.port_name);
ha->flags.n2n_bigger = 0;
+ ha->flags.n2n_ae = 1;
}
qla24xx_post_newsess_work(vha, &id,
rptid_entry->u.f1.port_name,
@@ -3941,7 +3943,6 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha,
/* if our portname is higher then initiate N2N login */
set_bit(N2N_LOGIN_NEEDED, &vha->dpc_flags);
- ha->flags.n2n_ae = 1;
return;
break;
case TOPO_FL:
--
2.24.0
next prev parent reply other threads:[~2019-11-25 16:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:56 [PATCH v3 00/13] scsi: qla2xxx: Bug fixes Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 01/13] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-26 20:55 ` Bart Van Assche
2019-11-26 20:55 ` Bart Van Assche
2019-11-25 16:56 ` [PATCH v3 02/13] scsi: qla2xxx: Use explicit LOGO in target mode Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 03/13] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-26 20:55 ` Bart Van Assche
2019-11-26 20:55 ` Bart Van Assche
2019-11-25 16:56 ` [PATCH v3 04/13] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-26 20:56 ` Bart Van Assche
2019-11-26 20:56 ` Bart Van Assche
2019-11-25 16:56 ` [PATCH v3 05/13] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 06/13] scsi: qla2xxx: Allow PLOGI in target mode Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 07/13] scsi: qla2xxx: Don't call qlt_async_event twice Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 17:00 ` Roman Bolshakov
2019-11-25 17:00 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 08/13] scsi: qla2xxx: Fix PLOGI payload and ELS IOCB dump length Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 09/13] scsi: qla2xxx: Configure local loop for N2N target Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:56 ` [PATCH v3 10/13] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Roman Bolshakov
2019-11-25 16:56 ` Roman Bolshakov
2019-11-25 16:57 ` [PATCH v3 11/13] scsi: qla2xxx: Don't defer relogin unconditonally Roman Bolshakov
2019-11-25 16:57 ` Roman Bolshakov
2019-11-25 16:57 ` Roman Bolshakov [this message]
2019-11-25 16:57 ` [PATCH v3 12/13] scsi: qla2xxx: Ignore PORT UPDATE after N2N PLOGI Roman Bolshakov
2019-11-25 16:57 ` [PATCH v3 13/13] scsi: qla2xxx: Add debug dump of LOGO payload and ELS IOCB Roman Bolshakov
2019-11-25 16:57 ` Roman Bolshakov
2019-11-26 20:57 ` Bart Van Assche
2019-11-26 20:57 ` Bart Van Assche
2019-11-26 20:56 ` [PATCH v3 00/13] scsi: qla2xxx: Bug fixes Bart Van Assche
2019-11-26 20:56 ` Bart Van Assche
2019-11-27 17:24 ` Roman Bolshakov
2019-11-27 17:24 ` Roman Bolshakov
2019-11-27 17:34 ` Bart Van Assche
2019-11-27 17:34 ` Bart Van Assche
2019-11-28 12:18 ` Martin K. Petersen
2019-11-28 12:18 ` Martin K. Petersen
2019-12-09 23:36 ` Martin K. Petersen
2019-12-09 23:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125165702.1013-13-r.bolshakov@yadro.com \
--to=r.bolshakov@yadro.com \
--cc=hare@suse.de \
--cc=hmadhani@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=qutran@marvell.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.