From: Paul Durrant <pdurrant@amazon.com> To: <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org> Cc: Paul Durrant <pdurrant@amazon.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, "Stefano Stabellini" <sstabellini@kernel.org> Subject: [PATCH 2/4] xenbus: limit when state is forced to closed Date: Thu, 5 Dec 2019 14:01:21 +0000 [thread overview] Message-ID: <20191205140123.3817-3-pdurrant@amazon.com> (raw) In-Reply-To: <20191205140123.3817-1-pdurrant@amazon.com> Only force state to closed in the case when the toolstack may need to clean up. This can be detected by checking whether the state in xenstore has been set to closing prior to device removal. Signed-off-by: Paul Durrant <pdurrant@amazon.com> --- Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> --- drivers/xen/xenbus/xenbus_probe.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index a10311c348b9..c54a53da0106 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -255,7 +255,6 @@ int xenbus_dev_probe(struct device *_dev) module_put(drv->driver.owner); fail: xenbus_dev_error(dev, err, "xenbus_dev_probe on %s", dev->nodename); - xenbus_switch_state(dev, XenbusStateClosed); return err; } EXPORT_SYMBOL_GPL(xenbus_dev_probe); @@ -264,6 +263,7 @@ int xenbus_dev_remove(struct device *_dev) { struct xenbus_device *dev = to_xenbus_device(_dev); struct xenbus_driver *drv = to_xenbus_driver(_dev->driver); + enum xenbus_state state; DPRINTK("%s", dev->nodename); @@ -276,7 +276,14 @@ int xenbus_dev_remove(struct device *_dev) free_otherend_details(dev); - xenbus_switch_state(dev, XenbusStateClosed); + /* + * If the toolstack had force the device state to closing then set + * the state to closed now to allow it to be cleaned up. + */ + state = xenbus_read_driver_state(dev->nodename); + if (state == XenbusStateClosing) + xenbus_switch_state(dev, XenbusStateClosed); + return 0; } EXPORT_SYMBOL_GPL(xenbus_dev_remove); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Durrant <pdurrant@amazon.com> To: <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org> Cc: Juergen Gross <jgross@suse.com>, Paul Durrant <pdurrant@amazon.com>, Stefano Stabellini <sstabellini@kernel.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com> Subject: [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed Date: Thu, 5 Dec 2019 14:01:21 +0000 [thread overview] Message-ID: <20191205140123.3817-3-pdurrant@amazon.com> (raw) In-Reply-To: <20191205140123.3817-1-pdurrant@amazon.com> Only force state to closed in the case when the toolstack may need to clean up. This can be detected by checking whether the state in xenstore has been set to closing prior to device removal. Signed-off-by: Paul Durrant <pdurrant@amazon.com> --- Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> --- drivers/xen/xenbus/xenbus_probe.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index a10311c348b9..c54a53da0106 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -255,7 +255,6 @@ int xenbus_dev_probe(struct device *_dev) module_put(drv->driver.owner); fail: xenbus_dev_error(dev, err, "xenbus_dev_probe on %s", dev->nodename); - xenbus_switch_state(dev, XenbusStateClosed); return err; } EXPORT_SYMBOL_GPL(xenbus_dev_probe); @@ -264,6 +263,7 @@ int xenbus_dev_remove(struct device *_dev) { struct xenbus_device *dev = to_xenbus_device(_dev); struct xenbus_driver *drv = to_xenbus_driver(_dev->driver); + enum xenbus_state state; DPRINTK("%s", dev->nodename); @@ -276,7 +276,14 @@ int xenbus_dev_remove(struct device *_dev) free_otherend_details(dev); - xenbus_switch_state(dev, XenbusStateClosed); + /* + * If the toolstack had force the device state to closing then set + * the state to closed now to allow it to be cleaned up. + */ + state = xenbus_read_driver_state(dev->nodename); + if (state == XenbusStateClosing) + xenbus_switch_state(dev, XenbusStateClosed); + return 0; } EXPORT_SYMBOL_GPL(xenbus_dev_remove); -- 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-05 14:01 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-05 14:01 [PATCH 0/4] xen-blkback: support live update Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-05 14:01 ` [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 11:33 ` Jürgen Groß 2019-12-09 11:33 ` [Xen-devel] " Jürgen Groß 2019-12-09 11:55 ` Durrant, Paul 2019-12-09 11:55 ` [Xen-devel] " Durrant, Paul 2019-12-09 11:57 ` Jürgen Groß 2019-12-09 11:57 ` [Xen-devel] " Jürgen Groß 2019-12-05 14:01 ` Paul Durrant [this message] 2019-12-05 14:01 ` [Xen-devel] [PATCH 2/4] xenbus: limit when state is forced to closed Paul Durrant 2019-12-09 11:39 ` Roger Pau Monné 2019-12-09 11:39 ` Roger Pau Monné 2019-12-09 11:55 ` Jürgen Groß 2019-12-09 11:55 ` Jürgen Groß 2019-12-09 12:03 ` Durrant, Paul 2019-12-09 12:03 ` Durrant, Paul 2019-12-09 12:08 ` Jürgen Groß 2019-12-09 12:08 ` Jürgen Groß 2019-12-09 12:19 ` Durrant, Paul 2019-12-09 12:19 ` Durrant, Paul 2019-12-09 13:38 ` Jürgen Groß 2019-12-09 13:38 ` Jürgen Groß 2019-12-09 14:06 ` Durrant, Paul 2019-12-09 14:06 ` Durrant, Paul 2019-12-09 14:09 ` Jürgen Groß 2019-12-09 14:09 ` Jürgen Groß 2019-12-09 14:23 ` Durrant, Paul 2019-12-09 14:23 ` Durrant, Paul 2019-12-09 14:41 ` Jürgen Groß 2019-12-09 14:41 ` Jürgen Groß 2019-12-09 14:43 ` Durrant, Paul 2019-12-09 14:43 ` Durrant, Paul 2019-12-09 12:01 ` Durrant, Paul 2019-12-09 12:01 ` Durrant, Paul 2019-12-09 12:25 ` Roger Pau Monné 2019-12-09 12:25 ` Roger Pau Monné 2019-12-09 12:40 ` Durrant, Paul 2019-12-09 12:40 ` Durrant, Paul 2019-12-09 14:28 ` Roger Pau Monné 2019-12-09 14:28 ` Roger Pau Monné 2019-12-09 14:41 ` Durrant, Paul 2019-12-09 14:41 ` Durrant, Paul 2019-12-09 15:13 ` Roger Pau Monné 2019-12-09 15:13 ` Roger Pau Monné 2019-12-09 16:26 ` Durrant, Paul 2019-12-09 16:26 ` Durrant, Paul 2019-12-09 17:17 ` Roger Pau Monné 2019-12-09 17:17 ` Roger Pau Monné 2019-12-09 17:23 ` Durrant, Paul 2019-12-09 17:23 ` Durrant, Paul 2019-12-05 14:01 ` [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 11:41 ` Roger Pau Monné 2019-12-09 11:41 ` Roger Pau Monné 2019-12-09 11:52 ` Jürgen Groß 2019-12-09 11:52 ` Jürgen Groß 2019-12-09 12:50 ` Durrant, Paul 2019-12-09 12:50 ` Durrant, Paul 2019-12-09 13:55 ` Jürgen Groß 2019-12-09 13:55 ` [Xen-devel] " Jürgen Groß 2019-12-09 16:38 ` Durrant, Paul 2019-12-09 16:38 ` [Xen-devel] " Durrant, Paul 2019-12-10 11:42 ` Jürgen Groß 2019-12-10 11:42 ` [Xen-devel] " Jürgen Groß 2019-12-05 14:01 ` [PATCH 4/4] xen-blkback: support dynamic unbind/bind Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 12:17 ` Roger Pau Monné 2019-12-09 12:17 ` [Xen-devel] " Roger Pau Monné 2019-12-09 12:24 ` Durrant, Paul 2019-12-09 12:24 ` [Xen-devel] " Durrant, Paul 2019-12-09 13:57 ` Jürgen Groß 2019-12-09 13:57 ` [Xen-devel] " Jürgen Groß 2019-12-09 14:01 ` Durrant, Paul 2019-12-09 14:01 ` [Xen-devel] " Durrant, Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191205140123.3817-3-pdurrant@amazon.com \ --to=pdurrant@amazon.com \ --cc=boris.ostrovsky@oracle.com \ --cc=jgross@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.