All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Boris Brezillon <bbrezillon@kernel.org>
Subject: [PATCH v5 40/52] drm/omap: venc: Remove omap_dss_device operations
Date: Fri, 24 Jan 2020 05:54:33 +0200	[thread overview]
Message-ID: <20200124035445.1830-41-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20200124035445.1830-1-laurent.pinchart@ideasonboard.com>

Now that the VENC output is driven fully through the drm_bridge API its
omap_dss_device operations are not used anymore. Remove them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/dss/venc.c | 45 ------------------------------
 1 file changed, 45 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
index be73ffcb3708..21409d755c5b 100644
--- a/drivers/gpu/drm/omapdrm/dss/venc.c
+++ b/drivers/gpu/drm/omapdrm/dss/venc.c
@@ -306,7 +306,6 @@ struct venc_device {
 	struct drm_bridge bridge;
 };
 
-#define dssdev_to_venc(dssdev) container_of(dssdev, struct venc_device, output)
 #define drm_bridge_to_venc(b) container_of(b, struct venc_device, bridge)
 
 static inline void venc_write_reg(struct venc_device *venc, int idx, u32 val)
@@ -479,30 +478,6 @@ static void venc_power_off(struct venc_device *venc)
 	venc_runtime_put(venc);
 }
 
-static int venc_get_modes(struct omap_dss_device *dssdev,
-			  struct drm_connector *connector)
-{
-	static const struct drm_display_mode *modes[] = {
-		&omap_dss_pal_mode,
-		&omap_dss_ntsc_mode,
-	};
-	unsigned int i;
-
-	for (i = 0; i < ARRAY_SIZE(modes); ++i) {
-		struct drm_display_mode *mode;
-
-		mode = drm_mode_duplicate(connector->dev, modes[i]);
-		if (!mode)
-			return i;
-
-		mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
-		drm_mode_set_name(mode);
-		drm_mode_probed_add(connector, mode);
-	}
-
-	return ARRAY_SIZE(modes);
-}
-
 static enum venc_videomode venc_get_videomode(const struct drm_display_mode *mode)
 {
 	if (!(mode->flags & DRM_MODE_FLAG_INTERLACE))
@@ -598,25 +573,6 @@ static int venc_get_clocks(struct venc_device *venc)
 	return 0;
 }
 
-static int venc_connect(struct omap_dss_device *src,
-			struct omap_dss_device *dst)
-{
-	return omapdss_device_connect(dst->dss, dst, dst->next);
-}
-
-static void venc_disconnect(struct omap_dss_device *src,
-			    struct omap_dss_device *dst)
-{
-	omapdss_device_disconnect(dst, dst->next);
-}
-
-static const struct omap_dss_device_ops venc_ops = {
-	.connect = venc_connect,
-	.disconnect = venc_disconnect,
-
-	.get_modes = venc_get_modes,
-};
-
 /* -----------------------------------------------------------------------------
  * DRM Bridge Operations
  */
@@ -818,7 +774,6 @@ static int venc_init_output(struct venc_device *venc)
 	out->type = OMAP_DISPLAY_TYPE_VENC;
 	out->name = "venc.0";
 	out->dispc_channel = OMAP_DSS_CHANNEL_DIGIT;
-	out->ops = &venc_ops;
 	out->owner = THIS_MODULE;
 	out->of_port = 0;
 	out->ops_flags = OMAP_DSS_DEVICE_OP_MODES;
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-01-24  3:56 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24  3:53 [PATCH v5 00/52] drm/omap: Replace custom display drivers with drm_bridge and drm_panel Laurent Pinchart
2020-01-24  3:53 ` [PATCH v5 01/52] video: hdmi: Change return type of hdmi_avi_infoframe_init() to void Laurent Pinchart
2020-01-24  3:53 ` [PATCH v5 02/52] drm/connector: Add helper to get a connector type name Laurent Pinchart
2020-01-24  3:53 ` [PATCH v5 03/52] drm/edid: Add flag to drm_display_info to identify HDMI sinks Laurent Pinchart
2020-01-24  3:53 ` [PATCH v5 04/52] drm/bridge: Add connector-related bridge operations and data Laurent Pinchart
2020-01-24  3:53 ` [PATCH v5 05/52] drm/bridge: Add interlace_allowed flag to drm_bridge Laurent Pinchart
2020-01-24  3:53 ` [PATCH v5 06/52] drm/bridge: Extend bridge API to disable connector creation Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 07/52] drm/bridge: dumb-vga-dac: Rename internal symbols to simple-bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 08/52] drm/bridge: dumb-vga-dac: Rename driver " Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 09/52] drm/bridge: simple-bridge: Add support for non-VGA bridges Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 10/52] drm/bridge: simple-bridge: Add support for enable GPIO Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 11/52] drm/bridge: simple-bridge: Add support for the TI OPA362 Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 12/52] drm/bridge: Add bridge driver for display connectors Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 13/52] drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 14/52] drm/bridge: panel: Implement bridge connector operations Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 15/52] drm/bridge: tfp410: Replace manual connector handling with bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 16/52] drm/bridge: tfp410: Allow operation without drm_connector Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 17/52] drm: Add helper to create a connector for a chain of bridges Laurent Pinchart
2020-01-28 11:19   ` Tomi Valkeinen
2020-02-16 15:39     ` Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 18/52] drm/omap: Fix possible object reference leak Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 19/52] drm/omap: dss: Cleanup DSS ports on initialisation failure Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 20/52] drm/omap: Simplify HDMI mode and infoframe configuration Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 21/52] drm/omap: Factor out display type to connector type conversion Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 22/52] drm/omap: Use the drm_panel_bridge API Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 23/52] drm/omap: dss: Fix output next device lookup in DT Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 24/52] drm/omap: Add infrastructure to support drm_bridge local to DSS outputs Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 25/52] drm/omap: dss: Make omap_dss_device_ops optional Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 26/52] drm/omap: hdmi: Allocate EDID in the .read_edid() operation Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 27/52] drm/omap: hdmi4: Rework EDID read to isolate data read Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 28/52] drm/omap: hdmi5: " Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 29/52] drm/omap: hdmi4: Register a drm_bridge for EDID read Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 30/52] drm/omap: hdmi5: " Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 31/52] drm/omap: hdmi4: Move mode set, enable and disable operations to bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 32/52] drm/omap: hdmi5: " Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 33/52] drm/omap: hdmi4: Implement drm_bridge .hpd_notify() operation Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 34/52] drm/omap: dss: Remove .set_hdmi_mode() and .set_infoframe() operations Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 35/52] drm/omap: venc: Register a drm_bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 36/52] drm/omap: Create connector for bridges Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 37/52] drm/omap: Switch the HDMI and VENC outputs to drm_bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 38/52] drm/omap: Remove HPD, detect and EDID omapdss operations Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 39/52] drm/omap: hdmi: Remove omap_dss_device operations Laurent Pinchart
2020-01-24  3:54 ` Laurent Pinchart [this message]
2020-01-24  3:54 ` [PATCH v5 41/52] drm/omap: hdmi4: Simplify EDID read Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 42/52] drm/omap: hdmi5: " Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 43/52] drm/omap: dpi: Sort includes alphabetically Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 44/52] drm/omap: dpi: Reorder functions in sections Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 45/52] drm/omap: dpi: Simplify clock setting API Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 46/52] drm/omap: dpi: Register a drm_bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 47/52] drm/omap: sdi: Sort includes alphabetically Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 48/52] drm/omap: sdi: Register a drm_bridge Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 49/52] drm/omap: Hardcode omap_connector type to DSI Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 50/52] drm/omap: dss: Remove unused omap_dss_device operations Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 51/52] drm/omap: dss: Inline the omapdss_display_get() function Laurent Pinchart
2020-01-24  3:54 ` [PATCH v5 52/52] drm/omap: dss: Remove unused omapdss_of_find_connected_device() function Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200124035445.1830-41-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bbrezillon@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.