From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: [PATCH 23/52] drm: manage drm_minor cleanup with drmm_ Date: Wed, 19 Feb 2020 11:20:53 +0100 [thread overview] Message-ID: <20200219102122.1607365-24-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20200219102122.1607365-1-daniel.vetter@ffwll.ch> The cleanup here is somewhat tricky, since we can't tell apart the allocated minor index from 0. So register a cleanup action first, and if the index allocation fails, unregister that cleanup action again to avoid bad mistakes. The kdev for the minor already handles NULL, so no problem there. Hence add drmm_remove_action() to the drm_managed library. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/drm_drv.c | 74 +++++++++++++---------------------- drivers/gpu/drm/drm_managed.c | 28 +++++++++++++ include/drm/drm_managed.h | 4 ++ 3 files changed, 59 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 1f7ab88d9435..03a1fb377830 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -93,19 +93,35 @@ static struct drm_minor **drm_minor_get_slot(struct drm_device *dev, } } +static void drm_minor_alloc_release(struct drm_device *dev, void *data) +{ + struct drm_minor *minor = data; + unsigned long flags; + + put_device(minor->kdev); + + spin_lock_irqsave(&drm_minor_lock, flags); + idr_remove(&drm_minors_idr, minor->index); + spin_unlock_irqrestore(&drm_minor_lock, flags); +} + static int drm_minor_alloc(struct drm_device *dev, unsigned int type) { struct drm_minor *minor; unsigned long flags; int r; - minor = kzalloc(sizeof(*minor), GFP_KERNEL); + minor = drmm_kzalloc(dev, sizeof(*minor), GFP_KERNEL); if (!minor) return -ENOMEM; minor->type = type; minor->dev = dev; + r = drmm_add_action(dev, drm_minor_alloc_release, minor); + if (r) + return r; + idr_preload(GFP_KERNEL); spin_lock_irqsave(&drm_minor_lock, flags); r = idr_alloc(&drm_minors_idr, @@ -116,47 +132,18 @@ static int drm_minor_alloc(struct drm_device *dev, unsigned int type) spin_unlock_irqrestore(&drm_minor_lock, flags); idr_preload_end(); - if (r < 0) - goto err_free; + if (r < 0) { + drmm_remove_action(dev, drm_minor_alloc_release, minor); + return r; + } minor->index = r; - minor->kdev = drm_sysfs_minor_alloc(minor); - if (IS_ERR(minor->kdev)) { - r = PTR_ERR(minor->kdev); - goto err_index; - } + if (IS_ERR(minor->kdev)) + return PTR_ERR(minor->kdev); *drm_minor_get_slot(dev, type) = minor; return 0; - -err_index: - spin_lock_irqsave(&drm_minor_lock, flags); - idr_remove(&drm_minors_idr, minor->index); - spin_unlock_irqrestore(&drm_minor_lock, flags); -err_free: - kfree(minor); - return r; -} - -static void drm_minor_free(struct drm_device *dev, unsigned int type) -{ - struct drm_minor **slot, *minor; - unsigned long flags; - - slot = drm_minor_get_slot(dev, type); - minor = *slot; - if (!minor) - return; - - put_device(minor->kdev); - - spin_lock_irqsave(&drm_minor_lock, flags); - idr_remove(&drm_minors_idr, minor->index); - spin_unlock_irqrestore(&drm_minor_lock, flags); - - kfree(minor); - *slot = NULL; } static int drm_minor_register(struct drm_device *dev, unsigned int type) @@ -678,16 +665,16 @@ int drm_dev_init(struct drm_device *dev, if (drm_core_check_feature(dev, DRIVER_RENDER)) { ret = drm_minor_alloc(dev, DRM_MINOR_RENDER); if (ret) - goto err_minors; + goto err; } ret = drm_minor_alloc(dev, DRM_MINOR_PRIMARY); if (ret) - goto err_minors; + goto err; ret = drm_legacy_create_map_hash(dev); if (ret) - goto err_minors; + goto err; drm_legacy_ctxbitmap_init(dev); @@ -695,7 +682,7 @@ int drm_dev_init(struct drm_device *dev, ret = drm_gem_init(dev); if (ret) { DRM_ERROR("Cannot initialize graphics execution manager (GEM)\n"); - goto err_ctxbitmap; + goto err; } } @@ -708,10 +695,6 @@ int drm_dev_init(struct drm_device *dev, err_setunique: if (drm_core_check_feature(dev, DRIVER_GEM)) drm_gem_destroy(dev); -err_ctxbitmap: -err_minors: - drm_minor_free(dev, DRM_MINOR_PRIMARY); - drm_minor_free(dev, DRM_MINOR_RENDER); err: drm_managed_release(dev); @@ -776,9 +759,6 @@ void drm_dev_fini(struct drm_device *dev) if (drm_core_check_feature(dev, DRIVER_GEM)) drm_gem_destroy(dev); - - drm_minor_free(dev, DRM_MINOR_PRIMARY); - drm_minor_free(dev, DRM_MINOR_RENDER); } EXPORT_SYMBOL(drm_dev_fini); diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c index d8a484e19830..fb44fe65c2cd 100644 --- a/drivers/gpu/drm/drm_managed.c +++ b/drivers/gpu/drm/drm_managed.c @@ -132,6 +132,34 @@ int __drmm_add_action(struct drm_device *dev, } EXPORT_SYMBOL(__drmm_add_action); +void drmm_remove_action(struct drm_device *dev, + drmres_release_t action, + void *data) +{ + struct drmres *dr = NULL, *tmp; + unsigned long flags; + + if (!data) + return; + + spin_lock_irqsave(&dev->managed.lock, flags); + list_for_each_entry(tmp, &dev->managed.resources, node.entry) { + if (tmp->node.release == action && + * (void **) tmp->data == data) { + dr = tmp; + del_dr(dev, dr); + break; + } + } + spin_unlock_irqrestore(&dev->managed.lock, flags); + + if (WARN_ON(!dr)) + return; + + kfree(dr); +} +EXPORT_SYMBOL(drmm_remove_action); + void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) { struct drmres *dr; diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h index 240edd395e88..df30f9355902 100644 --- a/include/drm/drm_managed.h +++ b/include/drm/drm_managed.h @@ -14,6 +14,10 @@ int __must_check __drmm_add_action(struct drm_device *dev, drmres_release_t action, void *data, const char *name); +void drmm_remove_action(struct drm_device *dev, + drmres_release_t action, + void *data); + void drmm_add_final_kfree(struct drm_device *dev, void *parent); void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) __malloc; -- 2.24.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: [Intel-gfx] [PATCH 23/52] drm: manage drm_minor cleanup with drmm_ Date: Wed, 19 Feb 2020 11:20:53 +0100 [thread overview] Message-ID: <20200219102122.1607365-24-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20200219102122.1607365-1-daniel.vetter@ffwll.ch> The cleanup here is somewhat tricky, since we can't tell apart the allocated minor index from 0. So register a cleanup action first, and if the index allocation fails, unregister that cleanup action again to avoid bad mistakes. The kdev for the minor already handles NULL, so no problem there. Hence add drmm_remove_action() to the drm_managed library. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/drm_drv.c | 74 +++++++++++++---------------------- drivers/gpu/drm/drm_managed.c | 28 +++++++++++++ include/drm/drm_managed.h | 4 ++ 3 files changed, 59 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 1f7ab88d9435..03a1fb377830 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -93,19 +93,35 @@ static struct drm_minor **drm_minor_get_slot(struct drm_device *dev, } } +static void drm_minor_alloc_release(struct drm_device *dev, void *data) +{ + struct drm_minor *minor = data; + unsigned long flags; + + put_device(minor->kdev); + + spin_lock_irqsave(&drm_minor_lock, flags); + idr_remove(&drm_minors_idr, minor->index); + spin_unlock_irqrestore(&drm_minor_lock, flags); +} + static int drm_minor_alloc(struct drm_device *dev, unsigned int type) { struct drm_minor *minor; unsigned long flags; int r; - minor = kzalloc(sizeof(*minor), GFP_KERNEL); + minor = drmm_kzalloc(dev, sizeof(*minor), GFP_KERNEL); if (!minor) return -ENOMEM; minor->type = type; minor->dev = dev; + r = drmm_add_action(dev, drm_minor_alloc_release, minor); + if (r) + return r; + idr_preload(GFP_KERNEL); spin_lock_irqsave(&drm_minor_lock, flags); r = idr_alloc(&drm_minors_idr, @@ -116,47 +132,18 @@ static int drm_minor_alloc(struct drm_device *dev, unsigned int type) spin_unlock_irqrestore(&drm_minor_lock, flags); idr_preload_end(); - if (r < 0) - goto err_free; + if (r < 0) { + drmm_remove_action(dev, drm_minor_alloc_release, minor); + return r; + } minor->index = r; - minor->kdev = drm_sysfs_minor_alloc(minor); - if (IS_ERR(minor->kdev)) { - r = PTR_ERR(minor->kdev); - goto err_index; - } + if (IS_ERR(minor->kdev)) + return PTR_ERR(minor->kdev); *drm_minor_get_slot(dev, type) = minor; return 0; - -err_index: - spin_lock_irqsave(&drm_minor_lock, flags); - idr_remove(&drm_minors_idr, minor->index); - spin_unlock_irqrestore(&drm_minor_lock, flags); -err_free: - kfree(minor); - return r; -} - -static void drm_minor_free(struct drm_device *dev, unsigned int type) -{ - struct drm_minor **slot, *minor; - unsigned long flags; - - slot = drm_minor_get_slot(dev, type); - minor = *slot; - if (!minor) - return; - - put_device(minor->kdev); - - spin_lock_irqsave(&drm_minor_lock, flags); - idr_remove(&drm_minors_idr, minor->index); - spin_unlock_irqrestore(&drm_minor_lock, flags); - - kfree(minor); - *slot = NULL; } static int drm_minor_register(struct drm_device *dev, unsigned int type) @@ -678,16 +665,16 @@ int drm_dev_init(struct drm_device *dev, if (drm_core_check_feature(dev, DRIVER_RENDER)) { ret = drm_minor_alloc(dev, DRM_MINOR_RENDER); if (ret) - goto err_minors; + goto err; } ret = drm_minor_alloc(dev, DRM_MINOR_PRIMARY); if (ret) - goto err_minors; + goto err; ret = drm_legacy_create_map_hash(dev); if (ret) - goto err_minors; + goto err; drm_legacy_ctxbitmap_init(dev); @@ -695,7 +682,7 @@ int drm_dev_init(struct drm_device *dev, ret = drm_gem_init(dev); if (ret) { DRM_ERROR("Cannot initialize graphics execution manager (GEM)\n"); - goto err_ctxbitmap; + goto err; } } @@ -708,10 +695,6 @@ int drm_dev_init(struct drm_device *dev, err_setunique: if (drm_core_check_feature(dev, DRIVER_GEM)) drm_gem_destroy(dev); -err_ctxbitmap: -err_minors: - drm_minor_free(dev, DRM_MINOR_PRIMARY); - drm_minor_free(dev, DRM_MINOR_RENDER); err: drm_managed_release(dev); @@ -776,9 +759,6 @@ void drm_dev_fini(struct drm_device *dev) if (drm_core_check_feature(dev, DRIVER_GEM)) drm_gem_destroy(dev); - - drm_minor_free(dev, DRM_MINOR_PRIMARY); - drm_minor_free(dev, DRM_MINOR_RENDER); } EXPORT_SYMBOL(drm_dev_fini); diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c index d8a484e19830..fb44fe65c2cd 100644 --- a/drivers/gpu/drm/drm_managed.c +++ b/drivers/gpu/drm/drm_managed.c @@ -132,6 +132,34 @@ int __drmm_add_action(struct drm_device *dev, } EXPORT_SYMBOL(__drmm_add_action); +void drmm_remove_action(struct drm_device *dev, + drmres_release_t action, + void *data) +{ + struct drmres *dr = NULL, *tmp; + unsigned long flags; + + if (!data) + return; + + spin_lock_irqsave(&dev->managed.lock, flags); + list_for_each_entry(tmp, &dev->managed.resources, node.entry) { + if (tmp->node.release == action && + * (void **) tmp->data == data) { + dr = tmp; + del_dr(dev, dr); + break; + } + } + spin_unlock_irqrestore(&dev->managed.lock, flags); + + if (WARN_ON(!dr)) + return; + + kfree(dr); +} +EXPORT_SYMBOL(drmm_remove_action); + void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) { struct drmres *dr; diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h index 240edd395e88..df30f9355902 100644 --- a/include/drm/drm_managed.h +++ b/include/drm/drm_managed.h @@ -14,6 +14,10 @@ int __must_check __drmm_add_action(struct drm_device *dev, drmres_release_t action, void *data, const char *name); +void drmm_remove_action(struct drm_device *dev, + drmres_release_t action, + void *data); + void drmm_add_final_kfree(struct drm_device *dev, void *parent); void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) __malloc; -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-19 10:22 UTC|newest] Thread overview: 310+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 10:20 [PATCH 00/52] drm_device managed resources Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 01/52] mm/sl[uo]b: export __kmalloc_track(_node)_caller Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-19 19:42 ` Andrew Morton 2020-02-19 19:42 ` [Intel-gfx] " Andrew Morton 2020-02-19 19:42 ` Andrew Morton 2020-02-22 3:42 ` Christopher Lameter 2020-02-22 3:42 ` [Intel-gfx] " Christopher Lameter 2020-02-22 3:42 ` Christopher Lameter 2020-02-19 10:20 ` [PATCH 02/52] drm/i915: Don't clear drvdata in ->release Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 03/52] drm: add managed resources tied to drm_device Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 12:31 ` Neil Armstrong 2020-02-19 12:31 ` [Intel-gfx] " Neil Armstrong 2020-02-19 13:24 ` Daniel Vetter 2020-02-19 13:24 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:28 ` Laurent Pinchart 2020-02-19 13:28 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:33 ` Greg Kroah-Hartman 2020-02-19 13:33 ` [Intel-gfx] " Greg Kroah-Hartman 2020-02-19 14:22 ` Daniel Vetter 2020-02-19 14:22 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:09 ` Emil Velikov 2020-02-19 16:09 ` Emil Velikov 2020-02-19 16:22 ` Daniel Vetter 2020-02-19 16:22 ` Daniel Vetter 2020-02-19 16:41 ` Emil Velikov 2020-02-19 16:41 ` Emil Velikov 2020-02-19 16:46 ` Laurent Pinchart 2020-02-19 16:46 ` Laurent Pinchart 2020-02-19 16:53 ` Daniel Vetter 2020-02-19 16:53 ` Daniel Vetter 2020-02-19 17:02 ` Laurent Pinchart 2020-02-19 17:02 ` Laurent Pinchart 2020-02-19 17:06 ` Daniel Vetter 2020-02-19 17:06 ` Daniel Vetter 2020-02-19 17:00 ` Greg Kroah-Hartman 2020-02-19 17:00 ` [Intel-gfx] " Greg Kroah-Hartman 2020-02-19 17:36 ` Laurent Pinchart 2020-02-19 17:36 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 18:19 ` Greg Kroah-Hartman 2020-02-19 18:19 ` [Intel-gfx] " Greg Kroah-Hartman 2020-02-19 19:57 ` Daniel Vetter 2020-02-19 19:57 ` [Intel-gfx] " Daniel Vetter 2020-02-20 14:58 ` Laurent Pinchart 2020-02-20 14:58 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:57 ` Daniel Vetter 2020-02-19 13:57 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 04/52] drm: Set final_kfree in drm_dev_alloc Daniel Vetter 2020-02-19 10:20 ` [Xen-devel] " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 12:03 ` Oleksandr Andrushchenko 2020-02-19 12:03 ` [Xen-devel] " Oleksandr Andrushchenko 2020-02-19 12:03 ` [Intel-gfx] " Oleksandr Andrushchenko 2020-02-19 13:39 ` Laurent Pinchart 2020-02-19 13:39 ` [Xen-devel] " Laurent Pinchart 2020-02-19 13:39 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:41 ` Daniel Vetter 2020-02-19 14:41 ` [Xen-devel] " Daniel Vetter 2020-02-19 14:41 ` [Intel-gfx] " Daniel Vetter 2020-02-21 19:07 ` Daniel Vetter 2020-02-21 19:07 ` [Xen-devel] " Daniel Vetter 2020-02-21 19:07 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 05/52] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 11:47 ` Thomas Zimmermann 2020-02-19 11:47 ` [Intel-gfx] " Thomas Zimmermann 2020-02-19 12:45 ` Thomas Zimmermann 2020-02-19 12:45 ` [Intel-gfx] " Thomas Zimmermann 2020-02-19 13:23 ` Daniel Vetter 2020-02-19 13:23 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:29 ` Thomas Zimmermann 2020-02-19 13:29 ` [Intel-gfx] " Thomas Zimmermann 2020-02-19 14:32 ` Daniel Vetter 2020-02-19 14:32 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:18 ` Noralf Trønnes 2020-02-20 16:18 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:20 ` [PATCH 06/52] drm/udl: Use drmm_add_final_kfree Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 07/52] " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:42 ` Laurent Pinchart 2020-02-19 13:42 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:43 ` Daniel Vetter 2020-02-19 14:43 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 08/52] drm/qxl: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-19 10:20 ` [PATCH 09/52] drm/i915: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 10/52] drm/cirrus: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-24 8:13 ` Gerd Hoffmann 2020-02-24 8:13 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:13 ` Gerd Hoffmann 2020-02-19 10:20 ` [PATCH 11/52] drm/v3d: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 18:43 ` Eric Anholt 2020-02-19 18:43 ` [Intel-gfx] " Eric Anholt 2020-02-19 10:20 ` [PATCH 12/52] drm/tidss: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 13/52] drm/mcde: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:12 ` Linus Walleij 2020-02-19 16:12 ` [Intel-gfx] " Linus Walleij 2020-02-19 10:20 ` [PATCH 14/52] drm/vgem: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 15/52] drm/vkms: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 16/52] drm/repaper: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:18 ` Noralf Trønnes 2020-02-20 16:18 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:20 ` [PATCH 17/52] drm/inigenic: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 18/52] drm/gm12u320: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 19/52] drm/<drivers>: " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:11 ` Laurent Pinchart 2020-02-19 14:11 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:30 ` Daniel Vetter 2020-02-19 14:30 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:39 ` Laurent Pinchart 2020-02-19 14:39 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:29 ` Daniel Vetter 2020-02-19 15:29 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 20/52] drm: Cleanups after drmm_add_final_kfree rollout Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 21/52] drm: Handle dev->unique with drmm_ Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:28 ` Laurent Pinchart 2020-02-19 14:28 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:24 ` Daniel Vetter 2020-02-19 15:24 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 22/52] drm: Use drmm_ for drm_dev_init cleanup Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:35 ` Laurent Pinchart 2020-02-19 14:35 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:27 ` Daniel Vetter 2020-02-19 15:27 ` [Intel-gfx] " Daniel Vetter 2020-02-19 15:37 ` Laurent Pinchart 2020-02-19 15:37 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:44 ` Daniel Vetter 2020-02-19 15:44 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter [this message] 2020-02-19 10:20 ` [Intel-gfx] [PATCH 23/52] drm: manage drm_minor cleanup with drmm_ Daniel Vetter 2020-02-19 14:47 ` Laurent Pinchart 2020-02-19 14:47 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:34 ` Daniel Vetter 2020-02-19 15:34 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 24/52] drm: Manage drm_gem_init " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:22 ` Laurent Pinchart 2020-02-19 14:22 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:37 ` Daniel Vetter 2020-02-19 14:37 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:52 ` Laurent Pinchart 2020-02-19 14:52 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 14:56 ` Daniel Vetter 2020-02-19 14:56 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 25/52] drm: Manage drm_vblank_cleanup " Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 26/52] drm: Garbage collect drm_dev_fini Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 27/52] drm: Manage drm_mode_config_init with drmm_ Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 13:49 ` Laurent Pinchart 2020-02-19 13:49 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:47 ` Daniel Vetter 2020-02-19 15:47 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:07 ` Laurent Pinchart 2020-02-19 16:07 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 16:23 ` Daniel Vetter 2020-02-19 16:23 ` [Intel-gfx] " Daniel Vetter 2020-02-19 17:30 ` Noralf Trønnes 2020-02-19 17:30 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 18:12 ` Daniel Vetter 2020-02-19 18:12 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` [PATCH 28/52] drm/bochs: Remove leftover drm_atomic_helper_shutdown Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-24 8:14 ` Gerd Hoffmann 2020-02-24 8:14 ` [Intel-gfx] " Gerd Hoffmann 2020-02-19 10:20 ` [PATCH 29/52] drm/bochs: Drop explicit drm_mode_config_cleanup Daniel Vetter 2020-02-19 10:20 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:20 ` Daniel Vetter 2020-02-24 8:15 ` Gerd Hoffmann 2020-02-24 8:15 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:15 ` Gerd Hoffmann 2020-02-19 10:21 ` [PATCH 30/52] drm/cirrus: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-24 8:16 ` Gerd Hoffmann 2020-02-24 8:16 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:16 ` Gerd Hoffmann 2020-02-19 10:21 ` [PATCH 31/52] drm/cirrus: Fully embrace devm_ Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-24 8:18 ` Gerd Hoffmann 2020-02-24 8:18 ` [Intel-gfx] " Gerd Hoffmann 2020-02-24 8:18 ` Gerd Hoffmann 2020-02-19 10:21 ` [PATCH 32/52] drm/ingenic: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 33/52] drm/mcde: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:12 ` Linus Walleij 2020-02-19 16:12 ` [Intel-gfx] " Linus Walleij 2020-02-19 10:21 ` [PATCH 34/52] drm/mcde: More devm_drm_dev_init Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 16:13 ` Linus Walleij 2020-02-19 16:13 ` [Intel-gfx] " Linus Walleij 2020-02-19 10:21 ` [PATCH 35/52] drm/meson: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:39 ` Neil Armstrong 2020-02-19 10:39 ` Neil Armstrong 2020-02-19 10:39 ` [Intel-gfx] " Neil Armstrong 2020-02-19 10:39 ` Neil Armstrong 2020-02-19 10:21 ` [PATCH 36/52] drm/pl111: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 37/52] drm/rcar-du: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:30 ` Geert Uytterhoeven 2020-02-19 10:30 ` [Intel-gfx] " Geert Uytterhoeven 2020-02-19 10:30 ` Geert Uytterhoeven 2020-02-19 10:56 ` Daniel Vetter 2020-02-19 10:56 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:56 ` Daniel Vetter 2020-02-19 11:10 ` Geert Uytterhoeven 2020-02-19 11:10 ` [Intel-gfx] " Geert Uytterhoeven 2020-02-19 11:10 ` Geert Uytterhoeven 2020-02-19 12:17 ` Laurent Pinchart 2020-02-19 12:17 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 12:17 ` Laurent Pinchart 2020-02-19 12:40 ` Daniel Vetter 2020-02-19 12:40 ` [Intel-gfx] " Daniel Vetter 2020-02-19 12:40 ` Daniel Vetter 2020-02-19 13:53 ` Laurent Pinchart 2020-02-19 13:53 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:53 ` Laurent Pinchart 2020-02-19 14:29 ` Daniel Vetter 2020-02-19 14:29 ` [Intel-gfx] " Daniel Vetter 2020-02-19 14:29 ` Daniel Vetter [not found] ` <20200219102122.1607365-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> 2020-02-19 10:21 ` [PATCH 38/52] drm/rockchip: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 10:21 ` [PATCH 39/52] drm/stm: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-20 14:18 ` Philippe CORNU 2020-02-20 14:18 ` [Intel-gfx] " Philippe CORNU 2020-02-20 14:18 ` Philippe CORNU 2020-02-20 16:12 ` Daniel Vetter 2020-02-20 16:12 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:12 ` Daniel Vetter 2020-02-19 10:21 ` [PATCH 40/52] drm/shmob: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` Daniel Vetter 2020-02-19 13:57 ` Laurent Pinchart 2020-02-19 13:57 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 13:57 ` Laurent Pinchart 2020-02-19 10:21 ` [PATCH 41/52] drm/mtk: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 42/52] drm/tidss: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 43/52] drm/gm12u320: More drmm_ Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 44/52] drm/gm12u320: Use devm_drm_dev_init Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 45/52] drm/gm12u320: Use helpers for shutdown/suspend/resume Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 46/52] drm/gm12u320: Simplify upload work Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 47/52] drm/repaper: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:21 ` Noralf Trønnes 2020-02-20 16:21 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:21 ` [PATCH 48/52] drm/mipi-dbi: Move drm_mode_config_init into mipi library Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:22 ` Noralf Trønnes 2020-02-20 16:22 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:21 ` [PATCH 49/52] drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-20 16:22 ` Noralf Trønnes 2020-02-20 16:22 ` [Intel-gfx] " Noralf Trønnes 2020-02-19 10:21 ` [PATCH 50/52] drm/udl: " Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 51/52] drm/udl: drop drm_driver.release hook Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 10:21 ` [PATCH 52/52] drm: Add docs for managed resources Daniel Vetter 2020-02-19 10:21 ` [Intel-gfx] " Daniel Vetter 2020-02-19 15:08 ` Laurent Pinchart 2020-02-19 15:08 ` [Intel-gfx] " Laurent Pinchart 2020-02-19 15:40 ` Daniel Vetter 2020-02-19 15:40 ` [Intel-gfx] " Daniel Vetter 2020-02-21 20:23 ` Sam Ravnborg 2020-02-21 20:23 ` [Intel-gfx] " Sam Ravnborg 2020-02-21 21:13 ` Sam Ravnborg 2020-02-21 21:13 ` [Intel-gfx] " Sam Ravnborg 2020-02-19 11:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_device " Patchwork 2020-02-19 11:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-02-19 11:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-02-21 1:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200219102122.1607365-24-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.