All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
To: jani.nikula@linux.intel.com, daniel@ffwll.ch,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com>
Subject: [PATCH 10/18] drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON
Date: Mon,  6 Apr 2020 16:57:52 +0530	[thread overview]
Message-ID: <20200406112800.23762-11-pankaj.laxminarayan.bharadiya@intel.com> (raw)
In-Reply-To: <20200406112800.23762-1-pankaj.laxminarayan.bharadiya@intel.com>

struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.

Prefer drm_WARN_ON over WARN_ON.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
 drivers/gpu/drm/i915/display/intel_overlay.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 6e1d66323223..66711e62fa71 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -281,7 +281,7 @@ static void intel_overlay_flip_prepare(struct intel_overlay *overlay,
 	enum pipe pipe = overlay->crtc->pipe;
 	struct intel_frontbuffer *from = NULL, *to = NULL;
 
-	WARN_ON(overlay->old_vma);
+	drm_WARN_ON(&overlay->i915->drm, overlay->old_vma);
 
 	if (overlay->vma)
 		from = intel_frontbuffer_get(overlay->vma->obj);
@@ -350,7 +350,7 @@ static void intel_overlay_release_old_vma(struct intel_overlay *overlay)
 	struct i915_vma *vma;
 
 	vma = fetch_and_zero(&overlay->old_vma);
-	if (WARN_ON(!vma))
+	if (drm_WARN_ON(&overlay->i915->drm, !vma))
 		return;
 
 	intel_frontbuffer_flip_complete(overlay->i915,
@@ -396,7 +396,7 @@ static int intel_overlay_off(struct intel_overlay *overlay)
 	struct i915_request *rq;
 	u32 *cs, flip_addr = overlay->flip_addr;
 
-	WARN_ON(!overlay->active);
+	drm_WARN_ON(&overlay->i915->drm, !overlay->active);
 
 	/* According to intel docs the overlay hw may hang (when switching
 	 * off) without loading the filter coeffs. It is however unclear whether
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
To: jani.nikula@linux.intel.com, daniel@ffwll.ch,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"David Airlie" <airlied@linux.ie>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com>
Subject: [Intel-gfx] [PATCH 10/18] drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON
Date: Mon,  6 Apr 2020 16:57:52 +0530	[thread overview]
Message-ID: <20200406112800.23762-11-pankaj.laxminarayan.bharadiya@intel.com> (raw)
In-Reply-To: <20200406112800.23762-1-pankaj.laxminarayan.bharadiya@intel.com>

struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.

Prefer drm_WARN_ON over WARN_ON.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
 drivers/gpu/drm/i915/display/intel_overlay.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 6e1d66323223..66711e62fa71 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -281,7 +281,7 @@ static void intel_overlay_flip_prepare(struct intel_overlay *overlay,
 	enum pipe pipe = overlay->crtc->pipe;
 	struct intel_frontbuffer *from = NULL, *to = NULL;
 
-	WARN_ON(overlay->old_vma);
+	drm_WARN_ON(&overlay->i915->drm, overlay->old_vma);
 
 	if (overlay->vma)
 		from = intel_frontbuffer_get(overlay->vma->obj);
@@ -350,7 +350,7 @@ static void intel_overlay_release_old_vma(struct intel_overlay *overlay)
 	struct i915_vma *vma;
 
 	vma = fetch_and_zero(&overlay->old_vma);
-	if (WARN_ON(!vma))
+	if (drm_WARN_ON(&overlay->i915->drm, !vma))
 		return;
 
 	intel_frontbuffer_flip_complete(overlay->i915,
@@ -396,7 +396,7 @@ static int intel_overlay_off(struct intel_overlay *overlay)
 	struct i915_request *rq;
 	u32 *cs, flip_addr = overlay->flip_addr;
 
-	WARN_ON(!overlay->active);
+	drm_WARN_ON(&overlay->i915->drm, !overlay->active);
 
 	/* According to intel docs the overlay hw may hang (when switching
 	 * off) without loading the filter coeffs. It is however unclear whether
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-04-06 11:38 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 11:27 [PATCH 00/18] Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:27 ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 01/18] drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 18:08   ` kbuild test robot
2020-04-06 18:08     ` kbuild test robot
2020-04-06 18:08     ` kbuild test robot
2020-04-06 11:27 ` [PATCH 02/18] drm/i915/display/atomic_plane: " Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 03/18] drm/i915/display/ddi: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 20:21   ` kbuild test robot
2020-04-06 20:21     ` kbuild test robot
2020-04-06 20:21     ` kbuild test robot
2020-04-06 11:27 ` [PATCH 04/18] drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 05/18] " Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  7:53   ` Jani Nikula
2020-04-21  9:19     ` Imre Deak
2020-04-06 11:27 ` [PATCH 06/18] drm/i915/display/dp: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  6:56   ` Jani Nikula
2020-04-21  6:56     ` [Intel-gfx] " Jani Nikula
2020-04-06 11:27 ` [PATCH 07/18] drm/i915/display/dpll_mgr: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 08/18] drm/i915/display/frontbuffer: " Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 09/18] drm/i915/display/global_state: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` Pankaj Bharadiya [this message]
2020-04-06 11:27   ` [Intel-gfx] [PATCH 10/18] drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 11/18] drm/i915/display/sdvo: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  6:55   ` Jani Nikula
2020-04-21  6:55     ` [Intel-gfx] " Jani Nikula
2020-04-06 11:27 ` [PATCH 12/18] drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  6:57   ` Jani Nikula
2020-04-21  6:57     ` [Intel-gfx] " Jani Nikula
2020-04-06 11:27 ` [PATCH 13/18] drm/i915/display/vlv_dsi: " Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 22:41   ` kbuild test robot
2020-04-06 11:27 ` [PATCH 14/18] drm/i915/gem: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  8:30   ` Jani Nikula
2020-04-06 11:27 ` [PATCH 15/18] drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  8:24   ` Jani Nikula
2020-04-21  8:24     ` [Intel-gfx] " Jani Nikula
2020-04-21  9:59     ` Bharadiya,Pankaj
2020-04-21  9:59       ` [Intel-gfx] " Bharadiya,Pankaj
2020-04-06 11:27 ` [PATCH 16/18] drm/i915/pmu: " Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-06 11:27 ` [PATCH 17/18] drm/i915/pm: " Pankaj Bharadiya
2020-04-06 11:27   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  8:26   ` Jani Nikula
2020-04-21  8:26     ` [Intel-gfx] " Jani Nikula
2020-04-06 11:28 ` [PATCH 18/18] drm/i915/runtime_pm: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-04-06 11:28   ` [Intel-gfx] " Pankaj Bharadiya
2020-04-21  8:28   ` Jani Nikula
2020-04-21  9:48     ` Imre Deak
2020-04-06 11:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-04-06 12:28 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-04-06 14:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prefer drm_WARN* over WARN* (rev2) Patchwork
2020-04-06 15:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-06 19:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-21  8:35 ` [Intel-gfx] [PATCH 00/18] Prefer drm_WARN* over WARN* Jani Nikula
2020-04-21 10:01   ` Bharadiya,Pankaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406112800.23762-11-pankaj.laxminarayan.bharadiya@intel.com \
    --to=pankaj.laxminarayan.bharadiya@intel.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tvrtko.ursulin@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.