All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org,
	vijendar.mukunda@amd.com, tiwai@suse.de
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Subject: [PATCH 09/14] ASoC: amd: add Renoir ACP PCI driver PM ops
Date: Tue,  5 May 2020 16:53:22 -0400	[thread overview]
Message-ID: <20200505205327.642282-10-alexander.deucher@amd.com> (raw)
In-Reply-To: <20200505205327.642282-1-alexander.deucher@amd.com>

From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

Add Renoir ACP Pci driver pm ops.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 sound/soc/amd/renoir/rn-pci-acp3x.c | 48 +++++++++++++++++++++++++++++
 sound/soc/amd/renoir/rn_acp3x.h     |  2 ++
 2 files changed, 50 insertions(+)

diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c
index 362409ef0d85..6d013a1bffa6 100644
--- a/sound/soc/amd/renoir/rn-pci-acp3x.c
+++ b/sound/soc/amd/renoir/rn-pci-acp3x.c
@@ -10,6 +10,7 @@
 #include <linux/delay.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
+#include <linux/pm_runtime.h>
 
 #include "rn_acp3x.h"
 
@@ -233,6 +234,12 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
 		ret = PTR_ERR(adata->pdev);
 		goto unregister_devs;
 	}
+	pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
+	pm_runtime_use_autosuspend(&pci->dev);
+	pm_runtime_set_active(&pci->dev);
+	pm_runtime_put_noidle(&pci->dev);
+	pm_runtime_enable(&pci->dev);
+	pm_runtime_allow(&pci->dev);
 	return 0;
 
 unregister_devs:
@@ -250,6 +257,42 @@ static int snd_rn_acp_probe(struct pci_dev *pci,
 	return ret;
 }
 
+static int snd_rn_acp_suspend(struct device *dev)
+{
+	int ret;
+	struct acp_dev_data *adata;
+
+	adata = dev_get_drvdata(dev);
+	ret = rn_acp_deinit(adata->acp_base);
+	if (ret)
+		dev_err(dev, "ACP de-init failed\n");
+	else
+		dev_dbg(dev, "ACP de-initialized\n");
+
+	return 0;
+}
+
+static int snd_rn_acp_resume(struct device *dev)
+{
+	int ret;
+	struct acp_dev_data *adata;
+
+	adata = dev_get_drvdata(dev);
+	ret = rn_acp_init(adata->acp_base);
+	if (ret) {
+		dev_err(dev, "ACP init failed\n");
+		return ret;
+	}
+	return 0;
+}
+
+static const struct dev_pm_ops rn_acp_pm = {
+	.runtime_suspend = snd_rn_acp_suspend,
+	.runtime_resume =  snd_rn_acp_resume,
+	.suspend = snd_rn_acp_suspend,
+	.resume =	snd_rn_acp_resume,
+};
+
 static void snd_rn_acp_remove(struct pci_dev *pci)
 {
 	struct acp_dev_data *adata;
@@ -260,6 +303,8 @@ static void snd_rn_acp_remove(struct pci_dev *pci)
 	ret = rn_acp_deinit(adata->acp_base);
 	if (ret)
 		dev_err(&pci->dev, "ACP de-init failed\n");
+	pm_runtime_disable(&pci->dev);
+	pm_runtime_get_noresume(&pci->dev);
 	pci_disable_msi(pci);
 	pci_release_regions(pci);
 	pci_disable_device(pci);
@@ -278,6 +323,9 @@ static struct pci_driver rn_acp_driver  = {
 	.id_table = snd_rn_acp_ids,
 	.probe = snd_rn_acp_probe,
 	.remove = snd_rn_acp_remove,
+	.driver = {
+		.pm = &rn_acp_pm,
+	}
 };
 
 module_pci_driver(rn_acp_driver);
diff --git a/sound/soc/amd/renoir/rn_acp3x.h b/sound/soc/amd/renoir/rn_acp3x.h
index f63e232565af..f24a4da8c721 100644
--- a/sound/soc/amd/renoir/rn_acp3x.h
+++ b/sound/soc/amd/renoir/rn_acp3x.h
@@ -38,6 +38,8 @@
 #define ACP_PDM_DISABLE 0x00
 #define ACP_PDM_DMA_EN_STATUS 0x02
 #define TWO_CH 0x02
+/* time in ms for runtime suspend delay */
+#define ACP_SUSPEND_DELAY_MS	2000
 
 #define ACP_SRAM_PTE_OFFSET	0x02050000
 #define PAGE_SIZE_4K_ENABLE     0x2
-- 
2.25.4


  parent reply	other threads:[~2020-05-05 20:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 20:53 [PATCH 00/14] Add Renoir ACP driver Alex Deucher
2020-05-05 20:53 ` [PATCH 01/14] ASoC: amd: add Renoir ACP3x IP register header Alex Deucher
2020-05-05 20:53 ` [PATCH 02/14] ASoC: amd: add Renoir ACP PCI driver Alex Deucher
2020-05-05 20:53 ` [PATCH 03/14] ASoC: amd: add acp init/de-init functions Alex Deucher
2020-05-05 20:53 ` [PATCH 04/14] ASoC: amd: create acp3x pdm platform device Alex Deucher
2020-05-05 20:53 ` [PATCH 05/14] ASoC: amd: add ACP3x PDM platform driver Alex Deucher
2020-05-05 22:03   ` Pierre-Louis Bossart
2020-05-06 17:20     ` Mukunda, Vijendar
2020-05-05 20:53 ` [PATCH 06/14] ASoC: amd: irq handler changes for ACP3x PDM dma driver Alex Deucher
2020-05-05 20:53 ` [PATCH 07/14] ASoC: amd: add acp3x pdm driver dma ops Alex Deucher
2020-05-05 21:59   ` Pierre-Louis Bossart
2020-05-06 17:30     ` Mukunda, Vijendar
2020-05-06 18:02       ` Pierre-Louis Bossart
2020-05-05 20:53 ` [PATCH 08/14] ASoC: amd: add ACP PDM DMA driver dai ops Alex Deucher
2020-05-05 21:55   ` Pierre-Louis Bossart
2020-05-06 17:12     ` Mukunda, Vijendar
2020-05-05 20:53 ` Alex Deucher [this message]
2020-05-05 21:48   ` [PATCH 09/14] ASoC: amd: add Renoir ACP PCI driver PM ops Pierre-Louis Bossart
2020-05-06 17:42     ` Mukunda, Vijendar
2020-05-06 17:58       ` Pierre-Louis Bossart
2020-05-05 20:53 ` [PATCH 10/14] ASoC: amd: add ACP PDM DMA driver pm ops Alex Deucher
2020-05-05 20:53 ` [PATCH 11/14] ASoC: amd: enable Renoir acp3x drivers build Alex Deucher
2020-05-05 20:53 ` [PATCH 12/14] ASoC: amd: create platform devices for Renoir Alex Deucher
2020-05-05 20:53 ` [PATCH 13/14] ASoC: amd: RN machine driver using dmic Alex Deucher
2020-05-05 21:37   ` Pierre-Louis Bossart
2020-05-06 16:01     ` Mukunda, Vijendar
2020-05-05 20:53 ` [PATCH 14/14] ASoC: amd: enable build for RN machine driver Alex Deucher
2020-05-05 21:39   ` Pierre-Louis Bossart
2020-05-06 15:54     ` Mukunda, Vijendar
2020-05-06 16:26     ` Mark Brown
2020-05-06 16:33       ` Mukunda, Vijendar
2020-05-06 16:43         ` Mark Brown
2020-05-06 17:17           ` Pierre-Louis Bossart
2020-05-06 17:25             ` Mark Brown
2020-05-06 17:27               ` Mukunda, Vijendar
2020-05-06 17:28                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505205327.642282-10-alexander.deucher@amd.com \
    --to=alexdeucher@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    --cc=vijendar.mukunda@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.