From: Andre Przywara <andre.przywara@arm.com> To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>, Marc Zyngier <maz@kernel.org> Subject: [PATCH v2 00/17] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Date: Thu, 7 May 2020 12:24:13 +0100 [thread overview] Message-ID: <20200507112430.183940-1-andre.przywara@arm.com> (raw) Just some small fixes in v2: changing the GIC binding instead of the compatible strings used for Juno, re-ordering the patches, and, most importantly, (hopefully) fixing the subject lines ;-) I keep the last two patches in, even though I agree that there should be a more generic solution. ----------------------------------- The .dts files in the arch/arm64/boot/dts/arm directory describe several boards and platforms provided by Arm Ltd. (mostly Juno and fastmodels). Both the .dts files and some of their associated .yaml bindings were not fully compliant, for some boards a simple dtc run complains already. And make dtbs_check would create quite a list of violations. This series attempts to fix all of them, although some are not yet covered, as they require some discussion about potential binding or DT schema changes. The first three patches fix some minor omissions in the yaml bindings. The rest of the series then address the violations that dtbs_check reported: many node name scheme mismatches, some missing properties or wrong child node handling. See the respective patches for more details. After applying this series I still see the following warnings: - vexpress-v2f-1xv7-ca53x2: leds: linux,default-trigger names not listed. The kernel provides triggers for each CPU core, which the DT tries to use. However cpu<x> is not listed in the binding, and I fail to add a regexp for a property *value* to express this easily. Alternatively we could drop any constraint on this string at all, since this might become a moving target and is not really a hardware property, rather than a convenience Linux configuration option. - juno: scp-sram: The compatible names for the SCPI child nodes are not fully converted to yaml yet, so dtbs_check fails to find a matching schema. Converting the SCPI bindings over is next on my list. - fvp-base-revc: panel: 'power-supply' is a required property Indeed the Linux driver depends on that property, not sure how this ever worked. I am about to test this, the fix should a rather easy addition of a fixed regulator. Please have a look, I am open to discussions. Cheers, Andre Changelog v1 .. v2: - drop GIC "compatible" changes for Juno - add "arm,gic-400", "arm,cortex-a15-gic" as a valid combination - reorder more controversial binding fixes to the end - add Robin's Acked-by: - fix subject lines in first three emails Andre Przywara (17): dt-bindings: arm-smmu: Allow mmu-400,smmu-v1 compatible dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings arm64: dts: arm: Fix node address fields arm64: dts: arm: FVP: Fix motherboard .dtsi arm64: dts: juno: Fix mem-timer arm64: dts: arm: Fix GIC compatible names arm64: dts: arm: Fix GIC child nodes arm64: dts: arm: Fix ITS node names and #msi-cells arm64: dts: juno: usb: Use proper DT node name arm64: dts: arm: Fix serial node names arm64: dts: fvp: Fix SMMU DT node arm64: dts: arm: Fix bus node names arm64: dts: juno: Fix GPU interrupt order arm64: dts: arm: Fix VExpress LED names arm64: dts: juno: Fix SCPI shared mem node name dt-bindings: mali-midgard: Allow dma-coherent dt-bindings: ehci/ohci: Allow iommus property .../bindings/gpu/arm,mali-midgard.yaml | 2 + .../interrupt-controller/arm,gic.yaml | 6 + .../devicetree/bindings/iommu/arm,smmu.yaml | 4 +- .../devicetree/bindings/usb/generic-ehci.yaml | 3 + .../devicetree/bindings/usb/generic-ohci.yaml | 3 + arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 38 ++--- .../boot/dts/arm/foundation-v8-gicv2.dtsi | 4 +- .../boot/dts/arm/foundation-v8-gicv3.dtsi | 3 +- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 12 +- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 10 +- arch/arm64/boot/dts/arm/juno-base.dtsi | 42 ++--- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 8 +- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- .../boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi | 4 +- .../boot/dts/arm/rtsm_ve-motherboard.dtsi | 152 +++++++++--------- 15 files changed, 155 insertions(+), 138 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier <maz@kernel.org> Subject: [PATCH v2 00/17] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Date: Thu, 7 May 2020 12:24:13 +0100 [thread overview] Message-ID: <20200507112430.183940-1-andre.przywara@arm.com> (raw) Just some small fixes in v2: changing the GIC binding instead of the compatible strings used for Juno, re-ordering the patches, and, most importantly, (hopefully) fixing the subject lines ;-) I keep the last two patches in, even though I agree that there should be a more generic solution. ----------------------------------- The .dts files in the arch/arm64/boot/dts/arm directory describe several boards and platforms provided by Arm Ltd. (mostly Juno and fastmodels). Both the .dts files and some of their associated .yaml bindings were not fully compliant, for some boards a simple dtc run complains already. And make dtbs_check would create quite a list of violations. This series attempts to fix all of them, although some are not yet covered, as they require some discussion about potential binding or DT schema changes. The first three patches fix some minor omissions in the yaml bindings. The rest of the series then address the violations that dtbs_check reported: many node name scheme mismatches, some missing properties or wrong child node handling. See the respective patches for more details. After applying this series I still see the following warnings: - vexpress-v2f-1xv7-ca53x2: leds: linux,default-trigger names not listed. The kernel provides triggers for each CPU core, which the DT tries to use. However cpu<x> is not listed in the binding, and I fail to add a regexp for a property *value* to express this easily. Alternatively we could drop any constraint on this string at all, since this might become a moving target and is not really a hardware property, rather than a convenience Linux configuration option. - juno: scp-sram: The compatible names for the SCPI child nodes are not fully converted to yaml yet, so dtbs_check fails to find a matching schema. Converting the SCPI bindings over is next on my list. - fvp-base-revc: panel: 'power-supply' is a required property Indeed the Linux driver depends on that property, not sure how this ever worked. I am about to test this, the fix should a rather easy addition of a fixed regulator. Please have a look, I am open to discussions. Cheers, Andre Changelog v1 .. v2: - drop GIC "compatible" changes for Juno - add "arm,gic-400", "arm,cortex-a15-gic" as a valid combination - reorder more controversial binding fixes to the end - add Robin's Acked-by: - fix subject lines in first three emails Andre Przywara (17): dt-bindings: arm-smmu: Allow mmu-400,smmu-v1 compatible dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings arm64: dts: arm: Fix node address fields arm64: dts: arm: FVP: Fix motherboard .dtsi arm64: dts: juno: Fix mem-timer arm64: dts: arm: Fix GIC compatible names arm64: dts: arm: Fix GIC child nodes arm64: dts: arm: Fix ITS node names and #msi-cells arm64: dts: juno: usb: Use proper DT node name arm64: dts: arm: Fix serial node names arm64: dts: fvp: Fix SMMU DT node arm64: dts: arm: Fix bus node names arm64: dts: juno: Fix GPU interrupt order arm64: dts: arm: Fix VExpress LED names arm64: dts: juno: Fix SCPI shared mem node name dt-bindings: mali-midgard: Allow dma-coherent dt-bindings: ehci/ohci: Allow iommus property .../bindings/gpu/arm,mali-midgard.yaml | 2 + .../interrupt-controller/arm,gic.yaml | 6 + .../devicetree/bindings/iommu/arm,smmu.yaml | 4 +- .../devicetree/bindings/usb/generic-ehci.yaml | 3 + .../devicetree/bindings/usb/generic-ohci.yaml | 3 + arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 38 ++--- .../boot/dts/arm/foundation-v8-gicv2.dtsi | 4 +- .../boot/dts/arm/foundation-v8-gicv3.dtsi | 3 +- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 12 +- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 10 +- arch/arm64/boot/dts/arm/juno-base.dtsi | 42 ++--- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 8 +- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- .../boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi | 4 +- .../boot/dts/arm/rtsm_ve-motherboard.dtsi | 152 +++++++++--------- 15 files changed, 155 insertions(+), 138 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-05-07 11:24 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-07 11:24 Andre Przywara [this message] 2020-05-07 11:24 ` [PATCH v2 00/17] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Andre Przywara 2020-05-07 11:24 ` [PATCH v2 01/17] dt-bindings: arm-smmu: Allow mmu-400,smmu-v1 compatible Andre Przywara 2020-05-07 11:24 ` [PATCH v2 01/17] dt-bindings: arm-smmu: Allow mmu-400, smmu-v1 compatible Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 02/17] dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings Andre Przywara 2020-05-07 11:24 ` [PATCH v2 02/17] dt-bindings: arm: gic: Allow combining arm, gic-400 " Andre Przywara 2020-05-07 11:24 ` [PATCH v2 03/17] arm64: dts: arm: Fix node address fields Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 04/17] arm64: dts: arm: FVP: Fix motherboard .dtsi Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 05/17] arm64: dts: juno: Fix mem-timer Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 06/17] arm64: dts: arm: Fix GIC compatible names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-11 8:56 ` Marc Zyngier 2020-05-11 8:56 ` Marc Zyngier 2020-05-07 11:24 ` [PATCH v2 07/17] arm64: dts: arm: Fix GIC child nodes Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-11 8:48 ` André Przywara 2020-05-11 8:48 ` André Przywara 2020-05-07 11:24 ` [PATCH v2 08/17] arm64: dts: arm: Fix ITS node names and #msi-cells Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 09/17] arm64: dts: juno: usb: Use proper DT node name Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 10/17] arm64: dts: arm: Fix serial node names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 11/17] arm64: dts: fvp: Fix SMMU DT node Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 12/17] arm64: dts: arm: Fix bus node names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 13/17] arm64: dts: juno: Fix GPU interrupt order Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 14/17] arm64: dts: arm: Fix VExpress LED names Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 15/17] arm64: dts: juno: Fix SCPI shared mem node name Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 16/17] dt-bindings: mali-midgard: Allow dma-coherent Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 11:24 ` [PATCH v2 17/17] dt-bindings: ehci/ohci: Allow iommus property Andre Przywara 2020-05-07 11:24 ` Andre Przywara 2020-05-07 14:04 ` [PATCH v2 00/17] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Will Deacon 2020-05-07 14:04 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200507112430.183940-1-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=robh@kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.