All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v6 10/16] floppy: move cmos_get_fd_drive_type() from pc
Date: Fri, 15 May 2020 17:04:15 +0200	[thread overview]
Message-ID: <20200515150421.25479-11-kraxel@redhat.com> (raw)
In-Reply-To: <20200515150421.25479-1-kraxel@redhat.com>

---
 include/hw/block/fdc.h |  1 +
 include/hw/i386/pc.h   |  1 -
 hw/block/fdc.c         | 26 +++++++++++++++++++++++++-
 hw/i386/pc.c           | 25 -------------------------
 4 files changed, 26 insertions(+), 27 deletions(-)

diff --git a/include/hw/block/fdc.h b/include/hw/block/fdc.h
index 5d71cf972268..479cebc0a330 100644
--- a/include/hw/block/fdc.h
+++ b/include/hw/block/fdc.h
@@ -16,5 +16,6 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
                        DriveInfo **fds, qemu_irq *fdc_tc);
 
 FloppyDriveType isa_fdc_get_drive_type(ISADevice *fdc, int i);
+int cmos_get_fd_drive_type(FloppyDriveType fd0);
 
 #endif
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 8d764f965cd3..5e3b19ab78fc 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -176,7 +176,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg);
 void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs);
 
 ISADevice *pc_find_fdc0(void);
-int cmos_get_fd_drive_type(FloppyDriveType fd0);
 
 /* port92.c */
 #define PORT92_A20_LINE "a20"
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index 8024c822cea3..ea0fb8ee15b9 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -32,7 +32,6 @@
 #include "qapi/error.h"
 #include "qemu/error-report.h"
 #include "qemu/timer.h"
-#include "hw/i386/pc.h"
 #include "hw/acpi/aml-build.h"
 #include "hw/irq.h"
 #include "hw/isa/isa.h"
@@ -2809,6 +2808,31 @@ static Aml *build_fdinfo_aml(int idx, FloppyDriveType type)
     return dev;
 }
 
+int cmos_get_fd_drive_type(FloppyDriveType fd0)
+{
+    int val;
+
+    switch (fd0) {
+    case FLOPPY_DRIVE_TYPE_144:
+        /* 1.44 Mb 3"5 drive */
+        val = 4;
+        break;
+    case FLOPPY_DRIVE_TYPE_288:
+        /* 2.88 Mb 3"5 drive */
+        val = 5;
+        break;
+    case FLOPPY_DRIVE_TYPE_120:
+        /* 1.2 Mb 5"5 drive */
+        val = 2;
+        break;
+    case FLOPPY_DRIVE_TYPE_NONE:
+    default:
+        val = 0;
+        break;
+    }
+    return val;
+}
+
 static void fdc_isa_build_aml(ISADevice *isadev, Aml *scope)
 {
     Aml *dev;
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 2128f3d6fe8b..c5db7be6d8b1 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -385,31 +385,6 @@ static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size)
 
 #define REG_EQUIPMENT_BYTE          0x14
 
-int cmos_get_fd_drive_type(FloppyDriveType fd0)
-{
-    int val;
-
-    switch (fd0) {
-    case FLOPPY_DRIVE_TYPE_144:
-        /* 1.44 Mb 3"5 drive */
-        val = 4;
-        break;
-    case FLOPPY_DRIVE_TYPE_288:
-        /* 2.88 Mb 3"5 drive */
-        val = 5;
-        break;
-    case FLOPPY_DRIVE_TYPE_120:
-        /* 1.2 Mb 5"5 drive */
-        val = 2;
-        break;
-    case FLOPPY_DRIVE_TYPE_NONE:
-    default:
-        val = 0;
-        break;
-    }
-    return val;
-}
-
 static void cmos_init_hd(ISADevice *s, int type_ofs, int info_ofs,
                          int16_t cylinders, int8_t heads, int8_t sectors)
 {
-- 
2.18.4



  parent reply	other threads:[~2020-05-15 15:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 15:04 [PATCH v6 00/16] acpi: i386 tweaks Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 01/16] qtest: allow DSDT acpi table changes Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 02/16] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 03/16] acpi: rtc: use a single crs range Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 04/16] acpi: serial: don't use _STA method Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 05/16] acpi: move aml builder code for serial device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 06/16] acpi: parallel: don't use _STA method Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 07/16] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 08/16] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-06-09 14:28   ` Michael S. Tsirkin
2020-05-15 15:04 ` [PATCH v6 09/16] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-05-15 15:04 ` Gerd Hoffmann [this message]
2020-05-19 14:51   ` [PATCH v6 10/16] floppy: move cmos_get_fd_drive_type() from pc Philippe Mathieu-Daudé
2020-05-19 23:09     ` John Snow
2020-05-20  8:43     ` Gerd Hoffmann
2020-05-20 10:29       ` Michael S. Tsirkin
2020-05-15 15:04 ` [PATCH v6 11/16] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 12/16] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 13/16] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 14/16] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 15/16] acpi: drop build_piix4_pm() Gerd Hoffmann
2020-05-20 10:20   ` Igor Mammedow
2020-05-15 15:04 ` [PATCH v6 16/16] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Gerd Hoffmann
2020-05-16  0:23 ` [PATCH v6 00/16] acpi: i386 tweaks no-reply
2020-05-16  8:29 ` no-reply
2020-05-16 12:51 ` no-reply
2020-06-08 13:22 ` Gerd Hoffmann
2020-06-08 13:24   ` Michael S. Tsirkin
2020-06-09 14:29 ` Michael S. Tsirkin
2020-06-10  9:40   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515150421.25479-11-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.