All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Lee Jones <lee.jones@linaro.org>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Samuel Ortiz <samuel.ortiz@nokia.com>,
	linux-omap@vger.kernel.org
Subject: [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'
Date: Tue,  7 Jul 2020 11:16:35 +0100	[thread overview]
Message-ID: <20200707101642.1747944-22-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org>

Looks like 'w' has remained unchecked since the driver's inception.

Fixes the following W=1 kernel build warning(s):

 sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
 sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ti/omap-mcbsp-st.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
index 5a32b54bbf3bb..643ef7eb68fc8 100644
--- a/sound/soc/ti/omap-mcbsp-st.c
+++ b/sound/soc/ti/omap-mcbsp-st.c
@@ -142,10 +142,9 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
 
 static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
 {
-	u16 w;
 	struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
 
-	w = MCBSP_ST_READ(mcbsp, SSELCR);
+	MCBSP_ST_READ(mcbsp, SSELCR);
 
 	MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
 		       ST_CH1GAIN(st_data->ch1gain));
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org,
	Samuel Ortiz <samuel.ortiz@nokia.com>,
	linux-kernel@vger.kernel.org,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'
Date: Tue,  7 Jul 2020 11:16:35 +0100	[thread overview]
Message-ID: <20200707101642.1747944-22-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org>

Looks like 'w' has remained unchecked since the driver's inception.

Fixes the following W=1 kernel build warning(s):

 sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
 sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ti/omap-mcbsp-st.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
index 5a32b54bbf3bb..643ef7eb68fc8 100644
--- a/sound/soc/ti/omap-mcbsp-st.c
+++ b/sound/soc/ti/omap-mcbsp-st.c
@@ -142,10 +142,9 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
 
 static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
 {
-	u16 w;
 	struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
 
-	w = MCBSP_ST_READ(mcbsp, SSELCR);
+	MCBSP_ST_READ(mcbsp, SSELCR);
 
 	MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
 		       ST_CH1GAIN(st_data->ch1gain));
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org,
	Samuel Ortiz <samuel.ortiz@nokia.com>,
	linux-kernel@vger.kernel.org,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'
Date: Tue,  7 Jul 2020 11:16:35 +0100	[thread overview]
Message-ID: <20200707101642.1747944-22-lee.jones@linaro.org> (raw)
In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org>

Looks like 'w' has remained unchecked since the driver's inception.

Fixes the following W=1 kernel build warning(s):

 sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
 sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ti/omap-mcbsp-st.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
index 5a32b54bbf3bb..643ef7eb68fc8 100644
--- a/sound/soc/ti/omap-mcbsp-st.c
+++ b/sound/soc/ti/omap-mcbsp-st.c
@@ -142,10 +142,9 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
 
 static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
 {
-	u16 w;
 	struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
 
-	w = MCBSP_ST_READ(mcbsp, SSELCR);
+	MCBSP_ST_READ(mcbsp, SSELCR);
 
 	MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
 		       ST_CH1GAIN(st_data->ch1gain));
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-07 10:18 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 10:16 [PATCH 00/28] Clean-up ASoC's W=1 build warnings Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` Lee Jones
2020-07-07 10:16 ` [PATCH 01/28] ASoC: atmel: atmel-pcm-dma: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 02/28] ASoC: atmel: atmel_ssc_dai: " Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 03/28] ASoC: fsl: fsl-asoc-card: Use correct format when providing struct documentation Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 04/28] ASoC: fsl: fsl_asrc: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 05/28] ASoC: fsl: fsl_ssi: " Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 06/28] ASoC: fsl: fsl_ssi_dbg: " Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 07/28] ASoC: fsl: fsl_spdif: Use correct formatting when denoting struct documentation Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 08/28] ASoC: fsl: fsl_spdif: Update 'struct fsl_spdif_priv's descriptions Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 09/28] ASoC: fsl: fsl_esai: Fix a bunch of kerneldoc issues Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 10/28] ASoC: fsl: fsl_esai: Add descriptions for 'tx_mask' and 'rx_mask' to 'fsl_esai' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 11/28] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 12/28] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 13/28] ASoC: qcom: qdsp6: q6asm: Provide documentation for WMA 'codec_profile' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 15:35   ` Vinod Koul
2020-07-07 15:35     ` Vinod Koul
2020-07-07 15:35     ` Vinod Koul
2020-07-07 10:16 ` [PATCH 14/28] ASoC: samsung: pcm: Demote half-documented kerneldoc header Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 15/28] ASoC: samsung: spdif: Fix 3 misspelled struct properties Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 16/28] ASoC: sunxi: sun4i-i2s: Demote half-documented kerneldoc header Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 17/28] ASoC: uniphier: aio-core: Fix incorrectly named struct property and remove another Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:59   ` Masahiro Yamada
2020-07-07 10:59     ` Masahiro Yamada
2020-07-07 10:59     ` Masahiro Yamada
2020-07-07 10:16 ` [PATCH 18/28] ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` Lee Jones [this message]
2020-07-07 10:16   ` [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:48   ` Peter Ujfalusi
2020-07-07 10:48     ` Peter Ujfalusi
2020-07-07 10:48     ` Peter Ujfalusi
2020-07-07 10:16 ` [PATCH 22/28] ASoC: codecs: da7210: Fix formatting issues in da7210_set_dai_pll() header Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 23/28] ASoC: soc-ac97: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 24/28] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv' Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:40   ` Paul Cercueil
2020-07-07 10:40     ` Paul Cercueil
2020-07-07 10:40     ` Paul Cercueil
2020-07-07 10:16 ` [PATCH 25/28] ASoC: codecs: rt5631: Demote misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 26/28] ASoC: codecs: rt5659: Remove many unused const variables Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 27/28] ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16 ` [PATCH 28/28] ASoC: codecs: wm8400: Remove a bunch of unused variables Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:16   ` Lee Jones
2020-07-07 10:19 ` [PATCH 00/28] Clean-up ASoC's W=1 build warnings Mark Brown
2020-07-07 10:19   ` Mark Brown
2020-07-07 10:19   ` Mark Brown
2020-07-07 10:37   ` Lee Jones
2020-07-07 10:37     ` Lee Jones
2020-07-07 10:37     ` Lee Jones
2020-07-07 10:40     ` Mark Brown
2020-07-07 10:40       ` Mark Brown
2020-07-07 10:40       ` Mark Brown
2020-07-07 15:44       ` Pierre-Louis Bossart
2020-07-07 15:44         ` Pierre-Louis Bossart
2020-07-07 15:44         ` Pierre-Louis Bossart
2020-07-07 19:04         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707101642.1747944-22-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@ti.com \
    --cc=samuel.ortiz@nokia.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.