All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
	"Eddie James" <eajames@linux.ibm.com>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>,
	"Joel Stanley" <joel@jms.id.au>
Subject: [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence
Date: Thu, 6 Aug 2020 15:20:55 +0200	[thread overview]
Message-ID: <20200806132106.747414-9-clg@kaod.org> (raw)
In-Reply-To: <20200806132106.747414-1-clg@kaod.org>

BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until
the bit is cleared by HW. Add definitions for the default value of
this register and fix the reset sequence by clearing the RESET bit.

Cc: Eddie James <eajames@linux.ibm.com>
Fixes: 2bea128c3d0b ("hw/sd/aspeed_sdhci: New device")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/sd/aspeed_sdhci.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/hw/sd/aspeed_sdhci.c b/hw/sd/aspeed_sdhci.c
index 22cafce0fbdc..c51cda932463 100644
--- a/hw/sd/aspeed_sdhci.c
+++ b/hw/sd/aspeed_sdhci.c
@@ -16,7 +16,9 @@
 #include "hw/qdev-properties.h"
 
 #define ASPEED_SDHCI_INFO            0x00
-#define  ASPEED_SDHCI_INFO_RESET     0x00030000
+#define  ASPEED_SDHCI_INFO_SLOT1     (1 << 17)
+#define  ASPEED_SDHCI_INFO_SLOT0     (1 << 16)
+#define  ASPEED_SDHCI_INFO_RESET     (1 << 0)
 #define ASPEED_SDHCI_DEBOUNCE        0x04
 #define  ASPEED_SDHCI_DEBOUNCE_RESET 0x00000005
 #define ASPEED_SDHCI_BUS             0x08
@@ -67,6 +69,9 @@ static void aspeed_sdhci_write(void *opaque, hwaddr addr, uint64_t val,
     AspeedSDHCIState *sdhci = opaque;
 
     switch (addr) {
+    case ASPEED_SDHCI_INFO:
+        sdhci->regs[TO_REG(addr)] = (uint32_t)val & ~ASPEED_SDHCI_INFO_RESET;
+
     case ASPEED_SDHCI_SDIO_140:
         sdhci->slots[0].capareg = (uint64_t)(uint32_t)val;
         break;
@@ -155,7 +160,8 @@ static void aspeed_sdhci_reset(DeviceState *dev)
     AspeedSDHCIState *sdhci = ASPEED_SDHCI(dev);
 
     memset(sdhci->regs, 0, ASPEED_SDHCI_REG_SIZE);
-    sdhci->regs[TO_REG(ASPEED_SDHCI_INFO)] = ASPEED_SDHCI_INFO_RESET;
+    sdhci->regs[TO_REG(ASPEED_SDHCI_INFO)] =
+        ASPEED_SDHCI_INFO_SLOT1 | ASPEED_SDHCI_INFO_SLOT0;
     sdhci->regs[TO_REG(ASPEED_SDHCI_DEBOUNCE)] = ASPEED_SDHCI_DEBOUNCE_RESET;
 }
 
-- 
2.25.4



  parent reply	other threads:[~2020-08-06 13:28 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 13:20 [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 01/19] m25p80: Return the JEDEC ID twice for mx25l25635e Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f Cédric Le Goater
2020-08-06 22:55   ` Joel Stanley
2020-08-07  5:59     ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 03/19] m25p80: Add support for n25q512ax3 Cédric Le Goater
2020-08-06 22:56   ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400 Cédric Le Goater
2020-08-06 13:32   ` Philippe Mathieu-Daudé
2020-08-06 13:49     ` Cédric Le Goater
2020-08-06 14:08       ` Philippe Mathieu-Daudé
2020-08-06 22:57   ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 05/19] hw/arm/aspeed: Add board model for Supermicro X11 BMC Cédric Le Goater
2020-08-06 23:23   ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 06/19] aspeed/smc: Fix MemoryRegionOps definition Cédric Le Goater
2020-08-06 23:24   ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 07/19] aspeed/smc: Fix max_slaves of the legacy SMC device Cédric Le Goater
2020-08-06 23:24   ` Joel Stanley
2020-08-06 13:20 ` Cédric Le Goater [this message]
2020-08-06 23:42   ` [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence Joel Stanley
2020-08-07  6:04     ` Cédric Le Goater
2020-08-10 17:16     ` Cédric Le Goater
2020-08-10 23:20       ` Joel Stanley
2020-08-11  7:05         ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 09/19] ftgmac100: Fix registers that can be read Cédric Le Goater
2020-08-06 13:33   ` Philippe Mathieu-Daudé
2020-08-06 23:44   ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 10/19] ftgmac100: Fix interrupt status "Packet transmitted on ethernet" Cédric Le Goater
2020-08-06 23:47   ` Joel Stanley
2020-08-07  6:06     ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 11/19] ftgmac100: Fix interrupt status "Packet moved to RX FIFO" Cédric Le Goater
2020-08-06 23:48   ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 12/19] ftgmac100: Change interrupt status when a DMA error occurs Cédric Le Goater
2020-08-06 23:51   ` Joel Stanley
2020-08-07  6:19     ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 13/19] ftgmac100: Check for invalid len and address before doing a DMA transfer Cédric Le Goater
2020-08-06 23:51   ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx() Cédric Le Goater
2020-08-06 23:57   ` Joel Stanley
2020-08-10 13:43   ` Mauro Matteo Cascella
2020-08-10 17:14     ` Cédric Le Goater
2020-08-11 12:20       ` Mauro Matteo Cascella
2020-08-11 12:39   ` Peter Maydell
2020-08-18 14:54     ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 15/19] ftgmac100: Improve software reset Cédric Le Goater
2020-08-06 13:40   ` Philippe Mathieu-Daudé
2020-08-07  0:03   ` Joel Stanley
2020-08-07  6:21     ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 16/19] aspeed/sdmc: Perform memory training Cédric Le Goater
2020-08-06 13:38   ` Philippe Mathieu-Daudé
2020-08-07  0:10     ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 17/19] aspeed/sdmc: Allow writes to unprotected registers Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 18/19] aspeed/sdmc: Simplify calculation of RAM bits Cédric Le Goater
2020-08-07  0:11   ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 19/19] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller Cédric Le Goater
2020-08-07  0:12   ` Joel Stanley
2020-08-06 13:24 ` [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions Cédric Le Goater
2020-08-07  9:14   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200806132106.747414-9-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.