From: Alex Dewar <alex.dewar90@gmail.com>
To: alex.dewar90@gmail.com
Cc: dennis.dalessandro@intel.com, dledford@redhat.com,
gustavo@embeddedor.com, jgg@ziepe.ca, joe@perches.com,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
mike.marciniszyn@intel.com, roland@purestorage.com
Subject: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements
Date: Tue, 25 Aug 2020 18:12:42 +0100 [thread overview]
Message-ID: <20200825171242.448447-1-alex.dewar90@gmail.com> (raw)
In-Reply-To: <64d7e1c9-9c6a-93f3-ce0a-c24b1c236071@gmail.com>
Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
erroneously marked a couple of switch cases as /* FALLTHROUGH */, which
were later converted to fallthrough statements by commit df561f6688fe
("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity
warning about unreachable code.
Remove the fallthrough statements.
Addresses-Coverity: ("Unreachable code")
Fixes: 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
v2: Do refactoring in a separate patch (Gustavo)
---
drivers/infiniband/hw/qib/qib_mad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index e7789e724f56..f972e559a8a7 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -2322,7 +2322,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
ret = cc_get_congestion_control_table(ccp, ibdev, port);
goto bail;
- fallthrough;
default:
ccp->status |= IB_SMP_UNSUP_METH_ATTR;
ret = reply((struct ib_smp *) ccp);
@@ -2339,7 +2338,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
ret = cc_set_congestion_control_table(ccp, ibdev, port);
goto bail;
- fallthrough;
default:
ccp->status |= IB_SMP_UNSUP_METH_ATTR;
ret = reply((struct ib_smp *) ccp);
--
2.28.0
next prev parent reply other threads:[~2020-08-25 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:51 [PATCH] IB/qib: remove superfluous fallthrough statements Alex Dewar
2020-08-25 16:19 ` Gustavo A. R. Silva
2020-08-25 16:26 ` Joe Perches
2020-08-25 16:49 ` Gustavo A. R. Silva
2020-08-25 16:47 ` Joe Perches
2020-08-25 17:01 ` Gustavo A. R. Silva
2020-08-25 20:55 ` Joe Perches
2020-08-25 16:58 ` Alex Dewar
2020-08-25 17:12 ` Alex Dewar [this message]
2020-08-25 19:33 ` [PATCH v2 1/2] " Gustavo A. R. Silva
2020-08-26 19:18 ` Gustavo A. R. Silva
2020-08-27 0:11 ` Jason Gunthorpe
2020-08-27 1:41 ` Gustavo A. R. Silva
2020-08-27 10:40 ` Alex Dewar
2020-08-31 16:25 ` Jason Gunthorpe
2020-08-25 17:12 ` [PATCH v2 2/2] IB/qib: tidy up process_cc() Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825171242.448447-1-alex.dewar90@gmail.com \
--to=alex.dewar90@gmail.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=gustavo@embeddedor.com \
--cc=jgg@ziepe.ca \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.