All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"Alexey Brodkin" <abrodkin@synopsys.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-snps-arc <linux-snps-arc@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Haoyu Lv <lvhaoyu@huawei.com>, Libin <huawei.libin@huawei.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v6 1/6] genirq: define an empty function set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER
Date: Thu, 24 Sep 2020 15:17:49 +0800	[thread overview]
Message-ID: <20200924071754.4509-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20200924071754.4509-1-thunder.leizhen@huawei.com>

To avoid compilation error if an irqchip driver references the function
set_handle_irq() but may not select GENERIC_IRQ_MULTI_HANDLER on some
systems.

For example, the Synopsys DesignWare APB interrupt controller
(dw_apb_ictl) is used as the secondary interrupt controller on arc, csky,
arm64, and most arm32 SoCs, and it's also used as the primary interrupt
controller on Hisilicon SD5203 (an arm32 SoC). The latter need to use
set_handle_irq() to register the top-level IRQ handler, but this multi
irq handler registration mechanism is not implemented on arc system.

The input parameter "handle_irq" maybe defined as static and only
set_handle_irq() references it. This will trigger "defined but not used"
warning. So add "(void)handle_irq" to suppress it.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 include/linux/irq.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 1b7f4dfee35b397..b167baef88c0b43 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -1252,6 +1252,12 @@ void irq_matrix_free(struct irq_matrix *m, unsigned int cpu,
  * top-level IRQ handler.
  */
 extern void (*handle_arch_irq)(struct pt_regs *) __ro_after_init;
+#else
+#define set_handle_irq(handle_irq)		\
+	do {					\
+		(void)handle_irq;		\
+		WARN_ON(1);			\
+	} while (0)
 #endif
 
 #endif /* _LINUX_IRQ_H */
-- 
1.8.3



WARNING: multiple messages have this Message-ID (diff)
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	 Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"Alexey Brodkin" <abrodkin@synopsys.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-snps-arc <linux-snps-arc@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Haoyu Lv <lvhaoyu@huawei.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Libin <huawei.libin@huawei.com>,
	Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v6 1/6] genirq: define an empty function set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER
Date: Thu, 24 Sep 2020 15:17:49 +0800	[thread overview]
Message-ID: <20200924071754.4509-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20200924071754.4509-1-thunder.leizhen@huawei.com>

To avoid compilation error if an irqchip driver references the function
set_handle_irq() but may not select GENERIC_IRQ_MULTI_HANDLER on some
systems.

For example, the Synopsys DesignWare APB interrupt controller
(dw_apb_ictl) is used as the secondary interrupt controller on arc, csky,
arm64, and most arm32 SoCs, and it's also used as the primary interrupt
controller on Hisilicon SD5203 (an arm32 SoC). The latter need to use
set_handle_irq() to register the top-level IRQ handler, but this multi
irq handler registration mechanism is not implemented on arc system.

The input parameter "handle_irq" maybe defined as static and only
set_handle_irq() references it. This will trigger "defined but not used"
warning. So add "(void)handle_irq" to suppress it.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 include/linux/irq.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 1b7f4dfee35b397..b167baef88c0b43 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -1252,6 +1252,12 @@ void irq_matrix_free(struct irq_matrix *m, unsigned int cpu,
  * top-level IRQ handler.
  */
 extern void (*handle_arch_irq)(struct pt_regs *) __ro_after_init;
+#else
+#define set_handle_irq(handle_irq)		\
+	do {					\
+		(void)handle_irq;		\
+		WARN_ON(1);			\
+	} while (0)
 #endif
 
 #endif /* _LINUX_IRQ_H */
-- 
1.8.3



_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

  reply	other threads:[~2020-09-24  7:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24  7:17 [PATCH v6 0/6] irqchip: dw-apb-ictl: support hierarchy irq domain Zhen Lei
2020-09-24  7:17 ` Zhen Lei
2020-09-24  7:17 ` Zhen Lei [this message]
2020-09-24  7:17   ` [PATCH v6 1/6] genirq: define an empty function set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER Zhen Lei
2020-10-11 17:57   ` [tip: irq/core] genirq: Add stub for set_handle_irq() when !GENERIC_IRQ_MULTI_HANDLER tip-bot2 for Zhen Lei
2020-09-24  7:17 ` [PATCH v6 2/6] irqchip: dw-apb-ictl: prepare for support hierarchy irq domain Zhen Lei
2020-09-24  7:17   ` Zhen Lei
2020-10-11 17:57   ` [tip: irq/core] irqchip/dw-apb-ictl: Refactor priot to introducing hierarchical irq domains tip-bot2 for Zhen Lei
2020-09-24  7:17 ` [PATCH v6 3/6] irqchip: dw-apb-ictl: support hierarchy irq domain Zhen Lei
2020-09-24  7:17   ` Zhen Lei
2020-10-11 17:57   ` [tip: irq/core] irqchip/dw-apb-ictl: Add primary interrupt controller support tip-bot2 for Zhen Lei
2020-09-24  7:17 ` [PATCH v6 4/6] dt-bindings: dw-apb-ictl: support hierarchy irq domain Zhen Lei
2020-09-24  7:17   ` Zhen Lei
2020-10-11 17:57   ` [tip: irq/core] dt-bindings: dw-apb-ictl: Update binding to describe use as primary interrupt controller tip-bot2 for Zhen Lei
2020-09-24  7:17 ` [PATCH v6 5/6] dt-bindings: dw-apb-ictl: convert to json-schema Zhen Lei
2020-09-24  7:17   ` Zhen Lei
2020-09-27  9:53   ` Leizhen (ThunderTown)
2020-09-27  9:53     ` Leizhen (ThunderTown)
2020-09-28 18:26   ` Rob Herring
2020-09-28 18:26     ` Rob Herring
2020-09-29  1:37     ` Leizhen (ThunderTown)
2020-09-29  1:37       ` Leizhen (ThunderTown)
2020-09-24  7:17 ` [PATCH v6 6/6] ARC: [dts] fix the errors detected by dtbs_check Zhen Lei
2020-09-24  7:17   ` Zhen Lei
2020-09-28 18:32   ` Vineet Gupta
2020-09-28 18:32     ` Vineet Gupta
2020-09-25 15:54 ` [PATCH v6 0/6] irqchip: dw-apb-ictl: support hierarchy irq domain Marc Zyngier
2020-09-25 15:54   ` Marc Zyngier
2020-09-27  6:49   ` Leizhen (ThunderTown)
2020-09-27  6:49     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924071754.4509-2-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=abrodkin@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=huawei.libin@huawei.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=lvhaoyu@huawei.com \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=vgupta@synopsys.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.