All of lore.kernel.org
 help / color / mirror / Atom feed
From: Crystal Guo <crystal.guo@mediatek.com>
To: <p.zabel@pengutronix.de>, <robh+dt@kernel.org>, <matthias.bgg@gmail.com>
Cc: <srv_heupstream@mediatek.com>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<s-anna@ti.com>, <seiya.wang@mediatek.com>,
	<stanley.chu@mediatek.com>, <yingjoe.chen@mediatek.com>,
	<fan.chen@mediatek.com>, <yong.liang@mediatek.com>,
	Crystal Guo <crystal.guo@mediatek.com>
Subject: [v6,3/3] reset-controller: ti: force the write operation when assert or deassert
Date: Wed, 30 Sep 2020 10:21:59 +0800	[thread overview]
Message-ID: <20200930022159.5559-4-crystal.guo@mediatek.com> (raw)
In-Reply-To: <20200930022159.5559-1-crystal.guo@mediatek.com>

Force the write operation in case the read already happens
to return the correct value.

Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
---
 drivers/reset/reset-ti-syscon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index 5d1f8306cd4f..c34394f1e9e2 100644
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -97,7 +97,7 @@ static int ti_syscon_reset_assert(struct reset_controller_dev *rcdev,
 	mask = BIT(control->assert_bit);
 	value = (control->flags & ASSERT_SET) ? mask : 0x0;
 
-	return regmap_update_bits(data->regmap, control->assert_offset, mask, value);
+	return regmap_write_bits(data->regmap, control->assert_offset, mask, value);
 }
 
 /**
@@ -128,7 +128,7 @@ static int ti_syscon_reset_deassert(struct reset_controller_dev *rcdev,
 	mask = BIT(control->deassert_bit);
 	value = (control->flags & DEASSERT_SET) ? mask : 0x0;
 
-	return regmap_update_bits(data->regmap, control->deassert_offset, mask, value);
+	return regmap_write_bits(data->regmap, control->deassert_offset, mask, value);
 }
 
 /**
-- 
2.18.0

WARNING: multiple messages have this Message-ID (diff)
From: Crystal Guo <crystal.guo@mediatek.com>
To: <p.zabel@pengutronix.de>, <robh+dt@kernel.org>, <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, yong.liang@mediatek.com,
	stanley.chu@mediatek.com, srv_heupstream@mediatek.com,
	seiya.wang@mediatek.com, linux-kernel@vger.kernel.org,
	fan.chen@mediatek.com, Crystal Guo <crystal.guo@mediatek.com>,
	linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com,
	s-anna@ti.com, linux-arm-kernel@lists.infradead.org
Subject: [v6, 3/3] reset-controller: ti: force the write operation when assert or deassert
Date: Wed, 30 Sep 2020 10:21:59 +0800	[thread overview]
Message-ID: <20200930022159.5559-4-crystal.guo@mediatek.com> (raw)
In-Reply-To: <20200930022159.5559-1-crystal.guo@mediatek.com>

Force the write operation in case the read already happens
to return the correct value.

Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
---
 drivers/reset/reset-ti-syscon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index 5d1f8306cd4f..c34394f1e9e2 100644
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -97,7 +97,7 @@ static int ti_syscon_reset_assert(struct reset_controller_dev *rcdev,
 	mask = BIT(control->assert_bit);
 	value = (control->flags & ASSERT_SET) ? mask : 0x0;
 
-	return regmap_update_bits(data->regmap, control->assert_offset, mask, value);
+	return regmap_write_bits(data->regmap, control->assert_offset, mask, value);
 }
 
 /**
@@ -128,7 +128,7 @@ static int ti_syscon_reset_deassert(struct reset_controller_dev *rcdev,
 	mask = BIT(control->deassert_bit);
 	value = (control->flags & DEASSERT_SET) ? mask : 0x0;
 
-	return regmap_update_bits(data->regmap, control->deassert_offset, mask, value);
+	return regmap_write_bits(data->regmap, control->deassert_offset, mask, value);
 }
 
 /**
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Crystal Guo <crystal.guo@mediatek.com>
To: <p.zabel@pengutronix.de>, <robh+dt@kernel.org>, <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, yong.liang@mediatek.com,
	stanley.chu@mediatek.com, srv_heupstream@mediatek.com,
	seiya.wang@mediatek.com, linux-kernel@vger.kernel.org,
	fan.chen@mediatek.com, Crystal Guo <crystal.guo@mediatek.com>,
	linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com,
	linux-arm-kernel@lists.infradead.org
Subject: [v6, 3/3] reset-controller: ti: force the write operation when assert or deassert
Date: Wed, 30 Sep 2020 10:21:59 +0800	[thread overview]
Message-ID: <20200930022159.5559-4-crystal.guo@mediatek.com> (raw)
In-Reply-To: <20200930022159.5559-1-crystal.guo@mediatek.com>

Force the write operation in case the read already happens
to return the correct value.

Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
---
 drivers/reset/reset-ti-syscon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index 5d1f8306cd4f..c34394f1e9e2 100644
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -97,7 +97,7 @@ static int ti_syscon_reset_assert(struct reset_controller_dev *rcdev,
 	mask = BIT(control->assert_bit);
 	value = (control->flags & ASSERT_SET) ? mask : 0x0;
 
-	return regmap_update_bits(data->regmap, control->assert_offset, mask, value);
+	return regmap_write_bits(data->regmap, control->assert_offset, mask, value);
 }
 
 /**
@@ -128,7 +128,7 @@ static int ti_syscon_reset_deassert(struct reset_controller_dev *rcdev,
 	mask = BIT(control->deassert_bit);
 	value = (control->flags & DEASSERT_SET) ? mask : 0x0;
 
-	return regmap_update_bits(data->regmap, control->deassert_offset, mask, value);
+	return regmap_write_bits(data->regmap, control->deassert_offset, mask, value);
 }
 
 /**
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-09-30  2:22 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  2:21 [v6,0/3] introduce TI reset controller for MT8192 SoC Crystal Guo
2020-09-30  2:21 ` Crystal Guo
2020-09-30  2:21 ` Crystal Guo
2020-09-30  2:21 ` [v6,1/3] dt-binding: reset-controller: mediatek: add YAML schemas Crystal Guo
2020-09-30  2:21   ` Crystal Guo
2020-09-30  2:21   ` Crystal Guo
2020-10-14 13:30   ` Crystal Guo
2020-10-14 13:30     ` Crystal Guo
2020-10-14 13:30     ` Crystal Guo
2020-11-11  8:28     ` Stanley Chu
2020-11-11  8:28       ` Stanley Chu
2020-11-11  8:28       ` Stanley Chu
2020-12-03  7:41   ` Philipp Zabel
2020-12-03  7:41     ` Philipp Zabel
2020-12-03  7:41     ` Philipp Zabel
2020-12-26  9:06     ` Crystal Guo
2020-12-26  9:06       ` Crystal Guo
2020-12-26  9:06       ` Crystal Guo
2020-09-30  2:21 ` [v6,2/3] reset-controller: ti: introduce a new reset handler Crystal Guo
2020-09-30  2:21   ` Crystal Guo
2020-09-30  2:21   ` Crystal Guo
2020-11-30 10:35   ` Ikjoon Jang
2020-11-30 10:35     ` Ikjoon Jang
2020-11-30 10:35     ` Ikjoon Jang
2020-12-04  2:34     ` Crystal Guo
2020-12-04  2:34       ` Crystal Guo
2020-12-04  2:34       ` Crystal Guo
2020-09-30  2:21 ` Crystal Guo [this message]
2020-09-30  2:21   ` [v6, 3/3] reset-controller: ti: force the write operation when assert or deassert Crystal Guo
2020-09-30  2:21   ` Crystal Guo
2020-11-30 11:13   ` Ikjoon Jang
2020-11-30 11:13     ` Ikjoon Jang
2020-11-30 11:13     ` Ikjoon Jang
2020-12-02 11:06     ` Crystal Guo
2020-12-02 11:06       ` Crystal Guo
2020-12-02 11:06       ` Crystal Guo
2020-12-03  3:30       ` Ikjoon Jang
2020-12-03  3:30         ` Ikjoon Jang
2020-12-03  3:30         ` Ikjoon Jang
2020-12-03  7:45   ` [v6,3/3] " Philipp Zabel
2020-12-03  7:45     ` Philipp Zabel
2020-12-03  7:45     ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930022159.5559-4-crystal.guo@mediatek.com \
    --to=crystal.guo@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fan.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    --cc=seiya.wang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=stanley.chu@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    --cc=yong.liang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.