From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: <vkoul@kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>, <robh+dt@kernel.org>, <vigneshr@ti.com> Cc: <dan.j.williams@intel.com>, <t-kristo@ti.com>, <lokeshvutla@ti.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <dmaengine@vger.kernel.org> Subject: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback Date: Wed, 30 Sep 2020 12:13:55 +0300 [thread overview] Message-ID: <20200930091412.8020-2-peter.ujfalusi@ti.com> (raw) In-Reply-To: <20200930091412.8020-1-peter.ujfalusi@ti.com> Additional configuration for the DMA event router might be needed for a channel which can not be done during device_alloc_chan_resources callback since the router information is not yet present for the drivers. If there is a need for additional configuration for the channel if DMA router is in use, then the driver can implement the device_router_config callback. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- drivers/dma/of-dma.c | 10 ++++++++++ include/linux/dmaengine.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index 8a4f608904b9..ec00b20ae8e4 100644 --- a/drivers/dma/of-dma.c +++ b/drivers/dma/of-dma.c @@ -75,8 +75,18 @@ static struct dma_chan *of_dma_router_xlate(struct of_phandle_args *dma_spec, ofdma->dma_router->route_free(ofdma->dma_router->dev, route_data); } else { + int ret = 0; + chan->router = ofdma->dma_router; chan->route_data = route_data; + + if (chan->device->device_router_config) + ret = chan->device->device_router_config(chan); + + if (ret) { + dma_release_channel(chan); + chan = ERR_PTR(ret); + } } /* diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index dd357a747780..d6197fe875af 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -800,6 +800,7 @@ struct dma_filter { * by tx_status * @device_alloc_chan_resources: allocate resources and return the * number of allocated descriptors + * @device_router_config: optional callback for DMA router configuration * @device_free_chan_resources: release DMA channel's resources * @device_prep_dma_memcpy: prepares a memcpy operation * @device_prep_dma_xor: prepares a xor operation @@ -874,6 +875,7 @@ struct dma_device { enum dma_residue_granularity residue_granularity; int (*device_alloc_chan_resources)(struct dma_chan *chan); + int (*device_router_config)(struct dma_chan *chan); void (*device_free_chan_resources)(struct dma_chan *chan); struct dma_async_tx_descriptor *(*device_prep_dma_memcpy)( -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: <vkoul@kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>, <robh+dt@kernel.org>, <vigneshr@ti.com> Cc: devicetree@vger.kernel.org, lokeshvutla@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback Date: Wed, 30 Sep 2020 12:13:55 +0300 [thread overview] Message-ID: <20200930091412.8020-2-peter.ujfalusi@ti.com> (raw) In-Reply-To: <20200930091412.8020-1-peter.ujfalusi@ti.com> Additional configuration for the DMA event router might be needed for a channel which can not be done during device_alloc_chan_resources callback since the router information is not yet present for the drivers. If there is a need for additional configuration for the channel if DMA router is in use, then the driver can implement the device_router_config callback. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- drivers/dma/of-dma.c | 10 ++++++++++ include/linux/dmaengine.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index 8a4f608904b9..ec00b20ae8e4 100644 --- a/drivers/dma/of-dma.c +++ b/drivers/dma/of-dma.c @@ -75,8 +75,18 @@ static struct dma_chan *of_dma_router_xlate(struct of_phandle_args *dma_spec, ofdma->dma_router->route_free(ofdma->dma_router->dev, route_data); } else { + int ret = 0; + chan->router = ofdma->dma_router; chan->route_data = route_data; + + if (chan->device->device_router_config) + ret = chan->device->device_router_config(chan); + + if (ret) { + dma_release_channel(chan); + chan = ERR_PTR(ret); + } } /* diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index dd357a747780..d6197fe875af 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -800,6 +800,7 @@ struct dma_filter { * by tx_status * @device_alloc_chan_resources: allocate resources and return the * number of allocated descriptors + * @device_router_config: optional callback for DMA router configuration * @device_free_chan_resources: release DMA channel's resources * @device_prep_dma_memcpy: prepares a memcpy operation * @device_prep_dma_xor: prepares a xor operation @@ -874,6 +875,7 @@ struct dma_device { enum dma_residue_granularity residue_granularity; int (*device_alloc_chan_resources)(struct dma_chan *chan); + int (*device_router_config)(struct dma_chan *chan); void (*device_free_chan_resources)(struct dma_chan *chan); struct dma_async_tx_descriptor *(*device_prep_dma_memcpy)( -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-30 9:14 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 9:13 [PATCH 00/18] dmaengine/soc: k3-udma: Add support for BCDMA and PKTDMA Peter Ujfalusi 2020-09-30 9:13 ` Peter Ujfalusi 2020-09-30 9:13 ` Peter Ujfalusi [this message] 2020-09-30 9:13 ` [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback Peter Ujfalusi 2020-10-07 5:44 ` Vinod Koul 2020-10-07 5:44 ` Vinod Koul 2020-10-07 8:08 ` Peter Ujfalusi 2020-10-07 8:08 ` Peter Ujfalusi 2020-10-07 15:55 ` Vinod Koul 2020-10-07 15:55 ` Vinod Koul 2020-10-08 6:41 ` Peter Ujfalusi 2020-10-08 6:41 ` Peter Ujfalusi 2020-10-28 5:55 ` Vinod Koul 2020-10-28 5:55 ` Vinod Koul 2020-10-28 9:56 ` Peter Ujfalusi 2020-10-28 9:56 ` Peter Ujfalusi 2020-11-09 11:45 ` Vinod Koul 2020-11-09 11:45 ` Vinod Koul 2020-11-09 12:09 ` Peter Ujfalusi 2020-11-09 12:09 ` Peter Ujfalusi 2020-11-09 12:23 ` Vinod Koul 2020-11-09 12:23 ` Vinod Koul 2020-11-09 12:36 ` Peter Ujfalusi 2020-11-09 12:36 ` Peter Ujfalusi 2020-09-30 9:13 ` [PATCH 02/18] dmaengine: Add support for per channel coherency handling Peter Ujfalusi 2020-09-30 9:13 ` Peter Ujfalusi 2020-09-30 9:13 ` [PATCH 03/18] dmaengine: doc: client: Update for dmaengine_get_dma_device() usage Peter Ujfalusi 2020-09-30 9:13 ` Peter Ujfalusi 2020-09-30 9:13 ` [PATCH 04/18] dmaengine: dmatest: Use dmaengine_get_dma_device Peter Ujfalusi 2020-09-30 9:13 ` Peter Ujfalusi 2020-09-30 9:13 ` [PATCH 05/18] dmaengine: ti: k3-udma: Wait for peer teardown completion if supported Peter Ujfalusi 2020-09-30 9:13 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 06/18] dmaengine: ti: k3-udma: Add support for second resource range from sysfw Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 07/18] dmaengine: ti: k3-udma-glue: Add function to get device pointer for DMA API Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-10-07 6:53 ` Vinod Koul 2020-10-07 6:53 ` Vinod Koul 2020-10-07 8:22 ` Peter Ujfalusi 2020-10-07 8:22 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 08/18] dmaengine: ti: k3-udma-glue: Configure the dma_dev for rings Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 09/18] dt-bindings: dma: ti: Add document for K3 BCDMA Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-10-01 6:49 ` Peter Ujfalusi 2020-10-01 6:49 ` Peter Ujfalusi 2020-10-06 19:23 ` Rob Herring 2020-10-06 19:23 ` Rob Herring 2020-10-06 19:29 ` Rob Herring 2020-10-06 19:29 ` Rob Herring 2020-10-07 9:09 ` Peter Ujfalusi 2020-10-07 9:09 ` Peter Ujfalusi 2020-10-07 15:46 ` Rob Herring 2020-10-07 15:46 ` Rob Herring 2020-10-08 8:40 ` Peter Ujfalusi 2020-10-08 8:40 ` Peter Ujfalusi 2020-10-08 19:15 ` Rob Herring 2020-10-08 19:15 ` Rob Herring 2020-10-09 8:06 ` Peter Ujfalusi 2020-10-09 8:06 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 10/18] dt-bindings: dma: ti: Add document for K3 PKTDMA Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 11/18] dmaengine: ti: k3-psil: Extend psil_endpoint_config " Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 12/18] dmaengine: ti: k3-psil: Add initial map for AM64 Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 13/18] dmaengine: ti: Add support for k3 event routers Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 14/18] soc: ti: k3-ringacc: add AM64 DMA rings support Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 15/18] dmaengine: ti: k3-udma: Initial support for K3 BCDMA Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 16/18] dmaengine: ti: k3-udma: Add support for BCDMA channel TPL handling Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 17/18] dmaengine: ti: k3-udma: Initial support for K3 PKTDMA Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 9:14 ` [PATCH 18/18] dmaengine: ti: k3-udma-glue: Add " Peter Ujfalusi 2020-09-30 9:14 ` Peter Ujfalusi 2020-09-30 10:17 ` [PATCH 00/18] dmaengine/soc: k3-udma: Add support for BCDMA and PKTDMA Peter Ujfalusi 2020-09-30 10:17 ` Peter Ujfalusi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200930091412.8020-2-peter.ujfalusi@ti.com \ --to=peter.ujfalusi@ti.com \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lokeshvutla@ti.com \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ --cc=ssantosh@kernel.org \ --cc=t-kristo@ti.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.