All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
To: alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, vinod.koul@linux.intel.com,
	andriy.shevchenko@intel.com, tiwai@suse.com,
	jee.heng.sia@intel.com, pierre-louis.bossart@linux.intel.com,
	liam.r.girdwood@linux.intel.com, broonie@kernel.org,
	lars@metafoo.de
Subject: [PATCH 1/5] ASoC: Intel: KMB: Fix S24_LE configuration
Date: Mon, 16 Nov 2020 14:19:01 +0800	[thread overview]
Message-ID: <20201116061905.32431-2-michael.wei.hong.sit@intel.com> (raw)
In-Reply-To: <20201116061905.32431-1-michael.wei.hong.sit@intel.com>

S24_LE is 24 bit audio in 32 bit container configuration
Fixing the configuration to match the data arrangement of
this audio format.

Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver")

Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/keembay/kmb_platform.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/keembay/kmb_platform.c b/sound/soc/intel/keembay/kmb_platform.c
index f54b710ee1c2..291a686568c2 100644
--- a/sound/soc/intel/keembay/kmb_platform.c
+++ b/sound/soc/intel/keembay/kmb_platform.c
@@ -487,9 +487,9 @@ static int kmb_dai_hw_params(struct snd_pcm_substream *substream,
 		kmb_i2s->xfer_resolution = 0x02;
 		break;
 	case SNDRV_PCM_FORMAT_S24_LE:
-		config->data_width = 24;
-		kmb_i2s->ccr = 0x08;
-		kmb_i2s->xfer_resolution = 0x04;
+		config->data_width = 32;
+		kmb_i2s->ccr = 0x14;
+		kmb_i2s->xfer_resolution = 0x05;
 		break;
 	case SNDRV_PCM_FORMAT_S32_LE:
 		config->data_width = 32;
-- 
2.17.1


  reply	other threads:[~2020-11-16  6:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  6:19 [PATCH 0/5] This patch series enables DMA mode on Intel Keem Bay platform Michael Sit Wei Hong
2020-11-16  6:19 ` Michael Sit Wei Hong [this message]
2020-11-16  6:19 ` [PATCH 2/5] dt-bindings: sound: intel, keembay-i2s: Add info for device to use DMA Michael Sit Wei Hong
2020-11-16  6:19 ` [PATCH 3/5] ASoC: soc-generic-dmaengine-pcm: Add custom prepare and submit function Michael Sit Wei Hong
2020-11-16 19:58   ` Mark Brown
2020-11-16 20:10     ` Pierre-Louis Bossart
2020-11-16 21:16       ` Mark Brown
2020-11-16  6:19 ` [PATCH 4/5] ASoC: dmaengine_pcm: expose functions to header file for custom functions Michael Sit Wei Hong
2020-11-16  6:19 ` [PATCH 5/5] ASoC: Intel: KMB: Enable DMA transfer mode Michael Sit Wei Hong
2020-11-16 23:32 ` [PATCH 0/5] This patch series enables DMA mode on Intel Keem Bay platform Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2020-11-16  6:14 Michael Sit Wei Hong
2020-11-16  6:14 ` [PATCH 1/5] ASoC: Intel: KMB: Fix S24_LE configuration Michael Sit Wei Hong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116061905.32431-2-michael.wei.hong.sit@intel.com \
    --to=michael.wei.hong.sit@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=jee.heng.sia@intel.com \
    --cc=lars@metafoo.de \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=vinod.koul@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.