All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 3/7] file-posix: allow -EBUSY errors during write zeros on raw block devices
Date: Tue, 17 Nov 2020 13:15:54 +0100	[thread overview]
Message-ID: <20201117121558.249585-4-kwolf@redhat.com> (raw)
In-Reply-To: <20201117121558.249585-1-kwolf@redhat.com>

From: Maxim Levitsky <mlevitsk@redhat.com>

On Linux, fallocate(fd, FALLOC_FL_PUNCH_HOLE) when it is used on a block device,
without O_DIRECT can return -EBUSY if it races with another write to the same page.

Since this is rare and discard is not a critical operation, ignore this error

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20201111153913.41840-2-mlevitsk@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/file-posix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/file-posix.c b/block/file-posix.c
index c63926d592..d5fd1dbcd2 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1698,6 +1698,7 @@ static int handle_aiocb_write_zeroes_unmap(void *opaque)
     switch (ret) {
     case -ENOTSUP:
     case -EINVAL:
+    case -EBUSY:
         break;
     default:
         return ret;
-- 
2.28.0



  parent reply	other threads:[~2020-11-17 12:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 12:15 [PULL 0/7] Patches for 5.2.0-rc2 Kevin Wolf
2020-11-17 12:15 ` [PULL 1/7] char-stdio: Fix QMP default for 'signal' Kevin Wolf
2020-11-17 12:15 ` [PULL 2/7] iotests: Replace deprecated ConfigParser.readfp() Kevin Wolf
2020-11-17 12:15 ` Kevin Wolf [this message]
2020-11-17 12:15 ` [PULL 4/7] io_uring: do not use pointer after free Kevin Wolf
2020-11-17 12:15 ` [PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted Kevin Wolf
2020-11-17 12:15 ` [PULL 6/7] iotests/081: Filter image format after testdir Kevin Wolf
2020-11-17 12:15 ` [PULL 7/7] iotests/081: Test rewrite-corrupted without WRITE Kevin Wolf
2020-11-17 16:40 ` [PULL 0/7] Patches for 5.2.0-rc2 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117121558.249585-4-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.