From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH 03/40] drm/msm/adreno/a6xx_gpu_state: Make some local functions static Date: Tue, 24 Nov 2020 19:37:47 +0000 [thread overview] Message-ID: <20201124193824.1118741-4-lee.jones@linaro.org> (raw) In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:83:7: warning: no previous prototype for ‘state_kcalloc’ [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:95:7: warning: no previous prototype for ‘state_kmemdup’ [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:947:6: warning: no previous prototype for ‘a6xx_gpu_state_destroy’ [-Wmissing-prototypes] Cc: Rob Clark <robdclark@gmail.com> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c index e9ede19193b0e..c1699b4f9a897 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -80,7 +80,7 @@ struct a6xx_state_memobj { unsigned long long data[]; }; -void *state_kcalloc(struct a6xx_gpu_state *a6xx_state, int nr, size_t objsize) +static void *state_kcalloc(struct a6xx_gpu_state *a6xx_state, int nr, size_t objsize) { struct a6xx_state_memobj *obj = kzalloc((nr * objsize) + sizeof(*obj), GFP_KERNEL); @@ -92,7 +92,7 @@ void *state_kcalloc(struct a6xx_gpu_state *a6xx_state, int nr, size_t objsize) return &obj->data; } -void *state_kmemdup(struct a6xx_gpu_state *a6xx_state, void *src, +static void *state_kmemdup(struct a6xx_gpu_state *a6xx_state, void *src, size_t size) { void *dst = state_kcalloc(a6xx_state, 1, size); @@ -944,7 +944,7 @@ struct msm_gpu_state *a6xx_gpu_state_get(struct msm_gpu *gpu) return &a6xx_state->base; } -void a6xx_gpu_state_destroy(struct kref *kref) +static void a6xx_gpu_state_destroy(struct kref *kref) { struct a6xx_state_memobj *obj, *tmp; struct msm_gpu_state *state = container_of(kref, -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: freedreno@lists.freedesktop.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run> Subject: [PATCH 03/40] drm/msm/adreno/a6xx_gpu_state: Make some local functions static Date: Tue, 24 Nov 2020 19:37:47 +0000 [thread overview] Message-ID: <20201124193824.1118741-4-lee.jones@linaro.org> (raw) In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:83:7: warning: no previous prototype for ‘state_kcalloc’ [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:95:7: warning: no previous prototype for ‘state_kmemdup’ [-Wmissing-prototypes] drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:947:6: warning: no previous prototype for ‘a6xx_gpu_state_destroy’ [-Wmissing-prototypes] Cc: Rob Clark <robdclark@gmail.com> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c index e9ede19193b0e..c1699b4f9a897 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -80,7 +80,7 @@ struct a6xx_state_memobj { unsigned long long data[]; }; -void *state_kcalloc(struct a6xx_gpu_state *a6xx_state, int nr, size_t objsize) +static void *state_kcalloc(struct a6xx_gpu_state *a6xx_state, int nr, size_t objsize) { struct a6xx_state_memobj *obj = kzalloc((nr * objsize) + sizeof(*obj), GFP_KERNEL); @@ -92,7 +92,7 @@ void *state_kcalloc(struct a6xx_gpu_state *a6xx_state, int nr, size_t objsize) return &obj->data; } -void *state_kmemdup(struct a6xx_gpu_state *a6xx_state, void *src, +static void *state_kmemdup(struct a6xx_gpu_state *a6xx_state, void *src, size_t size) { void *dst = state_kcalloc(a6xx_state, 1, size); @@ -944,7 +944,7 @@ struct msm_gpu_state *a6xx_gpu_state_get(struct msm_gpu *gpu) return &a6xx_state->base; } -void a6xx_gpu_state_destroy(struct kref *kref) +static void a6xx_gpu_state_destroy(struct kref *kref) { struct a6xx_state_memobj *obj, *tmp; struct msm_gpu_state *state = container_of(kref, -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-24 19:45 UTC|newest] Thread overview: 231+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-24 19:37 [PATCH 00/40] [Set 9] Rid W=1 warnings from GPU Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` [PATCH 01/40] drm/msm/msm_gem_shrinker: Fix descriptions for 'drm_device' Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` [PATCH 02/40] drm/amd/amdgpu/gmc_v10_0: Suppy some missing function doc descriptions Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:04 ` Alex Deucher 2020-11-30 22:04 ` Alex Deucher 2020-11-30 22:04 ` Alex Deucher 2020-11-24 19:37 ` Lee Jones [this message] 2020-11-24 19:37 ` [PATCH 03/40] drm/msm/adreno/a6xx_gpu_state: Make some local functions static Lee Jones 2020-11-24 19:37 ` [PATCH 04/40] drm/amd/amdgpu/iceland_ih: Add missing function param descriptions for 'ih' and 'entry' Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:05 ` Alex Deucher 2020-11-30 22:05 ` Alex Deucher 2020-11-30 22:05 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 05/40] drm/amd/amdgpu/tonga_ih: Provide some missing " Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:06 ` Alex Deucher 2020-11-30 22:06 ` Alex Deucher 2020-11-30 22:06 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 06/40] drm/amd/amdgpu/cz_ih: Add missing function param " Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:08 ` Alex Deucher 2020-11-30 22:08 ` Alex Deucher 2020-11-30 22:08 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 07/40] drm/amd/amdgpu/amdgpu_psp: Make local function 'parse_ta_bin_descriptor' static Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:07 ` Alex Deucher 2020-11-30 22:07 ` Alex Deucher 2020-11-30 22:07 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 08/40] drm/msm/dp/dp_ctrl: Move 'tu' from the stack to the heap Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` [PATCH 09/40] drm/amd/amdgpu/vega10_ih: Add descriptions for 'ih' and 'entry' Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:09 ` Alex Deucher 2020-11-30 22:09 ` Alex Deucher 2020-11-30 22:09 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 10/40] drm/amd/amdgpu/navi10_ih: " Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:10 ` Alex Deucher 2020-11-30 22:10 ` Alex Deucher 2020-11-30 22:10 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 11/40] drm/amd/amdgpu/psp_v11_0: Make local function 'psp_v11_0_wait_for_bootloader()' static Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:11 ` Alex Deucher 2020-11-30 22:11 ` Alex Deucher 2020-11-30 22:11 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 12/40] drm/amd/amdgpu/dce_v10_0: Supply description for function param 'async' Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:12 ` Alex Deucher 2020-11-30 22:12 ` Alex Deucher 2020-11-30 22:12 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 13/40] drm/amd/amdgpu/dce_v11_0: " Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:12 ` Alex Deucher 2020-11-30 22:12 ` Alex Deucher 2020-11-30 22:12 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 14/40] drm/amd/amdgpu/gfx_v9_0: Make called-by-reference only function static Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:13 ` Alex Deucher 2020-11-30 22:13 ` Alex Deucher 2020-11-30 22:13 ` Alex Deucher 2020-11-24 19:37 ` [PATCH 15/40] drm/amd/amdgpu/gfx_v8_0: Functions must follow directly after their headers Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-24 19:37 ` Lee Jones 2020-11-30 22:18 ` Alex Deucher 2020-11-30 22:18 ` Alex Deucher 2020-11-30 22:18 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 16/40] drm/amd/amdgpu/gfx_v10_0: Remove a bunch of set but unused variables Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:20 ` Alex Deucher 2020-11-30 22:20 ` Alex Deucher 2020-11-30 22:20 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 17/40] drm/amd/amdgpu/sdma_v2_4: Fix a bunch of kernel-doc function documentation issues Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:23 ` Alex Deucher 2020-11-30 22:23 ` Alex Deucher 2020-11-30 22:23 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 18/40] drm/amd/amdgpu/sdma_v3_0: " Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:24 ` Alex Deucher 2020-11-30 22:24 ` Alex Deucher 2020-11-30 22:24 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 19/40] drm/amd/amdgpu/sdma_v3_0: Fix incorrect param doc-rot issue Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:26 ` Alex Deucher 2020-11-30 22:26 ` Alex Deucher 2020-11-30 22:26 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 20/40] drm/amd/amdgpu/uvd_v5_0: Fix a bunch of kernel-doc function documentation issues Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:27 ` Alex Deucher 2020-11-30 22:27 ` Alex Deucher 2020-11-30 22:27 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 21/40] drm/amd/amdgpu/sdma_v4_0: Repair a bunch of kernel-doc problems Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:29 ` Alex Deucher 2020-11-30 22:29 ` Alex Deucher 2020-11-30 22:29 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 22/40] drm/amd/amdgpu/amdgpu_uvd: Fix some function documentation headers Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:30 ` Alex Deucher 2020-11-30 22:30 ` Alex Deucher 2020-11-30 22:30 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 23/40] drm/amd/amdgpu/sdma_v5_0: Provide some missing and repair other function params Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:48 ` Alex Deucher 2020-11-30 22:48 ` Alex Deucher 2020-11-30 22:48 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 24/40] drm/amd/amdgpu/sdma_v5_2: " Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:33 ` Alex Deucher 2020-11-30 22:33 ` Alex Deucher 2020-11-30 22:33 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 25/40] drm/amd/amdgpu/amdgpu_vce: " Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:36 ` Alex Deucher 2020-11-30 22:36 ` Alex Deucher 2020-11-30 22:36 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 26/40] drm/amd/amdgpu/uvd_v6_0: Fix a bunch of kernel-doc function documentation issues Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:37 ` Alex Deucher 2020-11-30 22:37 ` Alex Deucher 2020-11-30 22:37 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 27/40] drm/amd/amdgpu/uvd_v7_0: " Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:39 ` Alex Deucher 2020-11-30 22:39 ` Alex Deucher 2020-11-30 22:39 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 28/40] drm/amd/amdgpu/gfx_v10_0: Make local function 'gfx_v10_0_rlc_stop()' static Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:40 ` Alex Deucher 2020-11-30 22:40 ` Alex Deucher 2020-11-30 22:40 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 29/40] drm/amd/amdgpu/vcn_v1_0: Fix a few kernel-doc misdemeanours Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:41 ` Alex Deucher 2020-11-30 22:41 ` Alex Deucher 2020-11-30 22:41 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 30/40] drm/amd/amdgpu/jpeg_v1_0: Add some missing function param descriptions Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:43 ` Alex Deucher 2020-11-30 22:43 ` Alex Deucher 2020-11-30 22:43 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 31/40] drm/amd/amdgpu/jpeg_v2_0: Add some missing kernel-doc descriptions Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:44 ` Alex Deucher 2020-11-30 22:44 ` Alex Deucher 2020-11-30 22:44 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 32/40] drm/amd/amdgpu/vcn_v2_0: Fix a few kernel-doc misdemeanours Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:46 ` Alex Deucher 2020-11-30 22:46 ` Alex Deucher 2020-11-30 22:46 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 33/40] drm/amd/amdgpu/vcn_v3_0: Remove unused variable 'direct_poll' from 'vcn_v3_0_start_sriov()' Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:49 ` Alex Deucher 2020-11-30 22:49 ` Alex Deucher 2020-11-30 22:49 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 34/40] drm/amd/amdgpu/amdgpu_acp: Fix doc-rot issues pertaining to a couple of 'handle' params Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:50 ` Alex Deucher 2020-11-30 22:50 ` Alex Deucher 2020-11-30 22:50 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 35/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_set_default_dpm_tables()' static Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:58 ` Alex Deucher 2020-11-30 22:58 ` Alex Deucher 2020-11-30 22:58 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 36/40] drm/amd/pm/inc/smu_v11_0: Mark 'smu11_thermal_policy' as __maybe_unused Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 22:59 ` Alex Deucher 2020-11-30 22:59 ` Alex Deucher 2020-11-30 22:59 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 37/40] drm/amd/pm/swsmu/smu12/renoir_ppt: Demote kernel-doc formatting abuse Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 23:00 ` Alex Deucher 2020-11-30 23:00 ` Alex Deucher 2020-11-30 23:00 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 38/40] drm/amd/pm/swsmu/smu11/navi10_ppt: Remove unused 'struct i2c_algorithm navi10_i2c_algo' Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 23:01 ` Alex Deucher 2020-11-30 23:01 ` Alex Deucher 2020-11-30 23:01 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 39/40] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Remove unused variable 'result' Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 23:03 ` Alex Deucher 2020-11-30 23:03 ` Alex Deucher 2020-11-30 23:03 ` Alex Deucher 2020-11-24 19:38 ` [PATCH 40/40] drm/amd/amdgpu/amdgpu_uvd: Add description for amdgpu_uvd_cs_msg_decode()'s 'buf_sizes' param Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-24 19:38 ` Lee Jones 2020-11-30 23:03 ` Alex Deucher 2020-11-30 23:03 ` Alex Deucher 2020-11-30 23:03 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201124193824.1118741-4-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.