From: Sam Ravnborg <sam@ravnborg.org> To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones <lee.jones@linaro.org> Cc: Aditya Pakki <pakki001@umn.edu>, Alexander Klimov <grandmaster@al2klimov.de>, Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>, Arnd Bergmann <arnd@arndb.de>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>, Florian Tobias Schandinat <FlorianSchandinat@gmx.de>, George Kennedy <george.kennedy@oracle.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Gustavo Silva <gustavoars@kernel.org>, Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>, Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>, Joe Perches <joe@perches.com>, Kristoffer Ericson <kristoffer.ericson@gmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mike Rapoport <rppt@kernel.org>, Nathan Chancellor <natechancellor@gmail.com>, Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>, Qilong Zhang <zhangqilong3@huawei.com>, Randy Dunlap <rdunlap@infradead.org>, Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>, Sam Ravnborg <sam@ravnborg.org>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Thomas Winischhofer <thomas@winischhofer.net>, Thomas Zimemrmann <tzimmermann@suse.de>, Vaibhav Gupta <vaibhavgupta40@gmail.com>, Xiaofei Tan <tanxiaofei@huawei.com> Subject: [PATCH v2 20/28] video: fbdev: nvidia: Fix set but not used warnings Date: Sat, 28 Nov 2020 23:41:06 +0100 [thread overview] Message-ID: <20201128224114.1033617-21-sam@ravnborg.org> (raw) In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org> Fix warnings by deleting unused code. The register reads are kept as it is unknown if there are any hidden side-effects. v2: - Update subject (Lee) Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Antonino Daplas <adaplas@gmail.com> Cc: linux-fbdev@vger.kernel.org Cc: Lee Jones <lee.jones@linaro.org> --- drivers/video/fbdev/nvidia/nv_setup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c index 2fa68669613a..5404017e6957 100644 --- a/drivers/video/fbdev/nvidia/nv_setup.c +++ b/drivers/video/fbdev/nvidia/nv_setup.c @@ -89,9 +89,8 @@ u8 NVReadSeq(struct nvidia_par *par, u8 index) } void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) { - volatile u8 tmp; - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else @@ -101,9 +100,7 @@ void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) } u8 NVReadAttr(struct nvidia_par *par, u8 index) { - volatile u8 tmp; - - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones <lee.jones@linaro.org> Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Florian Tobias Schandinat <FlorianSchandinat@gmx.de>, Evgeny Novikov <novikov@ispras.ru>, Sam Ravnborg <sam@ravnborg.org>, Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Thomas Winischhofer <thomas@winischhofer.net>, Thomas Zimemrmann <tzimmermann@suse.de>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Jani Nikula <jani.nikula@intel.com>, Aditya Pakki <pakki001@umn.edu>, Xiaofei Tan <tanxiaofei@huawei.com>, Nathan Chancellor <natechancellor@gmail.com>, Alex Dewar <alex.dewar90@gmail.com>, Jason Yan <yanaijie@huawei.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Qilong Zhang <zhangqilong3@huawei.com>, Randy Dunlap <rdunlap@infradead.org>, Gustavo Silva <gustavoars@kernel.org>, Peter Rosin <peda@axentia.se>, George Kennedy <george.kennedy@oracle.com>, Kristoffer Ericson <kristoffer.ericson@gmail.com>, Alexander Klimov <grandmaster@al2klimov.de>, Jingoo Han <jingoohan1@gmail.com>, Joe Perches <joe@perches.com>, Peilin Ye <yepeilin.cs@gmail.com>, Mike Rapoport <rppt@kernel.org> Subject: [PATCH v2 20/28] video: fbdev: nvidia: Fix set but not used warnings Date: Sat, 28 Nov 2020 23:41:06 +0100 [thread overview] Message-ID: <20201128224114.1033617-21-sam@ravnborg.org> (raw) In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org> Fix warnings by deleting unused code. The register reads are kept as it is unknown if there are any hidden side-effects. v2: - Update subject (Lee) Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Antonino Daplas <adaplas@gmail.com> Cc: linux-fbdev@vger.kernel.org Cc: Lee Jones <lee.jones@linaro.org> --- drivers/video/fbdev/nvidia/nv_setup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c index 2fa68669613a..5404017e6957 100644 --- a/drivers/video/fbdev/nvidia/nv_setup.c +++ b/drivers/video/fbdev/nvidia/nv_setup.c @@ -89,9 +89,8 @@ u8 NVReadSeq(struct nvidia_par *par, u8 index) } void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) { - volatile u8 tmp; - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else @@ -101,9 +100,7 @@ void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) } u8 NVReadAttr(struct nvidia_par *par, u8 index) { - volatile u8 tmp; - - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-28 22:43 UTC|newest] Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-28 22:40 [PATCH v2 0/28] drivers/video: W=1 warning fixes Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-28 22:40 ` [PATCH v2 01/28] video: Fix kernel-doc warnings in of_display_timing + of_videomode Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-29 10:01 ` Thomas Zimmermann 2020-11-29 10:01 ` Thomas Zimmermann 2020-11-29 11:22 ` Sam Ravnborg 2020-11-29 11:22 ` Sam Ravnborg 2020-11-29 21:43 ` Sam Ravnborg 2020-11-29 21:43 ` Sam Ravnborg 2020-11-28 22:40 ` [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-29 10:03 ` Thomas Zimmermann 2020-11-29 10:03 ` Thomas Zimmermann 2020-11-29 10:28 ` Tetsuo Handa 2020-11-29 10:28 ` Tetsuo Handa 2020-11-29 11:18 ` Sam Ravnborg 2020-11-29 11:18 ` Sam Ravnborg 2020-11-30 6:38 ` Peilin Ye 2020-11-30 6:38 ` Peilin Ye 2020-11-30 7:56 ` Sam Ravnborg 2020-11-30 7:56 ` Sam Ravnborg 2020-11-30 8:52 ` Peilin Ye 2020-11-30 8:52 ` Peilin Ye 2020-11-29 21:45 ` Sam Ravnborg 2020-11-29 21:45 ` Sam Ravnborg 2020-11-28 22:40 ` [PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-29 10:08 ` Thomas Zimmermann 2020-11-29 10:08 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 04/28] video: fbdev: aty: Delete unused variable in radeon_monitor Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 8:51 ` Thomas Zimmermann 2020-11-30 8:51 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 8:53 ` Thomas Zimmermann 2020-11-30 8:53 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings in mach64_ct Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 8:57 ` Thomas Zimmermann 2020-11-30 8:57 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 8:59 ` Thomas Zimmermann 2020-11-30 8:59 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 9:13 ` Thomas Zimmermann 2020-11-30 9:13 ` Thomas Zimmermann 2020-11-30 19:01 ` Sam Ravnborg 2020-11-30 19:01 ` Sam Ravnborg 2020-12-01 9:58 ` Thomas Zimmermann 2020-12-01 9:58 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings in init.c Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 9:16 ` Thomas Zimmermann 2020-11-30 9:16 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings in sis_main Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 10:14 ` Thomas Zimmermann 2020-11-30 10:14 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 11/28] video: fbdev: via: Fix set but not used warning for mode_crt_table Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 12:08 ` Thomas Zimmermann 2020-11-30 12:08 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning in att_outb() Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 12:12 ` Thomas Zimmermann 2020-11-30 12:12 ` Thomas Zimmermann 2020-11-28 22:40 ` [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings Sam Ravnborg 2020-11-28 22:40 ` Sam Ravnborg 2020-11-30 12:14 ` Thomas Zimmermann 2020-11-30 12:14 ` Thomas Zimmermann 2020-11-30 18:35 ` Sam Ravnborg 2020-11-30 18:35 ` Sam Ravnborg 2020-12-01 8:47 ` Lee Jones 2020-12-01 8:47 ` Lee Jones 2020-12-01 9:07 ` Sam Ravnborg 2020-12-01 9:07 ` Sam Ravnborg 2020-12-01 9:46 ` Lee Jones 2020-12-01 9:46 ` Lee Jones 2020-12-01 10:04 ` Daniel Vetter 2020-12-01 10:04 ` Daniel Vetter 2020-12-01 10:27 ` Lee Jones 2020-12-01 10:27 ` Lee Jones 2020-11-28 22:41 ` [PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-30 12:15 ` Thomas Zimmermann 2020-11-30 12:15 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning for CursorMem Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-30 12:16 ` Thomas Zimmermann 2020-11-30 12:16 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 16/28] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-29 16:10 ` Randy Dunlap 2020-11-29 16:10 ` Randy Dunlap 2020-11-28 22:41 ` [PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but not used warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-30 13:04 ` Thomas Zimmermann 2020-11-30 13:04 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc, set but not used and string warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-30 13:22 ` Thomas Zimmermann 2020-11-30 13:22 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set but not used warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-30 14:25 ` Thomas Zimmermann 2020-11-30 14:25 ` Thomas Zimmermann 2020-11-28 22:41 ` Sam Ravnborg [this message] 2020-11-28 22:41 ` [PATCH v2 20/28] video: fbdev: nvidia: Fix " Sam Ravnborg 2020-11-30 14:35 ` Thomas Zimmermann 2020-11-30 14:35 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 21/28] video: fbdev: tmiofb: " Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-30 14:36 ` Thomas Zimmermann 2020-11-30 14:36 ` Thomas Zimmermann 2020-11-30 18:46 ` Sam Ravnborg 2020-11-30 18:46 ` Sam Ravnborg 2020-11-28 22:41 ` [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used warnings in dsi Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-12-01 10:03 ` Thomas Zimmermann 2020-12-01 10:03 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-12-01 10:06 ` Thomas Zimmermann 2020-12-01 10:06 ` Thomas Zimmermann 2020-12-05 20:58 ` Sam Ravnborg 2020-12-05 20:58 ` Sam Ravnborg 2020-11-28 22:41 ` [PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but not used warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-12-01 10:07 ` Thomas Zimmermann 2020-12-01 10:07 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-12-01 10:09 ` Thomas Zimmermann 2020-12-01 10:09 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 26/28] video: fbdev: uvesafb: Fix string related warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-12-01 14:19 ` Thomas Zimmermann 2020-12-01 14:19 ` Thomas Zimmermann 2020-11-28 22:41 ` [PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-12-01 14:21 ` Thomas Zimmermann 2020-12-01 14:21 ` Thomas Zimmermann 2020-12-05 20:18 ` Sam Ravnborg 2020-12-05 20:18 ` Sam Ravnborg 2020-11-28 22:41 ` [PATCH v2 28/28] video: fbdev: s1d13xxxfb: " Sam Ravnborg 2020-11-28 22:41 ` Sam Ravnborg 2020-11-29 9:59 ` Thomas Zimmermann 2020-11-29 9:59 ` Thomas Zimmermann 2020-11-29 21:52 ` Sam Ravnborg 2020-11-29 21:52 ` Sam Ravnborg 2020-12-01 14:23 ` Thomas Zimmermann 2020-12-01 14:23 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201128224114.1033617-21-sam@ravnborg.org \ --to=sam@ravnborg.org \ --cc=FlorianSchandinat@gmx.de \ --cc=adaplas@gmail.com \ --cc=alex.dewar90@gmail.com \ --cc=arnd@arndb.de \ --cc=b.zolnierkie@samsung.com \ --cc=benh@kernel.crashing.org \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=george.kennedy@oracle.com \ --cc=grandmaster@al2klimov.de \ --cc=gregkh@linuxfoundation.org \ --cc=gustavoars@kernel.org \ --cc=jani.nikula@intel.com \ --cc=jingoohan1@gmail.com \ --cc=jirislaby@kernel.org \ --cc=joe@perches.com \ --cc=kristoffer.ericson@gmail.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=lee.jones@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=natechancellor@gmail.com \ --cc=novikov@ispras.ru \ --cc=pakki001@umn.edu \ --cc=peda@axentia.se \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=rdunlap@infradead.org \ --cc=rppt@kernel.org \ --cc=saeed.mirzamohammadi@oracle.com \ --cc=tanxiaofei@huawei.com \ --cc=thomas@winischhofer.net \ --cc=tzimmermann@suse.de \ --cc=vaibhavgupta40@gmail.com \ --cc=yanaijie@huawei.com \ --cc=yepeilin.cs@gmail.com \ --cc=zhangqilong3@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.