All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [v14 04/15] drm/i915/display: Fixes quantization range for YCbCr output
Date: Tue,  1 Dec 2020 02:17:27 +0530	[thread overview]
Message-ID: <20201130204738.2443-5-uma.shankar@intel.com> (raw)
In-Reply-To: <20201130204738.2443-1-uma.shankar@intel.com>

This patch fixes the quantization range for YCbCr output on
Lspcon based devices.

v2: Re-phrased the description and added Ville's Rb.

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index f98891f058da..7cb65e0f241e 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -523,12 +523,17 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,
 	else
 		frame.avi.colorspace = HDMI_COLORSPACE_RGB;
 
-	drm_hdmi_avi_infoframe_quant_range(&frame.avi,
-					   conn_state->connector,
-					   adjusted_mode,
-					   crtc_state->limited_color_range ?
-					   HDMI_QUANTIZATION_RANGE_LIMITED :
-					   HDMI_QUANTIZATION_RANGE_FULL);
+	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_RGB) {
+		drm_hdmi_avi_infoframe_quant_range(&frame.avi,
+						   conn_state->connector,
+						   adjusted_mode,
+						   crtc_state->limited_color_range ?
+						   HDMI_QUANTIZATION_RANGE_LIMITED :
+						   HDMI_QUANTIZATION_RANGE_FULL);
+	} else {
+		frame.avi.quantization_range = HDMI_QUANTIZATION_RANGE_DEFAULT;
+		frame.avi.ycc_quantization_range = HDMI_YCC_QUANTIZATION_RANGE_LIMITED;
+	}
 
 	ret = hdmi_infoframe_pack(&frame, buf, sizeof(buf));
 	if (ret < 0) {
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-11-30 20:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 20:47 [Intel-gfx] [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 01/15] drm/i915/display: Add HDR Capability detection for LSPCON Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 02/15] drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 03/15] drm/i915/display: Attach HDR property for capable Gen9 devices Uma Shankar
2020-11-30 20:47 ` Uma Shankar [this message]
2020-11-30 20:47 ` [Intel-gfx] [v14 05/15] drm/i915/display: Add a WARN for invalid output range and format Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 06/15] drm/i915/display: Attach content type property for LSPCON Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 07/15] drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variants Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 08/15] drm/i915/display: Enable colorspace programming for LSPCON devices Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 09/15] drm/i915/display: Nuke bogus lspcon check Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 10/15] drm/i915/display: Enable HDR for Parade based lspcon Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 11/15] drm/i915/lspcon: Create separate infoframe_enabled helper Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 12/15] drm/i915/display: Implement infoframes readback for LSPCON Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 13/15] drm/i915/display: Implement DRM infoframe read " Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 14/15] drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks Uma Shankar
2020-11-30 20:47 ` [Intel-gfx] [v14 15/15] drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCON Uma Shankar
2020-12-01  0:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev15) Patchwork
2020-12-01  0:05 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-01  0:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-01 14:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-01 20:53 ` [Intel-gfx] [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices Shankar, Uma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130204738.2443-5-uma.shankar@intel.com \
    --to=uma.shankar@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.