From: Andrew Lunn <andrew@lunn.ch>
To: Lars Povlsen <lars.povlsen@microchip.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
linux-gpio@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 3/3] arm64: dts: sparx5: Add SGPIO devices
Date: Tue, 22 Dec 2020 14:56:46 +0100 [thread overview]
Message-ID: <20201222135646.GF3107610@lunn.ch> (raw)
In-Reply-To: <87eejip2xm.fsf@microchip.com>
On Tue, Dec 22, 2020 at 11:09:41AM +0100, Lars Povlsen wrote:
>
> Andrew Lunn writes:
>
> > On Fri, Nov 13, 2020 at 03:51:51PM +0100, Lars Povlsen wrote:
> >> + led@8 {
> >> + label = "eth12:green";
> >> + gpios = <&sgpio_out0 12 0 GPIO_ACTIVE_HIGH>;
> >> + default-state = "off";
> >> + };
> >> + led@9 {
> >> + label = "eth12:yellow";
> >> + gpios = <&sgpio_out0 12 1 GPIO_ACTIVE_HIGH>;
> >> + default-state = "off";
> >> + };
> >
> > Hi Lars
> >
> > I did not see these patches earlier, but i've been looking at the
> > switch driver patches recently, so went digging.
> >
> > Can the Ethernet switch itself control these LEDs for indicating
> > things like packet receive/transmit, link state, and link speed? Or
> > are they purely software controlled?
> >
> > Thanks
> > Andrew
>
> Hi Andrew!
>
> No, the SGPIO device is separate from the switch device as such. I was
> planning to couple the two by means of "led events" in a later patch.
O.K, good.
In the LED subsystem terminology, such an event would be a
trigger. Link state, and copper speed should already be mostly covered
by phylib triggers. What is missing is link activity. Does the switch
easily provide you with this information, or do you need to poll the
switch statistics counters every 10ms to blink the LEDs?
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Lars Povlsen <lars.povlsen@microchip.com>
Cc: devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
linux-gpio@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 3/3] arm64: dts: sparx5: Add SGPIO devices
Date: Tue, 22 Dec 2020 14:56:46 +0100 [thread overview]
Message-ID: <20201222135646.GF3107610@lunn.ch> (raw)
In-Reply-To: <87eejip2xm.fsf@microchip.com>
On Tue, Dec 22, 2020 at 11:09:41AM +0100, Lars Povlsen wrote:
>
> Andrew Lunn writes:
>
> > On Fri, Nov 13, 2020 at 03:51:51PM +0100, Lars Povlsen wrote:
> >> + led@8 {
> >> + label = "eth12:green";
> >> + gpios = <&sgpio_out0 12 0 GPIO_ACTIVE_HIGH>;
> >> + default-state = "off";
> >> + };
> >> + led@9 {
> >> + label = "eth12:yellow";
> >> + gpios = <&sgpio_out0 12 1 GPIO_ACTIVE_HIGH>;
> >> + default-state = "off";
> >> + };
> >
> > Hi Lars
> >
> > I did not see these patches earlier, but i've been looking at the
> > switch driver patches recently, so went digging.
> >
> > Can the Ethernet switch itself control these LEDs for indicating
> > things like packet receive/transmit, link state, and link speed? Or
> > are they purely software controlled?
> >
> > Thanks
> > Andrew
>
> Hi Andrew!
>
> No, the SGPIO device is separate from the switch device as such. I was
> planning to couple the two by means of "led events" in a later patch.
O.K, good.
In the LED subsystem terminology, such an event would be a
trigger. Link state, and copper speed should already be mostly covered
by phylib triggers. What is missing is link activity. Does the switch
easily provide you with this information, or do you need to poll the
switch statistics counters every 10ms to blink the LEDs?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-22 13:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:51 [PATCH v10 0/3] Adding support for Microchip/Microsemi serial GPIO controller Lars Povlsen
2020-11-13 14:51 ` Lars Povlsen
2020-11-13 14:51 ` [PATCH v10 1/3] dt-bindings: pinctrl: Add bindings for pinctrl-microchip-sgpio driver Lars Povlsen
2020-11-13 14:51 ` Lars Povlsen
2020-11-13 14:51 ` [PATCH v10 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO Lars Povlsen
2020-11-13 14:51 ` Lars Povlsen
2020-11-13 14:51 ` [PATCH v10 3/3] arm64: dts: sparx5: Add SGPIO devices Lars Povlsen
2020-11-13 14:51 ` Lars Povlsen
2020-11-23 14:31 ` Linus Walleij
2020-11-23 14:31 ` Linus Walleij
2020-11-23 15:03 ` Lars Povlsen
2020-11-23 15:03 ` Lars Povlsen
2020-12-20 22:48 ` Andrew Lunn
2020-12-20 22:48 ` Andrew Lunn
2020-12-22 10:09 ` Lars Povlsen
2020-12-22 10:09 ` Lars Povlsen
2020-12-22 13:56 ` Andrew Lunn [this message]
2020-12-22 13:56 ` Andrew Lunn
2020-12-22 14:58 ` Lars Povlsen
2020-12-22 14:58 ` Lars Povlsen
2020-11-23 14:30 ` [PATCH v10 0/3] Adding support for Microchip/Microsemi serial GPIO controller Linus Walleij
2020-11-23 14:30 ` Linus Walleij
2020-11-23 15:05 ` Lars Povlsen
2020-11-23 15:05 ` Lars Povlsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222135646.GF3107610@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.