All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, daniel.mantione@freepascal.org,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH 14/31] video: fbdev: aty: mach64_ct: Remove some set but unused variables
Date: Wed, 13 Jan 2021 14:49:52 +0000	[thread overview]
Message-ID: <20210113145009.1272040-15-lee.jones@linaro.org> (raw)
In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’:
 drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable]
 drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable]
 drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable]

Cc: daniel.mantione@freepascal.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/aty/mach64_ct.c | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c
index f87cc81f4fa2b..23eececa1e9d7 100644
--- a/drivers/video/fbdev/aty/mach64_ct.c
+++ b/drivers/video/fbdev/aty/mach64_ct.c
@@ -402,7 +402,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 	struct atyfb_par *par = (struct atyfb_par *) info->par;
 	u8 mpost_div, xpost_div, sclk_post_div_real;
 	u32 q, memcntl, trp;
-	u32 dsp_config, dsp_on_off, vga_dsp_config, vga_dsp_on_off;
+	u32 dsp_config;
 #ifdef DEBUG
 	int pllmclk, pllsclk;
 #endif
@@ -488,25 +488,10 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 
 	/* Allow BIOS to override */
 	dsp_config = aty_ld_le32(DSP_CONFIG, par);
-	dsp_on_off = aty_ld_le32(DSP_ON_OFF, par);
-	vga_dsp_config = aty_ld_le32(VGA_DSP_CONFIG, par);
-	vga_dsp_on_off = aty_ld_le32(VGA_DSP_ON_OFF, par);
 
 	if (dsp_config)
 		pll->ct.dsp_loop_latency = (dsp_config & DSP_LOOP_LATENCY) >> 16;
-#if 0
-	FIXME: is it relevant for us?
-	if ((!dsp_on_off && !M64_HAS(RESET_3D)) ||
-		((dsp_on_off == vga_dsp_on_off) &&
-		(!dsp_config || !((dsp_config ^ vga_dsp_config) & DSP_XCLKS_PER_QW)))) {
-		vga_dsp_on_off &= VGA_DSP_OFF;
-		vga_dsp_config &= VGA_DSP_XCLKS_PER_QW;
-		if (ATIDivide(vga_dsp_on_off, vga_dsp_config, 5, 1) > 24)
-			pll->ct.fifo_size = 32;
-		else
-			pll->ct.fifo_size = 24;
-	}
-#endif
+
 	/* Exit if the user does not want us to tamper with the clock
 	rates of her chip. */
 	if (par->mclk_per == 0) {
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: daniel.mantione@freepascal.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH 14/31] video: fbdev: aty: mach64_ct: Remove some set but unused variables
Date: Wed, 13 Jan 2021 14:49:52 +0000	[thread overview]
Message-ID: <20210113145009.1272040-15-lee.jones@linaro.org> (raw)
In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’:
 drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable]
 drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable]
 drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable]

Cc: daniel.mantione@freepascal.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/aty/mach64_ct.c | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c
index f87cc81f4fa2b..23eececa1e9d7 100644
--- a/drivers/video/fbdev/aty/mach64_ct.c
+++ b/drivers/video/fbdev/aty/mach64_ct.c
@@ -402,7 +402,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 	struct atyfb_par *par = (struct atyfb_par *) info->par;
 	u8 mpost_div, xpost_div, sclk_post_div_real;
 	u32 q, memcntl, trp;
-	u32 dsp_config, dsp_on_off, vga_dsp_config, vga_dsp_on_off;
+	u32 dsp_config;
 #ifdef DEBUG
 	int pllmclk, pllsclk;
 #endif
@@ -488,25 +488,10 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 
 	/* Allow BIOS to override */
 	dsp_config = aty_ld_le32(DSP_CONFIG, par);
-	dsp_on_off = aty_ld_le32(DSP_ON_OFF, par);
-	vga_dsp_config = aty_ld_le32(VGA_DSP_CONFIG, par);
-	vga_dsp_on_off = aty_ld_le32(VGA_DSP_ON_OFF, par);
 
 	if (dsp_config)
 		pll->ct.dsp_loop_latency = (dsp_config & DSP_LOOP_LATENCY) >> 16;
-#if 0
-	FIXME: is it relevant for us?
-	if ((!dsp_on_off && !M64_HAS(RESET_3D)) ||
-		((dsp_on_off == vga_dsp_on_off) &&
-		(!dsp_config || !((dsp_config ^ vga_dsp_config) & DSP_XCLKS_PER_QW)))) {
-		vga_dsp_on_off &= VGA_DSP_OFF;
-		vga_dsp_config &= VGA_DSP_XCLKS_PER_QW;
-		if (ATIDivide(vga_dsp_on_off, vga_dsp_config, 5, 1) > 24)
-			pll->ct.fifo_size = 32;
-		else
-			pll->ct.fifo_size = 24;
-	}
-#endif
+
 	/* Exit if the user does not want us to tamper with the clock
 	rates of her chip. */
 	if (par->mclk_per == 0) {
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-01-13 14:52 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 14:49 [PATCH 00/31] Rid W=1 warnings from Video Lee Jones
2021-01-13 14:49 ` Lee Jones
2021-01-13 14:49 ` [PATCH 01/31] video: fbdev: core: fbmon: Add missing description for 'specs' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 02/31] video: of_display_timing: Provide missing description for 'dt' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 03/31] video: fbdev: aty: atyfb_base: Remove superfluous code surrounding 'dac_type' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 04/31] video: fbdev: aty: atyfb_base: Mark 'dac_type' as __maybe_unused Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 05/31] video: of_videomode: Fix formatting in kernel-doc header Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 06/31] video: fbdev: core: fb_notify: Demote non-conformant " Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 07/31] video: fbdev: riva: fbdev: Fix some kernel-doc misdemeanours Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 08/31] video: fbdev: sis: sis_main: Remove unused variable 'reg' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 09/31] video: fbdev: sis: Remove superfluous include of 'init.h' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 10/31] video: fbdev: riva: riva_hw: Remove a bunch of unused variables Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 11/31] video: fbdev: sis: init: Remove four " Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 12/31] video: fbdev: sis: oem310: Remove some unused static const tables Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 13/31] video: fbdev: nvidia: nv_setup: Remove a couple of unused 'tmp' variables Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` Lee Jones [this message]
2021-01-13 14:49   ` [PATCH 14/31] video: fbdev: aty: mach64_ct: Remove some set but unused variables Lee Jones
2021-01-13 15:24   ` Daniël Mantione
2021-01-13 15:24     ` Daniël Mantione
2021-01-13 15:45     ` Lee Jones
2021-01-13 15:45       ` Lee Jones
2021-01-13 14:49 ` [PATCH 15/31] video: fbdev: via: lcd: Remove unused variable 'mode_crt_table' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 16/31] video: fbdev: pm2fb: Fix some kernel-doc formatting issues Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 17/31] video: fbdev: aty: radeon_monitor: Remove unused variable 'mon_types' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 18/31] video: fbdev: neofb: Remove unused variable 'CursorMem' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 19/31] video: fbdev: tdfxfb: Remove unused variable 'tmp' Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 20/31] video: fbdev: core: fbcon: Mark 'pending' as __maybe_unused Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:49 ` [PATCH 21/31] video: fbdev: sstfb: Mark 3 debug variables " Lee Jones
2021-01-13 14:49   ` Lee Jones
2021-01-13 14:50 ` [PATCH 22/31] video: fbdev: cirrusfb: Remove unused variable 'dummy' from 'WHDR()' Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 23/31] video: fbdev: s1d13xxxfb: Mark debug variables as __maybe_unused Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 20:07   ` Jingoo Han
2021-01-13 20:07     ` Jingoo Han
2021-01-13 14:50 ` [PATCH 25/31] video: fbdev: mx3fb: Remove unused variable 'enabled' Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 26/31] video: fbdev: riva: riva_hw: Remove set but unused variables 'vus_p' and 'vus_n' Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 27/31] video: fbdev: sis: init: Remove unused variables 'cr_data2', 'VT' and 'HT' Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 28/31] video: fbdev: cirrusfb: Add description for 'info' and correct spelling of 'regbase' Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 29/31] video: fbdev: s1d13xxxfb: Function name must be on the 2nd line in kernel-doc Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 14:50 ` [PATCH 30/31] video: fbdev: s3c-fb: Remove unused variable 'var' from 's3c_fb_probe_win()' Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 20:09   ` Jingoo Han
2021-01-13 20:09     ` Jingoo Han
2021-01-13 14:50 ` [PATCH 31/31] video: fbdev: mx3fb: Fix some kernel-doc issues Lee Jones
2021-01-13 14:50   ` Lee Jones
2021-01-13 19:01 ` [PATCH 00/31] Rid W=1 warnings from Video Sam Ravnborg
2021-01-13 19:01   ` Sam Ravnborg
2021-01-13 20:25   ` Lee Jones
2021-01-13 20:25     ` Lee Jones
2021-01-14  9:04     ` Jani Nikula
2021-01-14  9:04       ` Jani Nikula
2021-01-14  9:11       ` Daniel Vetter
2021-01-14  9:11         ` Daniel Vetter
2021-01-14  9:54         ` Daniel Vetter
2021-01-14  9:54           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113145009.1272040-15-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=daniel.mantione@freepascal.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.