From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> To: linux-media@vger.kernel.org, heiko.stuebner@theobroma-systems.com, heiko@sntech.de Cc: laurent.pinchart@ideasonboard.com, dafna.hirschfeld@collabora.com, helen.koike@collabora.com, ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, mchehab@kernel.org, tfiga@chromium.org Subject: [PATCH v7 0/5] Fix the rkisp1 userspace API for later IP versions Date: Wed, 20 Jan 2021 17:44:41 +0100 [thread overview] Message-ID: <20210120164446.1220-1-dafna.hirschfeld@collabora.com> (raw) Hi, This is v7 of the rkisp1 fixes set sent by Heiko Stuebner. [0] In addition to prepare the support to px30 (V12 in the uapi) This version of the set adds more fixes to the code in params/stats according to the changes in the uapi and also change the hist_bins to be u32 instead of u16. More details about the patchset can be found in v6's cover-letter [1] [0] https://patchwork.kernel.org/project/linux-media/list/?series=416647 [1] https://patchwork.kernel.org/project/linux-media/cover/20210118110448.275389-1-heiko@sntech.de/ changes since v6: - add a patch to change the hist_bins array type to __u32 and extend the documentation of how the histogram measurements are taken - remove a wrong u8 cast when filling the hist_bins array - when reducing the number of elements in the weight grid array, the code in rkisp1-params.c should be adjusted to iterate it 25 times - some minor typo and checkpatch fixes. changes since v5: - move grid reduction for V10 to separate patch (Hans) - fix commit message (histogram size 28 -> 25) in patch4 (Hans) changes since v4: - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) - start RKISP_Vxx enum with 10 for RKISP_V10 to make output easier and also allow userspace to differentiate between old (= 0) and newer driver variants (Dafna, Laurent) changes since v3: - add patch fixing the original histogram size comment - make comments in uapi more verbose (Hans) - fix wording in admin guide (Hans) - document version <-> soc in uapi as well (easier for people) (Dafna) changes since v2: - actually zero the correct sizes for u16 values (hist-bins) (kernel-test-robot) changes since v1: - drop duplicate isp_ver storage, hw_revision is enough (Dafna) - document multiple maximum sizes in uapi (Hans) - document usage of hw_revision field (Hans) - zero fields transmitted to userspace before adding data (Hans) - use _V10 field sizes when filling fields, as there is only v10 for now changes since rfc: - move rkisp1_version enum into uapo - show version in media-api hw_revision - introduce constants for versions and make max use the biggest Dafna Hirschfeld (2): media: rkisp1: uapi: change hist_bins array type from __u16 to __u32 media: rkisp1: stats: remove a wrong cast to u8 Heiko Stuebner (3): media: rockchip: rkisp1: reduce number of histogram grid elements in uapi media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes Documentation/admin-guide/media/rkisp1.rst | 16 ++++ .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++-- .../platform/rockchip/rkisp1/rkisp1-params.c | 5 +- .../platform/rockchip/rkisp1/rkisp1-stats.c | 15 +++- include/uapi/linux/rkisp1-config.h | 84 ++++++++++++++++--- 5 files changed, 116 insertions(+), 25 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> To: linux-media@vger.kernel.org, heiko.stuebner@theobroma-systems.com, heiko@sntech.de Cc: mchehab@kernel.org, dafna.hirschfeld@collabora.com, dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com Subject: [PATCH v7 0/5] Fix the rkisp1 userspace API for later IP versions Date: Wed, 20 Jan 2021 17:44:41 +0100 [thread overview] Message-ID: <20210120164446.1220-1-dafna.hirschfeld@collabora.com> (raw) Hi, This is v7 of the rkisp1 fixes set sent by Heiko Stuebner. [0] In addition to prepare the support to px30 (V12 in the uapi) This version of the set adds more fixes to the code in params/stats according to the changes in the uapi and also change the hist_bins to be u32 instead of u16. More details about the patchset can be found in v6's cover-letter [1] [0] https://patchwork.kernel.org/project/linux-media/list/?series=416647 [1] https://patchwork.kernel.org/project/linux-media/cover/20210118110448.275389-1-heiko@sntech.de/ changes since v6: - add a patch to change the hist_bins array type to __u32 and extend the documentation of how the histogram measurements are taken - remove a wrong u8 cast when filling the hist_bins array - when reducing the number of elements in the weight grid array, the code in rkisp1-params.c should be adjusted to iterate it 25 times - some minor typo and checkpatch fixes. changes since v5: - move grid reduction for V10 to separate patch (Hans) - fix commit message (histogram size 28 -> 25) in patch4 (Hans) changes since v4: - set GAMMA_OUT to the real 25 instead of the 28 with 3 spares (Dafna) - start RKISP_Vxx enum with 10 for RKISP_V10 to make output easier and also allow userspace to differentiate between old (= 0) and newer driver variants (Dafna, Laurent) changes since v3: - add patch fixing the original histogram size comment - make comments in uapi more verbose (Hans) - fix wording in admin guide (Hans) - document version <-> soc in uapi as well (easier for people) (Dafna) changes since v2: - actually zero the correct sizes for u16 values (hist-bins) (kernel-test-robot) changes since v1: - drop duplicate isp_ver storage, hw_revision is enough (Dafna) - document multiple maximum sizes in uapi (Hans) - document usage of hw_revision field (Hans) - zero fields transmitted to userspace before adding data (Hans) - use _V10 field sizes when filling fields, as there is only v10 for now changes since rfc: - move rkisp1_version enum into uapo - show version in media-api hw_revision - introduce constants for versions and make max use the biggest Dafna Hirschfeld (2): media: rkisp1: uapi: change hist_bins array type from __u16 to __u32 media: rkisp1: stats: remove a wrong cast to u8 Heiko Stuebner (3): media: rockchip: rkisp1: reduce number of histogram grid elements in uapi media: rockchip: rkisp1: carry ip version information media: rockchip: rkisp1: extend uapi array sizes Documentation/admin-guide/media/rkisp1.rst | 16 ++++ .../platform/rockchip/rkisp1/rkisp1-dev.c | 21 +++-- .../platform/rockchip/rkisp1/rkisp1-params.c | 5 +- .../platform/rockchip/rkisp1/rkisp1-stats.c | 15 +++- include/uapi/linux/rkisp1-config.h | 84 ++++++++++++++++--- 5 files changed, 116 insertions(+), 25 deletions(-) -- 2.17.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2021-01-20 16:52 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-20 16:44 Dafna Hirschfeld [this message] 2021-01-20 16:44 ` [PATCH v7 0/5] Fix the rkisp1 userspace API for later IP versions Dafna Hirschfeld 2021-01-20 16:44 ` [PATCH v7 1/5] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32 Dafna Hirschfeld 2021-01-20 16:44 ` Dafna Hirschfeld 2021-01-20 21:32 ` Sakari Ailus 2021-01-20 21:32 ` Sakari Ailus 2021-01-21 12:48 ` Dafna Hirschfeld 2021-01-21 12:48 ` Dafna Hirschfeld 2021-01-21 13:01 ` Sakari Ailus 2021-01-21 13:01 ` Sakari Ailus 2021-01-20 16:44 ` [PATCH v7 2/5] media: rkisp1: stats: remove a wrong cast to u8 Dafna Hirschfeld 2021-01-20 16:44 ` Dafna Hirschfeld 2021-01-21 9:31 ` Heiko Stuebner 2021-01-21 9:31 ` Heiko Stuebner 2021-01-21 10:07 ` Tomasz Figa 2021-01-21 10:07 ` Tomasz Figa 2021-01-21 11:47 ` Dafna Hirschfeld 2021-01-21 11:47 ` Dafna Hirschfeld 2021-01-20 16:44 ` [PATCH v7 3/5] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi Dafna Hirschfeld 2021-01-20 16:44 ` Dafna Hirschfeld 2021-01-20 16:44 ` [PATCH v7 4/5] media: rockchip: rkisp1: carry ip version information Dafna Hirschfeld 2021-01-20 16:44 ` Dafna Hirschfeld 2021-01-20 16:44 ` [PATCH v7 5/5] media: rockchip: rkisp1: extend uapi array sizes Dafna Hirschfeld 2021-01-20 16:44 ` Dafna Hirschfeld 2021-01-21 10:16 ` Tomasz Figa 2021-01-21 10:16 ` Tomasz Figa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210120164446.1220-1-dafna.hirschfeld@collabora.com \ --to=dafna.hirschfeld@collabora.com \ --cc=dafna3@gmail.com \ --cc=ezequiel@collabora.com \ --cc=heiko.stuebner@theobroma-systems.com \ --cc=heiko@sntech.de \ --cc=helen.koike@collabora.com \ --cc=hverkuil@xs4all.nl \ --cc=kernel@collabora.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.