From: Jeffle Xu <jefflexu@linux.alibaba.com> To: snitzer@redhat.com Cc: joseph.qi@linux.alibaba.com, dm-devel@redhat.com, linux-block@vger.kernel.org, io-uring@vger.kernel.org Subject: [PATCH v2 1/6] block: move definition of blk_qc_t to types.h Date: Mon, 25 Jan 2021 20:13:35 +0800 [thread overview] Message-ID: <20210125121340.70459-2-jefflexu@linux.alibaba.com> (raw) In-Reply-To: <20210125121340.70459-1-jefflexu@linux.alibaba.com> So that kiocb.ki_cookie can be defined as blk_qc_t, which will enforce the encapsulation. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Snitzer <snitzer@redhat.com> --- include/linux/blk_types.h | 2 +- include/linux/fs.h | 2 +- include/linux/types.h | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 866f74261b3b..2e05244fc16d 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -532,7 +532,7 @@ static inline int op_stat_group(unsigned int op) return op_is_write(op); } -typedef unsigned int blk_qc_t; +/* Macros for blk_qc_t */ #define BLK_QC_T_NONE -1U #define BLK_QC_T_SHIFT 16 #define BLK_QC_T_INTERNAL (1U << 31) diff --git a/include/linux/fs.h b/include/linux/fs.h index fd47deea7c17..04b687150736 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -330,7 +330,7 @@ struct kiocb { u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ union { - unsigned int ki_cookie; /* for ->iopoll */ + blk_qc_t ki_cookie; /* for ->iopoll */ struct wait_page_queue *ki_waitq; /* for async buffered IO */ }; diff --git a/include/linux/types.h b/include/linux/types.h index a147977602b5..da5ca7e1bea9 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -125,6 +125,9 @@ typedef s64 int64_t; typedef u64 sector_t; typedef u64 blkcnt_t; +/* cookie used for IO polling */ +typedef unsigned int blk_qc_t; + /* * The type of an index into the pagecache. */ -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Jeffle Xu <jefflexu@linux.alibaba.com> To: snitzer@redhat.com Cc: linux-block@vger.kernel.org, joseph.qi@linux.alibaba.com, dm-devel@redhat.com, io-uring@vger.kernel.org Subject: [dm-devel] [PATCH v2 1/6] block: move definition of blk_qc_t to types.h Date: Mon, 25 Jan 2021 20:13:35 +0800 [thread overview] Message-ID: <20210125121340.70459-2-jefflexu@linux.alibaba.com> (raw) In-Reply-To: <20210125121340.70459-1-jefflexu@linux.alibaba.com> So that kiocb.ki_cookie can be defined as blk_qc_t, which will enforce the encapsulation. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Snitzer <snitzer@redhat.com> --- include/linux/blk_types.h | 2 +- include/linux/fs.h | 2 +- include/linux/types.h | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 866f74261b3b..2e05244fc16d 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -532,7 +532,7 @@ static inline int op_stat_group(unsigned int op) return op_is_write(op); } -typedef unsigned int blk_qc_t; +/* Macros for blk_qc_t */ #define BLK_QC_T_NONE -1U #define BLK_QC_T_SHIFT 16 #define BLK_QC_T_INTERNAL (1U << 31) diff --git a/include/linux/fs.h b/include/linux/fs.h index fd47deea7c17..04b687150736 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -330,7 +330,7 @@ struct kiocb { u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ union { - unsigned int ki_cookie; /* for ->iopoll */ + blk_qc_t ki_cookie; /* for ->iopoll */ struct wait_page_queue *ki_waitq; /* for async buffered IO */ }; diff --git a/include/linux/types.h b/include/linux/types.h index a147977602b5..da5ca7e1bea9 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -125,6 +125,9 @@ typedef s64 int64_t; typedef u64 sector_t; typedef u64 blkcnt_t; +/* cookie used for IO polling */ +typedef unsigned int blk_qc_t; + /* * The type of an index into the pagecache. */ -- 2.27.0 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-01-26 5:32 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-25 12:13 [PATCH v2 0/6] dm: support IO polling for bio-based dm device Jeffle Xu 2021-01-25 12:13 ` [dm-devel] " Jeffle Xu 2021-01-25 12:13 ` Jeffle Xu [this message] 2021-01-25 12:13 ` [dm-devel] [PATCH v2 1/6] block: move definition of blk_qc_t to types.h Jeffle Xu 2021-01-25 12:13 ` [PATCH v2 2/6] block: add queue_to_disk() to get gendisk from request_queue Jeffle Xu 2021-01-25 12:13 ` [dm-devel] " Jeffle Xu 2021-01-27 17:20 ` Mike Snitzer 2021-01-27 17:20 ` [dm-devel] " Mike Snitzer 2021-01-25 12:13 ` [PATCH v2 3/6] block: add iopoll method to support bio-based IO polling Jeffle Xu 2021-01-25 12:13 ` [dm-devel] " Jeffle Xu 2021-01-27 17:14 ` Mike Snitzer 2021-01-27 17:14 ` [dm-devel] " Mike Snitzer 2021-01-28 8:40 ` Christoph Hellwig 2021-01-28 8:40 ` [dm-devel] " Christoph Hellwig 2021-01-28 11:52 ` JeffleXu 2021-01-28 11:52 ` [dm-devel] " JeffleXu 2021-01-28 14:36 ` Christoph Hellwig 2021-01-28 14:36 ` [dm-devel] " Christoph Hellwig 2021-01-25 12:13 ` [PATCH v2 4/6] dm: always return BLK_QC_T_NONE for bio-based device Jeffle Xu 2021-01-25 12:13 ` [dm-devel] " Jeffle Xu 2021-01-25 12:13 ` [PATCH v2 5/6] block: add QUEUE_FLAG_POLL_CAP flag Jeffle Xu 2021-01-25 12:13 ` [dm-devel] " Jeffle Xu 2021-01-27 17:13 ` Mike Snitzer 2021-01-27 17:13 ` [dm-devel] " Mike Snitzer 2021-01-28 2:07 ` JeffleXu 2021-01-28 2:07 ` [dm-devel] " JeffleXu 2021-01-25 12:13 ` [PATCH v2 6/6] dm: support IO polling for bio-based dm device Jeffle Xu 2021-01-25 12:13 ` [dm-devel] " Jeffle Xu 2021-01-29 7:37 ` JeffleXu 2021-01-29 7:37 ` [dm-devel] " JeffleXu 2021-01-27 17:19 ` [PATCH v2 0/6] " Mike Snitzer 2021-01-27 17:19 ` [dm-devel] " Mike Snitzer 2021-01-28 3:06 ` JeffleXu 2021-01-28 3:06 ` [dm-devel] " JeffleXu 2021-01-31 16:26 ` Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210125121340.70459-2-jefflexu@linux.alibaba.com \ --to=jefflexu@linux.alibaba.com \ --cc=dm-devel@redhat.com \ --cc=io-uring@vger.kernel.org \ --cc=joseph.qi@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.