All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagar Ghuge <sagar.ghuge@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/icl, tgl: whitelist COMMON_SLICE_CHICKEN3 register
Date: Thu,  4 Feb 2021 16:33:10 -0800	[thread overview]
Message-ID: <20210205003310.282664-1-sagar.ghuge@intel.com> (raw)

Adding this register to whitelist will allow UMD to toggle State Cache
Perf fix disable chicken bit.

   "If this bit is enabled, RCC uses BTP+BTI as address tag in its state
   cache instead of BTI only"

which will lead to dropping unnecessary render target flushes and stall
on scoreboard.

Bspec: 11333
Bspec: 45829

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 53f7838bd3c4..318302475c28 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1473,6 +1473,9 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
 		/* WaEnableStateCacheRedirectToCS:icl */
 		whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
 
+		/* WaAllowToDisableStateCachePerfFixFromUMD:icl */
+		whitelist_reg(w, GEN11_COMMON_SLICE_CHICKEN3);
+
 		/*
 		 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
 		 *
@@ -1533,6 +1536,9 @@ static void tgl_whitelist_build(struct intel_engine_cs *engine)
 		/* Wa_1808121037:tgl */
 		whitelist_reg(w, GEN7_COMMON_SLICE_CHICKEN1);
 
+		/* WaAllowToDisableStateCachePerfFixFromUMD:tgl */
+		whitelist_reg(w, GEN11_COMMON_SLICE_CHICKEN3);
+
 		/* Wa_1806527549:tgl */
 		whitelist_reg(w, HIZ_CHICKEN);
 		break;
-- 
2.29.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2021-02-05  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05  0:33 Sagar Ghuge [this message]
2021-02-05  3:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl, tgl: whitelist COMMON_SLICE_CHICKEN3 register Patchwork
2021-02-05 13:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-05 13:33 ` [Intel-gfx] [PATCH] " Chris Wilson
2021-02-05 18:48   ` Sagar Ghuge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205003310.282664-1-sagar.ghuge@intel.com \
    --to=sagar.ghuge@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.