All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Michal Hocko <mhocko@suse.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [bug report] scsi: sd_zbc: emulate ZONE_APPEND commands
Date: Wed, 17 Feb 2021 14:16:34 +0300	[thread overview]
Message-ID: <20210217111634.GL2222@kadam> (raw)
In-Reply-To: <SN4PR0401MB359823B2D42A6E31D5F6E5369B869@SN4PR0401MB3598.namprd04.prod.outlook.com>

On Wed, Feb 17, 2021 at 09:18:37AM +0000, Johannes Thumshirn wrote:
>  * @flags: gfp mask for the allocation - must be compatible (superset) with GFP_KERNEL.
> 
> So yeah, we should've read that before calling kvcalloc(..., GFP_NOIO).

This is a Smatch check now and checks are better than comments.  :)

regards,
dan carpenter

  reply	other threads:[~2021-02-17 11:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 19:39 [bug report] scsi: sd_zbc: emulate ZONE_APPEND commands Dan Carpenter
2021-02-16 23:33 ` Damien Le Moal
2021-02-17  6:42   ` Johannes Thumshirn
2021-02-17  8:00     ` Damien Le Moal
2021-02-17  8:03     ` Michal Hocko
2021-02-17  9:08       ` Johannes Thumshirn
2021-02-17  9:36         ` Michal Hocko
2021-02-17  9:41           ` Johannes Thumshirn
2021-02-17 10:05             ` Michal Hocko
2021-02-17  9:13       ` Damien Le Moal
2021-02-17  9:18         ` Johannes Thumshirn
2021-02-17 11:16           ` Dan Carpenter [this message]
2021-02-17 11:18             ` Johannes Thumshirn
2021-02-17  9:32         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217111634.GL2222@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.