From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [bug report] scsi: sd_zbc: emulate ZONE_APPEND commands
Date: Wed, 17 Feb 2021 06:42:37 +0000 [thread overview]
Message-ID: <SN4PR0401MB3598A07D142B475A90BDBDDA9B869@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: BL0PR04MB6514D3538AAAC001084C213AE7879@BL0PR04MB6514.namprd04.prod.outlook.com
On 17/02/2021 00:33, Damien Le Moal wrote:
> On 2021/02/17 4:42, Dan Carpenter wrote:
>> Hello Johannes Thumshirn,
>>
>> The patch 5795eb443060: "scsi: sd_zbc: emulate ZONE_APPEND commands"
>> from May 12, 2020, leads to the following static checker warning:
>>
>> drivers/scsi/sd_zbc.c:741 sd_zbc_revalidate_zones()
>> error: kvmalloc() only makes sense with GFP_KERNEL
>>
>> drivers/scsi/sd_zbc.c
>> 721 /*
>> 722 * There is nothing to do for regular disks, including host-aware disks
>> 723 * that have partitions.
>> 724 */
>> 725 if (!blk_queue_is_zoned(q))
>> 726 return 0;
>> 727
>> 728 /*
>> 729 * Make sure revalidate zones are serialized to ensure exclusive
>> 730 * updates of the scsi disk data.
>> 731 */
>> 732 mutex_lock(&sdkp->rev_mutex);
>> 733
>> 734 if (sdkp->zone_blocks == zone_blocks &&
>> 735 sdkp->nr_zones == nr_zones &&
>> 736 disk->queue->nr_zones == nr_zones)
>> 737 goto unlock;
>> 738
>> 739 sdkp->zone_blocks = zone_blocks;
>> 740 sdkp->nr_zones = nr_zones;
>> 741 sdkp->rev_wp_offset = kvcalloc(nr_zones, sizeof(u32), GFP_NOIO);
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> We're passing GFP_NOIO here so it just defaults to kcalloc() and will
>> not vmalloc() the memory.
>
> Indeed... And the allocation can get a little too big for kmalloc().
>
> Johannes, I think we need to move that allocation before the rev_mutex locking,
> using a local var for the allocated address, and then using GFP_KERNEL should be
> safe... But not entirely sure. Using kmalloc would be simpler but on large SMR
> drives, that allocation will soon need to be 400K or so (i.e. 100,000 zones or
> even more), too large for kmalloc to succeed reliably.
>
No I don't think so. A mutex isn't a spinlock so we can sleep on the allocation.
We can't use GFP_KERNEL as we're about to do I/O. blk_revalidate_disk_zones() called
a few line below also does the memalloc_noio_{save,restore}() dance.
Would a kmem_cache for these revalidations help us in any way?
next prev parent reply other threads:[~2021-02-17 6:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 19:39 [bug report] scsi: sd_zbc: emulate ZONE_APPEND commands Dan Carpenter
2021-02-16 23:33 ` Damien Le Moal
2021-02-17 6:42 ` Johannes Thumshirn [this message]
2021-02-17 8:00 ` Damien Le Moal
2021-02-17 8:03 ` Michal Hocko
2021-02-17 9:08 ` Johannes Thumshirn
2021-02-17 9:36 ` Michal Hocko
2021-02-17 9:41 ` Johannes Thumshirn
2021-02-17 10:05 ` Michal Hocko
2021-02-17 9:13 ` Damien Le Moal
2021-02-17 9:18 ` Johannes Thumshirn
2021-02-17 11:16 ` Dan Carpenter
2021-02-17 11:18 ` Johannes Thumshirn
2021-02-17 9:32 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB3598A07D142B475A90BDBDDA9B869@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.