All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Bulekov <alxndr@bu.edu>
To: jasowang@redhat.com
Cc: Alexander Bulekov <alxndr@bu.edu>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	ppandit@redhat.com
Subject: [PATCH] rtl8193: switch to use qemu_receive_packet() for loopback
Date: Fri, 26 Feb 2021 13:47:53 -0500	[thread overview]
Message-ID: <20210226184753.230037-1-alxndr@bu.edu> (raw)
In-Reply-To: <20210224055401.492407-1-jasowang@redhat.com>

This patch switches to use qemu_receive_packet() which can detect
reentrancy and return early.

Buglink: https://bugs.launchpad.net/qemu/+bug/1910826
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---

Although it's not a nc->info->receive() call, maybe this can also go in
this series?

-Alex

 hw/net/rtl8139.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index 4675ac878e..90b4fc63ce 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -1795,7 +1795,7 @@ static void rtl8139_transfer_frame(RTL8139State *s, uint8_t *buf, int size,
         }
 
         DPRINTF("+++ transmit loopback mode\n");
-        rtl8139_do_receive(qemu_get_queue(s->nic), buf, size, do_interrupt);
+        qemu_receive_packet(qemu_get_queue(s->nic), buf, size);
 
         if (iov) {
             g_free(buf2);
-- 
2.28.0



  parent reply	other threads:[~2021-02-26 19:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  5:53 [PATCH 0/6] Detect reentrant RX casue by loopback Jason Wang
2021-02-24  5:53 ` [PATCH 1/6] net: introduce qemu_receive_packet() Jason Wang
2021-02-24 10:11   ` Philippe Mathieu-Daudé
2021-02-24 13:17     ` Jason Wang
2021-02-24 13:43       ` Philippe Mathieu-Daudé
2021-02-25 14:01         ` P J P
2021-02-25 16:28           ` Alexander Bulekov
2021-02-25 16:29             ` Alexander Bulekov
2021-02-26 18:14               ` [QEMU-SECURITY] " P J P
2021-02-26 18:53                 ` Alexander Bulekov
2021-02-25 14:31   ` Philippe Mathieu-Daudé
2021-02-24  5:53 ` [PATCH 2/6] e1000: switch to use qemu_receive_packet() for loopback Jason Wang
2021-02-25 14:34   ` Philippe Mathieu-Daudé
2021-02-24  5:53 ` [PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet Jason Wang
2021-02-24  6:13   ` Stefan Weil
2021-02-25 14:36     ` Philippe Mathieu-Daudé
2021-02-25 14:42       ` Stefan Weil
2021-02-26  7:04         ` Jason Wang
2021-02-24  5:53 ` [PATCH 4/6] msf2-mac: switch to use qemu_receive_packet() for loopback Jason Wang
2021-02-25 14:34   ` Philippe Mathieu-Daudé
2021-02-24  5:54 ` [PATCH 5/6] sungem: " Jason Wang
2021-02-25 14:35   ` Philippe Mathieu-Daudé
2021-02-24  5:54 ` [PATCH 6/6] tx_pkt: switch to use qemu_receive_packet_iov() " Jason Wang
2021-02-25 14:35   ` Philippe Mathieu-Daudé
2021-02-24  6:03 ` [PATCH 0/6] Detect reentrant RX casue by loopback no-reply
2021-02-26 18:47 ` Alexander Bulekov [this message]
2021-03-01  7:14   ` [PATCH] rtl8193: switch to use qemu_receive_packet() for loopback Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226184753.230037-1-alxndr@bu.edu \
    --to=alxndr@bu.edu \
    --cc=jasowang@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.