[PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning - Torin Cooper-Bennun

From: Torin Cooper-Bennun <torin@maxiluxsystems.com>
To: linux-can@vger.kernel.org
Cc: mkl@pengutronix.de,
	Torin Cooper-Bennun <torin@maxiluxsystems.com>,
	Mariusz Madej <mariusz.madej@xtrack.com>
Subject: [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning
Date: Wed,  3 Mar 2021 10:31:52 +0000	[thread overview]
Message-ID: <20210303103151.3760532-1-torin@maxiluxsystems.com> (raw)

Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg,
with netdev output included.

Removing this warning also improves driver performance under heavy load,
where m_can_do_rx_poll may be called many times before this interrupt is
cleared, causing this message to be output many times (thanks Mariusz
Madej for this report).

Cc: Mariusz Madej <mariusz.madej@xtrack.com>
Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
---
 drivers/net/can/m_can/m_can.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 3752520a7d4b..d783c46cac16 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -501,9 +501,6 @@ static int m_can_do_rx_poll(struct net_device *dev, int quota)
 	}
 
 	while ((rxfs & RXFS_FFL_MASK) && (quota > 0)) {
-		if (rxfs & RXFS_RFL)
-			netdev_warn(dev, "Rx FIFO 0 Message Lost\n");
-
 		m_can_read_fifo(dev, rxfs);
 
 		quota--;
-- 
2.30.1

