From: Kishon Vijay Abraham I <kishon@ti.com> To: Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Swapnil Jakhade <sjakhade@cadence.com> Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>, Lokesh Vutla <lokeshvutla@ti.com> Subject: [PATCH v7 01/13] phy: cadence: Sierra: Fix PHY power_on sequence Date: Fri, 19 Mar 2021 18:11:16 +0530 [thread overview] Message-ID: <20210319124128.13308-2-kishon@ti.com> (raw) In-Reply-To: <20210319124128.13308-1-kishon@ti.com> Commit 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") de-asserts PHY_RESET even before the configurations are loaded in phy_init(). However PHY_RESET should be de-asserted only after all the configurations has been initialized, instead of de-asserting in probe. Fix it here. Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Cc: <stable@vger.kernel.org> # v5.4+ Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/phy/cadence/phy-cadence-sierra.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index 26a0badabe38..19f32ae877b9 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -319,6 +319,12 @@ static int cdns_sierra_phy_on(struct phy *gphy) u32 val; int ret; + ret = reset_control_deassert(sp->phy_rst); + if (ret) { + dev_err(dev, "Failed to take the PHY out of reset\n"); + return ret; + } + /* Take the PHY lane group out of reset */ ret = reset_control_deassert(ins->lnk_rst); if (ret) { @@ -616,7 +622,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) pm_runtime_enable(dev); phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); - reset_control_deassert(sp->phy_rst); return PTR_ERR_OR_ZERO(phy_provider); put_child: -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com> To: Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, Swapnil Jakhade <sjakhade@cadence.com> Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-phy@lists.infradead.org>, Lokesh Vutla <lokeshvutla@ti.com> Subject: [PATCH v7 01/13] phy: cadence: Sierra: Fix PHY power_on sequence Date: Fri, 19 Mar 2021 18:11:16 +0530 [thread overview] Message-ID: <20210319124128.13308-2-kishon@ti.com> (raw) In-Reply-To: <20210319124128.13308-1-kishon@ti.com> Commit 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") de-asserts PHY_RESET even before the configurations are loaded in phy_init(). However PHY_RESET should be de-asserted only after all the configurations has been initialized, instead of de-asserting in probe. Fix it here. Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Cc: <stable@vger.kernel.org> # v5.4+ Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/phy/cadence/phy-cadence-sierra.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index 26a0badabe38..19f32ae877b9 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -319,6 +319,12 @@ static int cdns_sierra_phy_on(struct phy *gphy) u32 val; int ret; + ret = reset_control_deassert(sp->phy_rst); + if (ret) { + dev_err(dev, "Failed to take the PHY out of reset\n"); + return ret; + } + /* Take the PHY lane group out of reset */ ret = reset_control_deassert(ins->lnk_rst); if (ret) { @@ -616,7 +622,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) pm_runtime_enable(dev); phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); - reset_control_deassert(sp->phy_rst); return PTR_ERR_OR_ZERO(phy_provider); put_child: -- 2.17.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-03-19 12:44 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 12:41 [PATCH v7 00/13] PHY: Add support in Sierra to use external clock Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I [this message] 2021-03-19 12:41 ` [PATCH v7 01/13] phy: cadence: Sierra: Fix PHY power_on sequence Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before of_platform_device_create() Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 03/13] phy: cadence: Sierra: Create PHY only for "phy" or "link" sub-nodes Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 04/13] phy: ti: j721e-wiz: Get PHY properties only for "phy" or "link" subnode Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 05/13] phy: cadence: Sierra: Move all clk_get_*() to a separate function Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 06/13] phy: cadence: Sierra: Move all reset_control_get*() " Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 07/13] phy: cadence: Sierra: Explicitly request exclusive reset control Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 08/13] phy: cadence-torrent: Use a common header file for Cadence SERDES Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-23 22:31 ` Rob Herring 2021-03-23 22:31 ` Rob Herring 2021-03-19 12:41 ` [PATCH v7 09/13] phy: cadence: Sierra: Add array of input clocks in "struct cdns_sierra_phy" Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 10/13] phy: cadence: Sierra: Add missing clk_disable_unprepare() in .remove callback Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 11/13] dt-bindings: phy: phy-cadence-sierra: Add binding to model Sierra as clock provider Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 12/13] phy: cadence: Sierra: Model PLL_CMNLC and PLL_CMNLC1 as clocks (mux clocks) Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-19 12:41 ` [PATCH v7 13/13] phy: cadence: Sierra: Enable pll_cmnlc and pll_cmnlc1 clocks Kishon Vijay Abraham I 2021-03-19 12:41 ` Kishon Vijay Abraham I 2021-03-31 11:14 ` [PATCH v7 00/13] PHY: Add support in Sierra to use external clock Vinod Koul 2021-03-31 11:14 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210319124128.13308-2-kishon@ti.com \ --to=kishon@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=lokeshvutla@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=sjakhade@cadence.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.