From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Jeffle Xu <jefflexu@linux.alibaba.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, Ming Lei <ming.lei@redhat.com> Subject: [PATCH V3 08/13] block: prepare for supporting bio_list via other link Date: Wed, 24 Mar 2021 20:19:22 +0800 [thread overview] Message-ID: <20210324121927.362525-9-ming.lei@redhat.com> (raw) In-Reply-To: <20210324121927.362525-1-ming.lei@redhat.com> So far bio list helpers always use .bi_next to traverse the list, we will support to link bios by other bio field. Prepare for such support by adding a macro so that users can define another helpers for linking bios by other bio field. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- include/linux/bio.h | 132 +++++++++++++++++++++++--------------------- 1 file changed, 68 insertions(+), 64 deletions(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index d0246c92a6e8..619edd26a6c0 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -608,75 +608,11 @@ static inline unsigned bio_list_size(const struct bio_list *bl) return sz; } -static inline void bio_list_add(struct bio_list *bl, struct bio *bio) -{ - bio->bi_next = NULL; - - if (bl->tail) - bl->tail->bi_next = bio; - else - bl->head = bio; - - bl->tail = bio; -} - -static inline void bio_list_add_head(struct bio_list *bl, struct bio *bio) -{ - bio->bi_next = bl->head; - - bl->head = bio; - - if (!bl->tail) - bl->tail = bio; -} - -static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2) -{ - if (!bl2->head) - return; - - if (bl->tail) - bl->tail->bi_next = bl2->head; - else - bl->head = bl2->head; - - bl->tail = bl2->tail; -} - -static inline void bio_list_merge_head(struct bio_list *bl, - struct bio_list *bl2) -{ - if (!bl2->head) - return; - - if (bl->head) - bl2->tail->bi_next = bl->head; - else - bl->tail = bl2->tail; - - bl->head = bl2->head; -} - static inline struct bio *bio_list_peek(struct bio_list *bl) { return bl->head; } -static inline struct bio *bio_list_pop(struct bio_list *bl) -{ - struct bio *bio = bl->head; - - if (bio) { - bl->head = bl->head->bi_next; - if (!bl->head) - bl->tail = NULL; - - bio->bi_next = NULL; - } - - return bio; -} - static inline struct bio *bio_list_get(struct bio_list *bl) { struct bio *bio = bl->head; @@ -686,6 +622,74 @@ static inline struct bio *bio_list_get(struct bio_list *bl) return bio; } +#define BIO_LIST_HELPERS(_pre, link) \ + \ +static inline void _pre##_add(struct bio_list *bl, struct bio *bio) \ +{ \ + bio->bi_##link = NULL; \ + \ + if (bl->tail) \ + bl->tail->bi_##link = bio; \ + else \ + bl->head = bio; \ + \ + bl->tail = bio; \ +} \ + \ +static inline void _pre##_add_head(struct bio_list *bl, struct bio *bio) \ +{ \ + bio->bi_##link = bl->head; \ + \ + bl->head = bio; \ + \ + if (!bl->tail) \ + bl->tail = bio; \ +} \ + \ +static inline void _pre##_merge(struct bio_list *bl, struct bio_list *bl2) \ +{ \ + if (!bl2->head) \ + return; \ + \ + if (bl->tail) \ + bl->tail->bi_##link = bl2->head; \ + else \ + bl->head = bl2->head; \ + \ + bl->tail = bl2->tail; \ +} \ + \ +static inline void _pre##_merge_head(struct bio_list *bl, \ + struct bio_list *bl2) \ +{ \ + if (!bl2->head) \ + return; \ + \ + if (bl->head) \ + bl2->tail->bi_##link = bl->head; \ + else \ + bl->tail = bl2->tail; \ + \ + bl->head = bl2->head; \ +} \ + \ +static inline struct bio *_pre##_pop(struct bio_list *bl) \ +{ \ + struct bio *bio = bl->head; \ + \ + if (bio) { \ + bl->head = bl->head->bi_##link; \ + if (!bl->head) \ + bl->tail = NULL; \ + \ + bio->bi_##link = NULL; \ + } \ + \ + return bio; \ +} \ + +BIO_LIST_HELPERS(bio_list, next); + /* * Increment chain count for the bio. Make sure the CHAIN flag update * is visible before the raised count. -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Jeffle Xu <jefflexu@linux.alibaba.com>, dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com> Subject: [dm-devel] [PATCH V3 08/13] block: prepare for supporting bio_list via other link Date: Wed, 24 Mar 2021 20:19:22 +0800 [thread overview] Message-ID: <20210324121927.362525-9-ming.lei@redhat.com> (raw) In-Reply-To: <20210324121927.362525-1-ming.lei@redhat.com> So far bio list helpers always use .bi_next to traverse the list, we will support to link bios by other bio field. Prepare for such support by adding a macro so that users can define another helpers for linking bios by other bio field. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- include/linux/bio.h | 132 +++++++++++++++++++++++--------------------- 1 file changed, 68 insertions(+), 64 deletions(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index d0246c92a6e8..619edd26a6c0 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -608,75 +608,11 @@ static inline unsigned bio_list_size(const struct bio_list *bl) return sz; } -static inline void bio_list_add(struct bio_list *bl, struct bio *bio) -{ - bio->bi_next = NULL; - - if (bl->tail) - bl->tail->bi_next = bio; - else - bl->head = bio; - - bl->tail = bio; -} - -static inline void bio_list_add_head(struct bio_list *bl, struct bio *bio) -{ - bio->bi_next = bl->head; - - bl->head = bio; - - if (!bl->tail) - bl->tail = bio; -} - -static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2) -{ - if (!bl2->head) - return; - - if (bl->tail) - bl->tail->bi_next = bl2->head; - else - bl->head = bl2->head; - - bl->tail = bl2->tail; -} - -static inline void bio_list_merge_head(struct bio_list *bl, - struct bio_list *bl2) -{ - if (!bl2->head) - return; - - if (bl->head) - bl2->tail->bi_next = bl->head; - else - bl->tail = bl2->tail; - - bl->head = bl2->head; -} - static inline struct bio *bio_list_peek(struct bio_list *bl) { return bl->head; } -static inline struct bio *bio_list_pop(struct bio_list *bl) -{ - struct bio *bio = bl->head; - - if (bio) { - bl->head = bl->head->bi_next; - if (!bl->head) - bl->tail = NULL; - - bio->bi_next = NULL; - } - - return bio; -} - static inline struct bio *bio_list_get(struct bio_list *bl) { struct bio *bio = bl->head; @@ -686,6 +622,74 @@ static inline struct bio *bio_list_get(struct bio_list *bl) return bio; } +#define BIO_LIST_HELPERS(_pre, link) \ + \ +static inline void _pre##_add(struct bio_list *bl, struct bio *bio) \ +{ \ + bio->bi_##link = NULL; \ + \ + if (bl->tail) \ + bl->tail->bi_##link = bio; \ + else \ + bl->head = bio; \ + \ + bl->tail = bio; \ +} \ + \ +static inline void _pre##_add_head(struct bio_list *bl, struct bio *bio) \ +{ \ + bio->bi_##link = bl->head; \ + \ + bl->head = bio; \ + \ + if (!bl->tail) \ + bl->tail = bio; \ +} \ + \ +static inline void _pre##_merge(struct bio_list *bl, struct bio_list *bl2) \ +{ \ + if (!bl2->head) \ + return; \ + \ + if (bl->tail) \ + bl->tail->bi_##link = bl2->head; \ + else \ + bl->head = bl2->head; \ + \ + bl->tail = bl2->tail; \ +} \ + \ +static inline void _pre##_merge_head(struct bio_list *bl, \ + struct bio_list *bl2) \ +{ \ + if (!bl2->head) \ + return; \ + \ + if (bl->head) \ + bl2->tail->bi_##link = bl->head; \ + else \ + bl->tail = bl2->tail; \ + \ + bl->head = bl2->head; \ +} \ + \ +static inline struct bio *_pre##_pop(struct bio_list *bl) \ +{ \ + struct bio *bio = bl->head; \ + \ + if (bio) { \ + bl->head = bl->head->bi_##link; \ + if (!bl->head) \ + bl->tail = NULL; \ + \ + bio->bi_##link = NULL; \ + } \ + \ + return bio; \ +} \ + +BIO_LIST_HELPERS(bio_list, next); + /* * Increment chain count for the bio. Make sure the CHAIN flag update * is visible before the raised count. -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-24 12:22 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-24 12:19 [PATCH V3 00/13] block: support bio based io polling Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 01/13] block: add helper of blk_queue_poll Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:19 ` Hannes Reinecke 2021-03-24 13:19 ` [dm-devel] " Hannes Reinecke 2021-03-24 17:54 ` Christoph Hellwig 2021-03-24 17:54 ` [dm-devel] " Christoph Hellwig 2021-03-25 1:56 ` JeffleXu 2021-03-25 1:56 ` [dm-devel] " JeffleXu 2021-03-24 12:19 ` [PATCH V3 02/13] block: add one helper to free io_context Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:21 ` Hannes Reinecke 2021-03-24 13:21 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 03/13] block: add helper of blk_create_io_context Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:22 ` Hannes Reinecke 2021-03-24 13:22 ` [dm-devel] " Hannes Reinecke 2021-03-24 15:52 ` Keith Busch 2021-03-24 15:52 ` [dm-devel] " Keith Busch 2021-03-24 18:17 ` Christoph Hellwig 2021-03-24 18:17 ` [dm-devel] " Christoph Hellwig 2021-03-25 0:30 ` Ming Lei 2021-03-25 0:30 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 04/13] block: create io poll context for submission and poll task Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 13:26 ` Hannes Reinecke 2021-03-24 13:26 ` [dm-devel] " Hannes Reinecke 2021-03-25 2:34 ` JeffleXu 2021-03-25 2:34 ` [dm-devel] " JeffleXu 2021-03-25 2:51 ` Ming Lei 2021-03-25 2:51 ` [dm-devel] " Ming Lei 2021-03-25 3:01 ` JeffleXu 2021-03-25 3:01 ` [dm-devel] " JeffleXu 2021-03-24 12:19 ` [PATCH V3 05/13] block: add req flag of REQ_POLL_CTX Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 15:32 ` Hannes Reinecke 2021-03-24 15:32 ` [dm-devel] " Hannes Reinecke 2021-03-25 0:32 ` Ming Lei 2021-03-25 0:32 ` [dm-devel] " Ming Lei 2021-03-25 6:55 ` JeffleXu 2021-03-25 6:55 ` [dm-devel] " JeffleXu 2021-03-24 12:19 ` [PATCH V3 06/13] block: add new field into 'struct bvec_iter' Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 15:33 ` Hannes Reinecke 2021-03-24 15:33 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 07/13] block/mq: extract one helper function polling hw queue Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-25 6:50 ` Hannes Reinecke 2021-03-25 6:50 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` Ming Lei [this message] 2021-03-24 12:19 ` [dm-devel] [PATCH V3 08/13] block: prepare for supporting bio_list via other link Ming Lei 2021-03-26 15:02 ` Hannes Reinecke 2021-03-26 15:02 ` [dm-devel] " Hannes Reinecke 2021-03-24 12:19 ` [PATCH V3 09/13] block: use per-task poll context to implement bio based io polling Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-25 6:34 ` JeffleXu 2021-03-25 6:34 ` [dm-devel] " JeffleXu 2021-03-25 8:05 ` Ming Lei 2021-03-25 8:05 ` [dm-devel] " Ming Lei 2021-03-25 9:18 ` JeffleXu 2021-03-25 9:18 ` [dm-devel] " JeffleXu 2021-03-25 9:56 ` Ming Lei 2021-03-25 9:56 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 10/13] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 11/13] block: add queue_to_disk() to get gendisk from request_queue Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 12/13] block: add poll_capable method to support bio-based IO polling Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-24 12:19 ` [PATCH V3 13/13] dm: support IO polling for bio-based dm device Ming Lei 2021-03-24 12:19 ` [dm-devel] " Ming Lei 2021-03-25 18:45 ` Mike Snitzer 2021-03-25 18:45 ` [dm-devel] " Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210324121927.362525-9-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=jefflexu@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.