Re: [PATCH v2 15/16] mm: multigenerational lru: Kconfig

From: kernel test robot <lkp@intel.com>
To: Yu Zhao <yuzhao@google.com>, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org, Alex Shi <alexs@kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Benjamin Manes <ben.manes@gmail.com>,
	Dave Chinner <david@fromorbit.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Hillf Danton <hdanton@sina.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 15/16] mm: multigenerational lru: Kconfig
Date: Wed, 14 Apr 2021 12:54:59 +0800	[thread overview]
Message-ID: <202104141204.sv8KgTuJ-lkp@intel.com> (raw)
In-Reply-To: <20210413065633.2782273-16-yuzhao@google.com>

[-- Attachment #1: Type: text/plain, Size: 3013 bytes --]

Hi Yu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on cgroup/for-next tip/x86/mm fuse/for-next tip/perf/core tip/sched/core linus/master v5.12-rc7]
[cannot apply to hnaz-linux-mm/master next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yu-Zhao/Multigenerational-LRU-Framework/20210413-145844
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 99cb64de36d5c9397a664808b92943e35bdce25e
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f05f4c64bb8f0b8bcc40c9931f51bffdb6502cdd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yu-Zhao/Multigenerational-LRU-Framework/20210413-145844
        git checkout f05f4c64bb8f0b8bcc40c9931f51bffdb6502cdd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> mm/vmscan.c:4704:16: error: variably modified 'bitmap' at file scope
    4704 |  unsigned long bitmap[BITS_TO_LONGS(PTRS_PER_PMD)];
         |                ^~~~~~

vim +/bitmap +4704 mm/vmscan.c

46b27b9e9608eb Yu Zhao 2021-04-13  4691  
46b27b9e9608eb Yu Zhao 2021-04-13  4692  struct mm_walk_args {
46b27b9e9608eb Yu Zhao 2021-04-13  4693  	struct mem_cgroup *memcg;
46b27b9e9608eb Yu Zhao 2021-04-13  4694  	unsigned long max_seq;
46b27b9e9608eb Yu Zhao 2021-04-13  4695  	unsigned long next_addr;
46b27b9e9608eb Yu Zhao 2021-04-13  4696  	unsigned long start_pfn;
46b27b9e9608eb Yu Zhao 2021-04-13  4697  	unsigned long end_pfn;
46b27b9e9608eb Yu Zhao 2021-04-13  4698  	int node_id;
46b27b9e9608eb Yu Zhao 2021-04-13  4699  	int batch_size;
46b27b9e9608eb Yu Zhao 2021-04-13  4700  	int mm_stats[NR_MM_STATS];
46b27b9e9608eb Yu Zhao 2021-04-13  4701  	int nr_pages[MAX_NR_GENS][ANON_AND_FILE][MAX_NR_ZONES];
46b27b9e9608eb Yu Zhao 2021-04-13  4702  	bool should_walk[ANON_AND_FILE];
46b27b9e9608eb Yu Zhao 2021-04-13  4703  #if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_HAVE_ARCH_PARENT_PMD_YOUNG)
46b27b9e9608eb Yu Zhao 2021-04-13 @4704  	unsigned long bitmap[BITS_TO_LONGS(PTRS_PER_PMD)];
46b27b9e9608eb Yu Zhao 2021-04-13  4705  #endif
46b27b9e9608eb Yu Zhao 2021-04-13  4706  };
46b27b9e9608eb Yu Zhao 2021-04-13  4707  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72720 bytes --]