All of lore.kernel.org
 help / color / mirror / Atom feed
From: He Zhe <zhe.he@windriver.com>
To: oleg@redhat.com, catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, paul@paul-moore.com,
	eparis@redhat.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org, zhe.he@windriver.com
Subject: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat
Date: Fri, 16 Apr 2021 15:55:31 +0800	[thread overview]
Message-ID: <20210416075533.7720-1-zhe.he@windriver.com> (raw)

The general version of is_syscall_success does not handle 32-bit
compatible case, which would cause 32-bit negative return code to be
recoganized as a positive number later and seen as a "success".

Since is_compat_thread is defined in compat.h, implementing
is_syscall_success in ptrace.h would introduce build failure due to
recursive inclusion of some basic headers like mutex.h. We put the
implementation to ptrace.c

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 arch/arm64/include/asm/ptrace.h |  3 +++
 arch/arm64/kernel/ptrace.c      | 10 ++++++++++
 2 files changed, 13 insertions(+)

diff --git a/arch/arm64/include/asm/ptrace.h b/arch/arm64/include/asm/ptrace.h
index e58bca832dff..3c415e9e5d85 100644
--- a/arch/arm64/include/asm/ptrace.h
+++ b/arch/arm64/include/asm/ptrace.h
@@ -328,6 +328,9 @@ static inline void regs_set_return_value(struct pt_regs *regs, unsigned long rc)
 	regs->regs[0] = rc;
 }
 
+extern inline int is_syscall_success(struct pt_regs *regs);
+#define is_syscall_success(regs) is_syscall_success(regs)
+
 /**
  * regs_get_kernel_argument() - get Nth function argument in kernel
  * @regs:	pt_regs of that context
diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 170f42fd6101..3266201f8c60 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -1909,3 +1909,13 @@ int valid_user_regs(struct user_pt_regs *regs, struct task_struct *task)
 	else
 		return valid_native_regs(regs);
 }
+
+inline int is_syscall_success(struct pt_regs *regs)
+{
+	unsigned long val = regs->regs[0];
+
+	if (is_compat_thread(task_thread_info(current)))
+		val = sign_extend64(val, 31);
+
+	return !IS_ERR_VALUE(val);
+}
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: He Zhe <zhe.he@windriver.com>
To: oleg@redhat.com, catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, paul@paul-moore.com,
	eparis@redhat.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org, zhe.he@windriver.com
Subject: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat
Date: Fri, 16 Apr 2021 15:55:31 +0800	[thread overview]
Message-ID: <20210416075533.7720-1-zhe.he@windriver.com> (raw)

The general version of is_syscall_success does not handle 32-bit
compatible case, which would cause 32-bit negative return code to be
recoganized as a positive number later and seen as a "success".

Since is_compat_thread is defined in compat.h, implementing
is_syscall_success in ptrace.h would introduce build failure due to
recursive inclusion of some basic headers like mutex.h. We put the
implementation to ptrace.c

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 arch/arm64/include/asm/ptrace.h |  3 +++
 arch/arm64/kernel/ptrace.c      | 10 ++++++++++
 2 files changed, 13 insertions(+)

diff --git a/arch/arm64/include/asm/ptrace.h b/arch/arm64/include/asm/ptrace.h
index e58bca832dff..3c415e9e5d85 100644
--- a/arch/arm64/include/asm/ptrace.h
+++ b/arch/arm64/include/asm/ptrace.h
@@ -328,6 +328,9 @@ static inline void regs_set_return_value(struct pt_regs *regs, unsigned long rc)
 	regs->regs[0] = rc;
 }
 
+extern inline int is_syscall_success(struct pt_regs *regs);
+#define is_syscall_success(regs) is_syscall_success(regs)
+
 /**
  * regs_get_kernel_argument() - get Nth function argument in kernel
  * @regs:	pt_regs of that context
diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 170f42fd6101..3266201f8c60 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -1909,3 +1909,13 @@ int valid_user_regs(struct user_pt_regs *regs, struct task_struct *task)
 	else
 		return valid_native_regs(regs);
 }
+
+inline int is_syscall_success(struct pt_regs *regs)
+{
+	unsigned long val = regs->regs[0];
+
+	if (is_compat_thread(task_thread_info(current)))
+		val = sign_extend64(val, 31);
+
+	return !IS_ERR_VALUE(val);
+}
-- 
2.17.1

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


WARNING: multiple messages have this Message-ID (diff)
From: He Zhe <zhe.he@windriver.com>
To: oleg@redhat.com, catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, paul@paul-moore.com,
	eparis@redhat.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org, zhe.he@windriver.com
Subject: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat
Date: Fri, 16 Apr 2021 15:55:31 +0800	[thread overview]
Message-ID: <20210416075533.7720-1-zhe.he@windriver.com> (raw)

The general version of is_syscall_success does not handle 32-bit
compatible case, which would cause 32-bit negative return code to be
recoganized as a positive number later and seen as a "success".

Since is_compat_thread is defined in compat.h, implementing
is_syscall_success in ptrace.h would introduce build failure due to
recursive inclusion of some basic headers like mutex.h. We put the
implementation to ptrace.c

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 arch/arm64/include/asm/ptrace.h |  3 +++
 arch/arm64/kernel/ptrace.c      | 10 ++++++++++
 2 files changed, 13 insertions(+)

diff --git a/arch/arm64/include/asm/ptrace.h b/arch/arm64/include/asm/ptrace.h
index e58bca832dff..3c415e9e5d85 100644
--- a/arch/arm64/include/asm/ptrace.h
+++ b/arch/arm64/include/asm/ptrace.h
@@ -328,6 +328,9 @@ static inline void regs_set_return_value(struct pt_regs *regs, unsigned long rc)
 	regs->regs[0] = rc;
 }
 
+extern inline int is_syscall_success(struct pt_regs *regs);
+#define is_syscall_success(regs) is_syscall_success(regs)
+
 /**
  * regs_get_kernel_argument() - get Nth function argument in kernel
  * @regs:	pt_regs of that context
diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 170f42fd6101..3266201f8c60 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -1909,3 +1909,13 @@ int valid_user_regs(struct user_pt_regs *regs, struct task_struct *task)
 	else
 		return valid_native_regs(regs);
 }
+
+inline int is_syscall_success(struct pt_regs *regs)
+{
+	unsigned long val = regs->regs[0];
+
+	if (is_compat_thread(task_thread_info(current)))
+		val = sign_extend64(val, 31);
+
+	return !IS_ERR_VALUE(val);
+}
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-04-16  7:56 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  7:55 He Zhe [this message]
2021-04-16  7:55 ` [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat He Zhe
2021-04-16  7:55 ` He Zhe
2021-04-16  7:55 ` [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16  9:43   ` Oleg Nesterov
2021-04-16  9:43     ` Oleg Nesterov
2021-04-16  9:43     ` Oleg Nesterov
2021-04-20  8:38     ` He Zhe
2021-04-20  8:38       ` He Zhe
2021-04-20  8:38       ` He Zhe
2021-04-21 17:41   ` Mark Rutland
2021-04-21 17:41     ` Mark Rutland
2021-04-21 17:41     ` Mark Rutland
2021-04-22 16:55     ` Mark Rutland
2021-04-22 16:55       ` Mark Rutland
2021-04-22 16:55       ` Mark Rutland
2021-04-16  7:55 ` [PATCH 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16 12:33 ` [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat Catalin Marinas
2021-04-16 12:33   ` Catalin Marinas
2021-04-16 12:33   ` Catalin Marinas
2021-04-16 13:34   ` Mark Rutland
2021-04-16 13:34     ` Mark Rutland
2021-04-16 13:34     ` Mark Rutland
2021-04-17 13:19     ` David Laight
2021-04-17 13:19       ` David Laight
2021-04-17 13:19       ` David Laight
2021-04-19 12:19     ` Will Deacon
2021-04-19 12:19       ` Will Deacon
2021-04-19 12:19       ` Will Deacon
2021-04-20  8:54       ` He Zhe
2021-04-20  8:54         ` He Zhe
2021-04-20  8:54         ` He Zhe
2021-04-21 17:10       ` Mark Rutland
2021-04-21 17:10         ` Mark Rutland
2021-04-21 17:10         ` Mark Rutland
2021-04-22 16:07         ` Will Deacon
2021-04-22 16:07           ` Will Deacon
2021-04-22 16:07           ` Will Deacon
2021-04-22 16:42           ` Mark Rutland
2021-04-22 16:42             ` Mark Rutland
2021-04-22 16:42             ` Mark Rutland
2021-04-22 18:57             ` Dmitry V. Levin
2021-04-22 18:57               ` Dmitry V. Levin
2021-04-22 18:57               ` Dmitry V. Levin
2021-04-20  8:42   ` He Zhe
2021-04-20  8:42     ` He Zhe
2021-04-20  8:42     ` He Zhe
2021-04-21 17:17     ` Mark Rutland
2021-04-21 17:17       ` Mark Rutland
2021-04-21 17:17       ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210416075533.7720-1-zhe.he@windriver.com \
    --to=zhe.he@windriver.com \
    --cc=catalin.marinas@arm.com \
    --cc=eparis@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.