From: David Ward <david.ward@gatech.edu>
To: Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Shuming Fan <shumingf@realtek.com>,
alsa-devel@alsa-project.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mario Limonciello <mario_limonciello@dell.com>
Subject: [PATCH 1/5] ASoC: rt286: Fix upper byte in DMIC2 configuration
Date: Sun, 18 Apr 2021 09:46:54 -0400 [thread overview]
Message-ID: <20210418134658.4333-2-david.ward@gatech.edu> (raw)
In-Reply-To: <20210418134658.4333-1-david.ward@gatech.edu>
This HDA verb sets the upper byte of the Configuration Default register, so
only an 8-bit value should be used. For the rt298, the same fix was applied
in commit f8f2dc4a7127 ("ASoC: rt298: fix wrong setting of gpio2_en").
Signed-off-by: David Ward <david.ward@gatech.edu>
---
sound/soc/codecs/rt286.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 8abe232ca4a4..f9b29782b62a 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -1204,7 +1204,7 @@ static int rt286_i2c_probe(struct i2c_client *i2c,
mdelay(10);
if (!rt286->pdata.gpio2_en)
- regmap_write(rt286->regmap, RT286_SET_DMIC2_DEFAULT, 0x4000);
+ regmap_write(rt286->regmap, RT286_SET_DMIC2_DEFAULT, 0x40);
else
regmap_write(rt286->regmap, RT286_SET_DMIC2_DEFAULT, 0);
--
2.31.1
next prev parent reply other threads:[~2021-04-18 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 13:46 [PATCH 0/5] ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack David Ward
2021-04-18 13:46 ` David Ward [this message]
2021-04-18 13:46 ` [PATCH 2/5] ASoC: rt286: Configure combo jack for headphones David Ward
2021-04-18 13:46 ` [PATCH 3/5] ASoC: rt298: " David Ward
2021-04-18 13:46 ` [PATCH 4/5] ASoC: rt286: Make RT286_SET_GPIO_* readable and writable David Ward
2021-04-18 13:46 ` [PATCH 5/5] ASoC: rt286: Generalize support for ALC3263 codec David Ward
2021-04-19 14:54 ` [PATCH 0/5] ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack Pierre-Louis Bossart
2021-04-19 17:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418134658.4333-2-david.ward@gatech.edu \
--to=david.ward@gatech.edu \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mario_limonciello@dell.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shumingf@realtek.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.