[PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, Ikjoon Jang <ikjn@chromium.org>,
	Eddie Hung <eddie.hung@mediatek.com>,
	Sergei Shtylyov <sergei.shtylyov@gmail.com>
Subject: [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS
Date: Fri, 7 May 2021 10:11:27 +0800	[thread overview]
Message-ID: <20210507021127.54717-4-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20210507021127.54717-1-chunfeng.yun@mediatek.com>

Use first-fit instead of best-fit for LS/FS devices under TT,
we found that best-fit will consume more bandwidth for some
cases.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: no changes
---
 drivers/usb/host/xhci-mtk-sch.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c
index 9fb75085e40f..c07411d9b16f 100644
--- a/drivers/usb/host/xhci-mtk-sch.c
+++ b/drivers/usb/host/xhci-mtk-sch.c
@@ -634,6 +634,11 @@ static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw,
 			min_bw = worst_bw;
 			min_index = offset;
 		}
+
+		/* use first-fit for LS/FS */
+		if (sch_ep->sch_tt && min_index >= 0)
+			break;
+
 		if (min_bw == 0)
 			break;
 	}
-- 
2.18.0

WARNING: multiple messages have this Message-ID (diff)

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, "Ikjoon Jang" <ikjn@chromium.org>,
	Eddie Hung <eddie.hung@mediatek.com>,
	"Sergei Shtylyov" <sergei.shtylyov@gmail.com>
Subject: [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS
Date: Fri, 7 May 2021 10:11:27 +0800	[thread overview]
Message-ID: <20210507021127.54717-4-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20210507021127.54717-1-chunfeng.yun@mediatek.com>

Use first-fit instead of best-fit for LS/FS devices under TT,
we found that best-fit will consume more bandwidth for some
cases.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: no changes
---
 drivers/usb/host/xhci-mtk-sch.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c
index 9fb75085e40f..c07411d9b16f 100644
--- a/drivers/usb/host/xhci-mtk-sch.c
+++ b/drivers/usb/host/xhci-mtk-sch.c
@@ -634,6 +634,11 @@ static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw,
 			min_bw = worst_bw;
 			min_index = offset;
 		}
+
+		/* use first-fit for LS/FS */
+		if (sch_ep->sch_tt && min_index >= 0)
+			break;
+
 		if (min_bw == 0)
 			break;
 	}
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, "Ikjoon Jang" <ikjn@chromium.org>,
	Eddie Hung <eddie.hung@mediatek.com>,
	"Sergei Shtylyov" <sergei.shtylyov@gmail.com>
Subject: [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS
Date: Fri, 7 May 2021 10:11:27 +0800	[thread overview]
Message-ID: <20210507021127.54717-4-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20210507021127.54717-1-chunfeng.yun@mediatek.com>

Use first-fit instead of best-fit for LS/FS devices under TT,
we found that best-fit will consume more bandwidth for some
cases.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: no changes
---
 drivers/usb/host/xhci-mtk-sch.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c
index 9fb75085e40f..c07411d9b16f 100644
--- a/drivers/usb/host/xhci-mtk-sch.c
+++ b/drivers/usb/host/xhci-mtk-sch.c
@@ -634,6 +634,11 @@ static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw,
 			min_bw = worst_bw;
 			min_index = offset;
 		}
+
+		/* use first-fit for LS/FS */
+		if (sch_ep->sch_tt && min_index >= 0)
+			break;
+
 		if (min_bw == 0)
 			break;
 	}
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2021-05-07  2:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07  2:11 [PATCH v3 1/4] usb: xhci-mtk: use bitfield instead of bool Chunfeng Yun
2021-05-07  2:11 ` Chunfeng Yun
2021-05-07  2:11 ` Chunfeng Yun
2021-05-07  2:11 ` [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc Chunfeng Yun
2021-05-07  2:11   ` Chunfeng Yun
2021-05-07  2:11   ` Chunfeng Yun
2021-06-10  3:32   ` Ikjoon Jang
2021-06-10  3:32     ` Ikjoon Jang
2021-06-10  3:32     ` Ikjoon Jang
2021-05-07  2:11 ` [PATCH v3 3/4] usb: xhci-mtk: remove unnecessary assignments in periodic TT scheduler Chunfeng Yun
2021-05-07  2:11   ` Chunfeng Yun
2021-05-07  2:11   ` Chunfeng Yun
2021-05-07  2:11 ` Chunfeng Yun [this message]
2021-05-07  2:11   ` [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS Chunfeng Yun
2021-05-07  2:11   ` Chunfeng Yun
2021-06-10  3:40   ` Ikjoon Jang
2021-06-10  3:40     ` Ikjoon Jang
2021-06-10  3:40     ` Ikjoon Jang
2021-06-10  3:31 ` [PATCH v3 1/4] usb: xhci-mtk: use bitfield instead of bool Ikjoon Jang
2021-06-10  3:31   ` Ikjoon Jang
2021-06-10  3:31   ` Ikjoon Jang

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:9fb75085e40 dfblob:9fb75085e40 dfblob:9fb75085e40
dfblob:c07411d9b16 dfblob:c07411d9b16 dfblob:c07411d9b16
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210507021127.54717-4-chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=eddie.hung@mediatek.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ikjn@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=sergei.shtylyov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.