From: Jianqun Xu <jay.xu@rock-chips.com> To: heiko@sntech.de, linus.walleij@linaro.org, robh+dt@kernel.org Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com> Subject: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Mon, 10 May 2021 14:37:34 +0800 [thread overview] Message-ID: <20210510063734.506063-1-jay.xu@rock-chips.com> (raw) In-Reply-To: <20210510063602.505829-1-jay.xu@rock-chips.com> There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 048e7eecddba..c9c55614bbef 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jianqun Xu <jay.xu@rock-chips.com> To: heiko@sntech.de, linus.walleij@linaro.org, robh+dt@kernel.org Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com> Subject: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Mon, 10 May 2021 14:37:34 +0800 [thread overview] Message-ID: <20210510063734.506063-1-jay.xu@rock-chips.com> (raw) In-Reply-To: <20210510063602.505829-1-jay.xu@rock-chips.com> There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 048e7eecddba..c9c55614bbef 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-05-10 6:37 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 6:35 [PATCH v4 0/7] gpio-rockchip driver Jianqun Xu 2021-05-10 6:35 ` Jianqun Xu 2021-05-10 6:35 ` [PATCH 1/7] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file Jianqun Xu 2021-05-10 6:35 ` Jianqun Xu 2021-05-24 23:55 ` Linus Walleij 2021-05-24 23:55 ` Linus Walleij 2021-05-10 6:35 ` [PATCH 2/7] pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct Jianqun Xu 2021-05-10 6:35 ` Jianqun Xu 2021-05-10 6:35 ` [PATCH 3/7] gpio: separate gpio driver from pinctrl-rockchip driver Jianqun Xu 2021-05-10 6:35 ` Jianqun Xu 2021-05-25 0:06 ` Linus Walleij 2021-05-25 0:06 ` Linus Walleij 2021-05-10 6:35 ` [PATCH 4/7] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller Jianqun Xu 2021-05-10 6:35 ` Jianqun Xu 2021-05-19 23:23 ` Heiko Stübner 2021-05-19 23:23 ` Heiko Stübner 2021-05-10 6:37 ` [PATCH 5/7] gpio/rockchip: support next version " Jianqun Xu 2021-05-10 6:37 ` Jianqun Xu 2021-05-10 6:37 ` [PATCH 6/7] gpio/rockchip: always enable clock for " Jianqun Xu 2021-05-10 6:37 ` Jianqun Xu 2021-05-13 20:48 ` Heiko Stuebner 2021-05-13 20:48 ` Heiko Stuebner 2021-05-19 23:18 ` Linus Walleij 2021-05-19 23:18 ` Linus Walleij 2021-05-19 23:27 ` Heiko Stübner 2021-05-19 23:27 ` Heiko Stübner 2021-05-10 6:37 ` Jianqun Xu [this message] 2021-05-10 6:37 ` [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Jianqun Xu 2021-05-19 23:26 ` Heiko Stübner 2021-05-19 23:26 ` Heiko Stübner 2021-05-10 22:16 ` [PATCH v4 0/7] gpio-rockchip driver Ezequiel Garcia 2021-05-10 22:16 ` Ezequiel Garcia 2021-05-12 13:29 ` Bartosz Golaszewski 2021-05-12 13:29 ` Bartosz Golaszewski -- strict thread matches above, loose matches on Subject: below -- 2021-03-24 6:45 [PATCH RESEND " Jianqun Xu 2021-03-24 6:47 ` [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Jianqun Xu 2021-03-24 6:47 ` Jianqun Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210510063734.506063-1-jay.xu@rock-chips.com \ --to=jay.xu@rock-chips.com \ --cc=heiko@sntech.de \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.