From: trix@redhat.com To: hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tom Rix <trix@redhat.com> Subject: [PATCH 6/7] fpga: wrap the fpga_remove() op Date: Mon, 7 Jun 2021 10:24:01 -0700 [thread overview] Message-ID: <20210607172402.2938697-7-trix@redhat.com> (raw) In-Reply-To: <20210607172402.2938697-1-trix@redhat.com> From: Tom Rix <trix@redhat.com> The board is not required to provide a fpga_remove() op. Add a wrapper consistent with the other op wrappers. Move op check to wrapper. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/fpga/fpga-mgr.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d06752be9c6e..84808c7ca440 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -731,6 +731,12 @@ int fpga_mgr_register(struct fpga_manager *mgr) } EXPORT_SYMBOL_GPL(fpga_mgr_register); +static void fpga_mgr_fpga_remove(struct fpga_manager *mgr) +{ + if (mgr->mops && mgr->mops->fpga_remove) + mgr->mops->fpga_remove(mgr); +} + /** * fpga_mgr_unregister - unregister a FPGA manager * @mgr: fpga manager struct @@ -745,8 +751,7 @@ void fpga_mgr_unregister(struct fpga_manager *mgr) * If the low level driver provides a method for putting fpga into * a desired state upon unregister, do it. */ - if (mgr->mops->fpga_remove) - mgr->mops->fpga_remove(mgr); + fpga_mgr_fpga_remove(mgr); device_unregister(&mgr->dev); } -- 2.26.3
WARNING: multiple messages have this Message-ID (diff)
From: trix@redhat.com To: hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tom Rix <trix@redhat.com> Subject: [PATCH 6/7] fpga: wrap the fpga_remove() op Date: Mon, 7 Jun 2021 10:24:01 -0700 [thread overview] Message-ID: <20210607172402.2938697-7-trix@redhat.com> (raw) In-Reply-To: <20210607172402.2938697-1-trix@redhat.com> From: Tom Rix <trix@redhat.com> The board is not required to provide a fpga_remove() op. Add a wrapper consistent with the other op wrappers. Move op check to wrapper. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/fpga/fpga-mgr.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d06752be9c6e..84808c7ca440 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -731,6 +731,12 @@ int fpga_mgr_register(struct fpga_manager *mgr) } EXPORT_SYMBOL_GPL(fpga_mgr_register); +static void fpga_mgr_fpga_remove(struct fpga_manager *mgr) +{ + if (mgr->mops && mgr->mops->fpga_remove) + mgr->mops->fpga_remove(mgr); +} + /** * fpga_mgr_unregister - unregister a FPGA manager * @mgr: fpga manager struct @@ -745,8 +751,7 @@ void fpga_mgr_unregister(struct fpga_manager *mgr) * If the low level driver provides a method for putting fpga into * a desired state upon unregister, do it. */ - if (mgr->mops->fpga_remove) - mgr->mops->fpga_remove(mgr); + fpga_mgr_fpga_remove(mgr); device_unregister(&mgr->dev); } -- 2.26.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-07 17:24 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 17:23 [PATCH 0/7] fpga: wrappers for fpga_manager_ops trix 2021-06-07 17:23 ` trix 2021-06-07 17:23 ` [PATCH 1/7] fpga: wrap the write_init() op trix 2021-06-07 17:23 ` trix 2021-06-07 22:36 ` Moritz Fischer 2021-06-07 22:36 ` Moritz Fischer 2021-06-08 6:23 ` Martin Hundebøll 2021-06-08 6:23 ` Martin Hundebøll 2021-06-08 19:05 ` Tom Rix 2021-06-08 19:05 ` Tom Rix 2021-06-08 13:55 ` Tom Rix 2021-06-08 13:55 ` Tom Rix 2021-06-07 17:23 ` [PATCH 2/7] fpga: make write_complete() op optional trix 2021-06-07 17:23 ` trix 2021-06-07 17:23 ` [PATCH 3/7] fpga: wrap the write() op trix 2021-06-07 17:23 ` trix 2021-06-07 17:23 ` [PATCH 4/7] fpga: wrap the status() op trix 2021-06-07 17:23 ` trix 2021-06-07 17:24 ` [PATCH 5/7] fpga: wrap the state() op trix 2021-06-07 17:24 ` trix 2021-06-07 17:24 ` trix [this message] 2021-06-07 17:24 ` [PATCH 6/7] fpga: wrap the fpga_remove() op trix 2021-06-07 17:24 ` [PATCH 7/7] fpga: collect wrappers and change to inline trix 2021-06-07 17:24 ` trix 2021-06-07 21:59 ` [PATCH 0/7] fpga: wrappers for fpga_manager_ops Moritz Fischer 2021-06-07 21:59 ` Moritz Fischer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210607172402.2938697-7-trix@redhat.com \ --to=trix@redhat.com \ --cc=hao.wu@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mdf@kernel.org \ --cc=michal.simek@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.