All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Douglas Anderson <dianders@chromium.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 7/9] nvmem: qfprom: minor nit fixes
Date: Fri, 11 Jun 2021 09:33:46 +0100	[thread overview]
Message-ID: <20210611083348.20170-8-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20210611083348.20170-1-srinivas.kandagatla@linaro.org>

From: Rajendra Nayak <rnayak@codeaurora.org>

Fix a missed newline, change an 'if' to 'else if' and update
a comment which is stale after the merge of '5a1bea2a: nvmem:
qfprom: Add support for fuseblowing on sc7280'

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/nvmem/qfprom.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index d6d3f24685a8..1ba666bcb900 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -122,6 +122,7 @@ static const struct qfprom_soc_compatible_data sc7280_qfprom = {
 	.keepout = sc7280_qfprom_keepout,
 	.nkeepout = ARRAY_SIZE(sc7280_qfprom_keepout)
 };
+
 /**
  * qfprom_disable_fuse_blowing() - Undo enabling of fuse blowing.
  * @priv: Our driver data.
@@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
 	}
 
 	/*
-	 * Hardware requires 1.8V min for fuse blowing; this may be
+	 * Hardware requires a min voltage for fuse blowing; this may be
 	 * a rail shared do don't specify a max--regulator constraints
 	 * will handle.
 	 */
@@ -399,7 +400,7 @@ static int qfprom_probe(struct platform_device *pdev)
 
 		if (major_version == 7 && minor_version == 8)
 			priv->soc_data = &qfprom_7_8_data;
-		if (major_version == 7 && minor_version == 15)
+		else if (major_version == 7 && minor_version == 15)
 			priv->soc_data = &qfprom_7_15_data;
 
 		priv->vcc = devm_regulator_get(&pdev->dev, "vcc");
-- 
2.21.0


  parent reply	other threads:[~2021-06-11  8:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  8:33 [PATCH 0/9] nvmem: patches (set 1) for 5.14 Srinivas Kandagatla
2021-06-11  8:33 ` [PATCH 1/9] nvmem: sprd: Add missing MODULE_DEVICE_TABLE Srinivas Kandagatla
2021-06-11  8:55   ` Greg KH
2021-06-11  9:09     ` Srinivas Kandagatla
2021-06-11  8:33 ` [PATCH 2/9] nvmem: qcom-spmi-sdam: add " Srinivas Kandagatla
2021-06-11  8:55   ` Greg KH
2021-06-11  8:33 ` [PATCH 3/9] nvmem: sc27xx: Add " Srinivas Kandagatla
2021-06-11  8:55   ` Greg KH
2021-06-11  8:33 ` [PATCH 4/9] nvmem: sprd: Fix an error message Srinivas Kandagatla
2021-06-11  8:56   ` Greg KH
2021-06-11  9:05     ` Srinivas Kandagatla
2021-06-11  9:17       ` Greg KH
2021-06-11  9:45         ` Greg KH
2021-06-11  9:48           ` Greg KH
2021-06-11 10:17             ` Srinivas Kandagatla
2021-06-11 10:09           ` Srinivas Kandagatla
2021-06-11 10:10           ` Marion & Christophe JAILLET
2021-06-11 10:17             ` Greg KH
2021-06-11 10:20               ` Srinivas Kandagatla
2021-06-11  8:33 ` [PATCH 5/9] nvmem: core: add a missing of_node_put Srinivas Kandagatla
2021-06-11  8:57   ` Greg KH
2021-06-11  9:10     ` Srinivas Kandagatla
2021-06-11  8:33 ` [PATCH 6/9] nvmem: sunxi_sid: Set type to OTP Srinivas Kandagatla
2021-06-11  8:33 ` Srinivas Kandagatla [this message]
2021-06-11  8:33 ` [PATCH 8/9] nvmem: core: constify nvmem_cell_read_variable_common() return value Srinivas Kandagatla
2021-06-11  8:33 ` [PATCH 9/9] nvmem: qfprom: Improve the comment about regulator setting Srinivas Kandagatla
2021-06-11  8:58 ` [PATCH 0/9] nvmem: patches (set 1) for 5.14 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210611083348.20170-8-srinivas.kandagatla@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rnayak@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.