All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, idryomov@redhat.com, berrange@redhat.com,
	Peter Lieven <pl@kamp.de>,
	qemu-devel@nongnu.org, ct@flyingcircus.io, pbonzini@redhat.com,
	idryomov@gmail.com, mreitz@redhat.com, dillaman@redhat.com
Subject: [PATCH V4 3/6] block/rbd: update s->image_size in qemu_rbd_getlength
Date: Fri,  2 Jul 2021 11:09:32 +0200	[thread overview]
Message-ID: <20210702090935.15300-4-pl@kamp.de> (raw)
In-Reply-To: <20210702090935.15300-1-pl@kamp.de>

while at it just call rbd_get_size and avoid rbd_stat.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block/rbd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/rbd.c b/block/rbd.c
index b4caea4f1b..1f8dc84079 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -968,15 +968,14 @@ static int qemu_rbd_getinfo(BlockDriverState *bs, BlockDriverInfo *bdi)
 static int64_t qemu_rbd_getlength(BlockDriverState *bs)
 {
     BDRVRBDState *s = bs->opaque;
-    rbd_image_info_t info;
     int r;
 
-    r = rbd_stat(s->image, &info, sizeof(info));
+    r = rbd_get_size(s->image, &s->image_size);
     if (r < 0) {
         return r;
     }
 
-    return info.size;
+    return s->image_size;
 }
 
 static int coroutine_fn qemu_rbd_co_truncate(BlockDriverState *bs,
-- 
2.17.1




  parent reply	other threads:[~2021-07-02  9:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02  9:09 [PATCH V4 0/6] block/rbd: migrate to coroutines and add write zeroes support Peter Lieven
2021-07-02  9:09 ` [PATCH V4 1/6] block/rbd: bump librbd requirement to luminous release Peter Lieven
2021-07-02 10:43   ` Ilya Dryomov
2021-07-02  9:09 ` [PATCH V4 2/6] block/rbd: store object_size in BDRVRBDState Peter Lieven
2021-07-02  9:09 ` Peter Lieven [this message]
2021-07-02 10:45   ` [PATCH V4 3/6] block/rbd: update s->image_size in qemu_rbd_getlength Ilya Dryomov
2021-07-02  9:09 ` [PATCH V4 4/6] block/rbd: migrate from aio to coroutines Peter Lieven
2021-07-02 10:57   ` Ilya Dryomov
2021-07-02  9:09 ` [PATCH V4 5/6] block/rbd: add write zeroes support Peter Lieven
2021-07-02 12:24   ` Ilya Dryomov
2021-07-02  9:09 ` [PATCH V4 6/6] block/rbd: drop qemu_rbd_refresh_limits Peter Lieven
2021-07-02 12:46 ` [PATCH V4 0/6] block/rbd: migrate to coroutines and add write zeroes support Ilya Dryomov
2021-07-02 13:15   ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702090935.15300-4-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=berrange@redhat.com \
    --cc=ct@flyingcircus.io \
    --cc=dillaman@redhat.com \
    --cc=idryomov@gmail.com \
    --cc=idryomov@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.