[PATCH v9 09/17] virtio-vdpa: Handle the failure of vdpa_reset()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Xie Yongji <xieyongji@bytedance.com>
To: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
	sgarzare@redhat.com, parav@nvidia.com, hch@infradead.org,
	christian.brauner@canonical.com, rdunlap@infradead.org,
	willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk,
	bcrl@kvack.org, corbet@lwn.net, mika.penttila@nextfour.com,
	dan.carpenter@oracle.com, joro@8bytes.org,
	gregkh@linuxfoundation.org, zhe.he@windriver.com,
	xiaodong.liu@intel.com
Cc: songmuchun@bytedance.com,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, kvm@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v9 09/17] virtio-vdpa: Handle the failure of vdpa_reset()
Date: Tue, 13 Jul 2021 16:46:48 +0800	[thread overview]
Message-ID: <20210713084656.232-10-xieyongji@bytedance.com> (raw)
In-Reply-To: <20210713084656.232-1-xieyongji@bytedance.com>

The vpda_reset() may fail now. This adds check to its return
value and fail the virtio_vdpa_reset().

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
 drivers/virtio/virtio_vdpa.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
index 3e666f70e829..ebbd8471bbee 100644
--- a/drivers/virtio/virtio_vdpa.c
+++ b/drivers/virtio/virtio_vdpa.c
@@ -101,9 +101,7 @@ static int virtio_vdpa_reset(struct virtio_device *vdev)
 {
 	struct vdpa_device *vdpa = vd_get_vdpa(vdev);
 
-	vdpa_reset(vdpa);
-
-	return 0;
+	return vdpa_reset(vdpa);
 }
 
 static bool virtio_vdpa_notify(struct virtqueue *vq)
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)

From: Xie Yongji <xieyongji@bytedance.com>
To: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
	sgarzare@redhat.com, parav@nvidia.com, hch@infradead.org,
	christian.brauner@canonical.com, rdunlap@infradead.org,
	willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk,
	bcrl@kvack.org, corbet@lwn.net, mika.penttila@nextfour.com,
	dan.carpenter@oracle.com, joro@8bytes.org,
	gregkh@linuxfoundation.org, zhe.he@windriver.com,
	xiaodong.liu@intel.com
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org, songmuchun@bytedance.com,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH v9 09/17] virtio-vdpa: Handle the failure of vdpa_reset()
Date: Tue, 13 Jul 2021 16:46:48 +0800	[thread overview]
Message-ID: <20210713084656.232-10-xieyongji@bytedance.com> (raw)
In-Reply-To: <20210713084656.232-1-xieyongji@bytedance.com>

The vpda_reset() may fail now. This adds check to its return
value and fail the virtio_vdpa_reset().

Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
 drivers/virtio/virtio_vdpa.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
index 3e666f70e829..ebbd8471bbee 100644
--- a/drivers/virtio/virtio_vdpa.c
+++ b/drivers/virtio/virtio_vdpa.c
@@ -101,9 +101,7 @@ static int virtio_vdpa_reset(struct virtio_device *vdev)
 {
 	struct vdpa_device *vdpa = vd_get_vdpa(vdev);
 
-	vdpa_reset(vdpa);
-
-	return 0;
+	return vdpa_reset(vdpa);
 }
 
 static bool virtio_vdpa_notify(struct virtqueue *vq)
-- 
2.11.0

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

next prev parent reply	other threads:[~2021-07-13  8:48 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  8:46 [PATCH v9 00/17] Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-07-13  8:46 ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 01/17] iova: Export alloc_iova_fast() and free_iova_fast() Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 02/17] file: Export receive_fd() to modules Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 03/17] vdpa: Fix code indentation Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-14  4:20   ` Joe Perches
2021-07-14  4:20     ` Joe Perches
2021-07-14  4:20     ` Joe Perches
2021-07-14  5:48     ` Yongji Xie
2021-07-14  5:48       ` Yongji Xie
2021-07-13  8:46 ` [PATCH v9 04/17] vdpa: Fail the vdpa_reset() if fail to set device status to zero Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 05/17] vhost-vdpa: Fail the vhost_vdpa_set_status() on reset failure Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 06/17] vhost-vdpa: Handle the failure of vdpa_reset() Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 07/17] virtio: Don't set FAILED status bit on device index allocation failure Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13 11:02   ` Dan Carpenter
2021-07-13 11:02     ` Dan Carpenter
2021-07-13 11:02     ` Dan Carpenter
2021-07-13 11:25     ` Yongji Xie
2021-07-13 11:25       ` Yongji Xie
2021-07-13  8:46 ` [PATCH v9 08/17] virtio_config: Add a return value to reset function Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-14 10:21   ` kernel test robot
2021-07-15 20:37   ` kernel test robot
2021-07-13  8:46 ` Xie Yongji [this message]
2021-07-13  8:46   ` [PATCH v9 09/17] virtio-vdpa: Handle the failure of vdpa_reset() Xie Yongji
2021-07-13  8:46 ` [PATCH v9 10/17] virtio: Handle device reset failure in register_virtio_device() Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 11/17] vhost-iotlb: Add an opaque pointer for vhost IOTLB Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 12/17] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 13/17] vdpa: factor out vhost_vdpa_pa_map() and vhost_vdpa_pa_unmap() Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13 11:31   ` Dan Carpenter
2021-07-13 11:31     ` Dan Carpenter
2021-07-13 11:31     ` Dan Carpenter
2021-07-14  2:14     ` Jason Wang
2021-07-14  2:14       ` Jason Wang
2021-07-14  2:14       ` Jason Wang
2021-07-14  8:05       ` Dan Carpenter
2021-07-14  8:05         ` Dan Carpenter
2021-07-14  8:05         ` Dan Carpenter
2021-07-14  9:41         ` Jason Wang
2021-07-14  9:41           ` Jason Wang
2021-07-14  9:41           ` Jason Wang
2021-07-14  9:57           ` Dan Carpenter
2021-07-14  9:57             ` Dan Carpenter
2021-07-14  9:57             ` Dan Carpenter
2021-07-15  2:20             ` Jason Wang
2021-07-15  2:20               ` Jason Wang
2021-07-15  2:20               ` Jason Wang
2021-07-14  5:24     ` Yongji Xie
2021-07-14  5:24       ` Yongji Xie
2021-07-13  8:46 ` [PATCH v9 14/17] vdpa: Support transferring virtual addressing during DMA mapping Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 15/17] vduse: Implement an MMU-based IOMMU driver Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13  8:46 ` [PATCH v9 16/17] vduse: Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-13 13:27   ` Dan Carpenter
2021-07-13 13:27     ` Dan Carpenter
2021-07-13 13:27     ` Dan Carpenter
2021-07-14  2:54     ` Jason Wang
2021-07-14  2:54       ` Jason Wang
2021-07-14  2:54       ` Jason Wang
2021-07-14  5:45       ` Yongji Xie
2021-07-14  5:45         ` Yongji Xie
2021-07-14  5:45   ` Jason Wang
2021-07-14  5:45     ` Jason Wang
2021-07-14  5:45     ` Jason Wang
2021-07-14  5:54     ` Michael S. Tsirkin
2021-07-14  5:54       ` Michael S. Tsirkin
2021-07-14  5:54       ` Michael S. Tsirkin
2021-07-14  6:02       ` Jason Wang
2021-07-14  6:02         ` Jason Wang
2021-07-14  6:02         ` Jason Wang
2021-07-14  6:47         ` Greg KH
2021-07-14  6:47           ` Greg KH
2021-07-14  6:47           ` Greg KH
2021-07-14  8:56           ` Jason Wang
2021-07-14  8:56             ` Jason Wang
2021-07-14  8:56             ` Jason Wang
2021-07-14  6:49     ` Yongji Xie
2021-07-14  6:49       ` Yongji Xie
2021-07-14  9:12       ` Jason Wang
2021-07-14  9:12         ` Jason Wang
2021-07-14  9:12         ` Jason Wang
2021-07-15  4:03         ` Yongji Xie
2021-07-15  4:03           ` Yongji Xie
2021-07-15  5:00           ` Jason Wang
2021-07-15  5:00             ` Jason Wang
2021-07-15  5:00             ` Jason Wang
2021-07-13  8:46 ` [PATCH v9 17/17] Documentation: Add documentation for VDUSE Xie Yongji
2021-07-13  8:46   ` Xie Yongji
2021-07-15  5:18   ` Jason Wang
2021-07-15  5:18     ` Jason Wang
2021-07-15  5:18     ` Jason Wang
2021-07-15  7:27     ` Yongji Xie
2021-07-15  7:27       ` Yongji Xie
2021-12-15 10:10 ` [PATCH v9 00/17] Introduce VDUSE - vDPA Device in Userspace Liuxiangdong
2021-12-16  3:14   ` Yongji Xie

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:3e666f70e82 dfblob:3e666f70e82 dfblob:ebbd8471bbe
dfblob:ebbd8471bbe
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713084656.232-10-xieyongji@bytedance.com \
    --to=xieyongji@bytedance.com \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=christian.brauner@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.penttila@nextfour.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=rdunlap@infradead.org \
    --cc=sgarzare@redhat.com \
    --cc=songmuchun@bytedance.com \
    --cc=stefanha@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=xiaodong.liu@intel.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.