From: kernel test robot <lkp@intel.com>
To: Yu Zhao <yuzhao@google.com>, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Hugh Dickins <hughd@google.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>, Yang Shi <shy828301@gmail.com>,
Zi Yan <ziy@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp
Date: Sat, 31 Jul 2021 23:45:19 +0800 [thread overview]
Message-ID: <202107312353.0jHXbIPP-lkp@intel.com> (raw)
In-Reply-To: <20210731063938.1391602-4-yuzhao@google.com>
[-- Attachment #1: Type: text/plain, Size: 3045 bytes --]
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc3]
[cannot apply to hnaz-linux-mm/master linux/master next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yu-Zhao/mm-optimize-thp-for-reclaim-and-migration/20210731-144129
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c7d102232649226a69dddd58a4942cf13cff4f7c
config: i386-randconfig-a003-20210730 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e4e76c4915b364558aacae2cf320a43306a20fa1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yu-Zhao/mm-optimize-thp-for-reclaim-and-migration/20210731-144129
git checkout e4e76c4915b364558aacae2cf320a43306a20fa1
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/migrate.c: In function 'try_to_unmap_clean':
>> mm/migrate.c:199:17: error: 'THP_SPLIT_UNMAP' undeclared (first use in this function)
199 | count_vm_event(THP_SPLIT_UNMAP);
| ^~~~~~~~~~~~~~~
mm/migrate.c:199:17: note: each undeclared identifier is reported only once for each function it appears in
vim +/THP_SPLIT_UNMAP +199 mm/migrate.c
170
171 static bool try_to_unmap_clean(struct page_vma_mapped_walk *pvmw, struct page *page)
172 {
173 void *addr;
174 bool dirty;
175
176 VM_BUG_ON_PAGE(PageLRU(page), page);
177 VM_BUG_ON_PAGE(PageCompound(page), page);
178 VM_BUG_ON_PAGE(!PageAnon(page), page);
179 VM_BUG_ON_PAGE(!PageLocked(page), page);
180 VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page);
181
182 if (PageMlocked(page) || (pvmw->vma->vm_flags & VM_LOCKED))
183 return false;
184
185 /*
186 * The pmd entry mapping the old thp was flushed and the pte mapping
187 * this subpage has been non present. Therefore, this subpage is
188 * inaccessible. We don't need to remap it if it contains only zeros.
189 */
190 addr = kmap_atomic(page);
191 dirty = !!memchr_inv(addr, 0, PAGE_SIZE);
192 kunmap_atomic(addr);
193
194 if (dirty)
195 return false;
196
197 pte_clear_not_present_full(pvmw->vma->vm_mm, pvmw->address, pvmw->pte, false);
198 dec_mm_counter(pvmw->vma->vm_mm, mm_counter(page));
> 199 count_vm_event(THP_SPLIT_UNMAP);
200
201 return true;
202 }
203
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33350 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp
Date: Sat, 31 Jul 2021 23:45:19 +0800 [thread overview]
Message-ID: <202107312353.0jHXbIPP-lkp@intel.com> (raw)
In-Reply-To: <20210731063938.1391602-4-yuzhao@google.com>
[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc3]
[cannot apply to hnaz-linux-mm/master linux/master next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yu-Zhao/mm-optimize-thp-for-reclaim-and-migration/20210731-144129
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c7d102232649226a69dddd58a4942cf13cff4f7c
config: i386-randconfig-a003-20210730 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e4e76c4915b364558aacae2cf320a43306a20fa1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yu-Zhao/mm-optimize-thp-for-reclaim-and-migration/20210731-144129
git checkout e4e76c4915b364558aacae2cf320a43306a20fa1
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/migrate.c: In function 'try_to_unmap_clean':
>> mm/migrate.c:199:17: error: 'THP_SPLIT_UNMAP' undeclared (first use in this function)
199 | count_vm_event(THP_SPLIT_UNMAP);
| ^~~~~~~~~~~~~~~
mm/migrate.c:199:17: note: each undeclared identifier is reported only once for each function it appears in
vim +/THP_SPLIT_UNMAP +199 mm/migrate.c
170
171 static bool try_to_unmap_clean(struct page_vma_mapped_walk *pvmw, struct page *page)
172 {
173 void *addr;
174 bool dirty;
175
176 VM_BUG_ON_PAGE(PageLRU(page), page);
177 VM_BUG_ON_PAGE(PageCompound(page), page);
178 VM_BUG_ON_PAGE(!PageAnon(page), page);
179 VM_BUG_ON_PAGE(!PageLocked(page), page);
180 VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page);
181
182 if (PageMlocked(page) || (pvmw->vma->vm_flags & VM_LOCKED))
183 return false;
184
185 /*
186 * The pmd entry mapping the old thp was flushed and the pte mapping
187 * this subpage has been non present. Therefore, this subpage is
188 * inaccessible. We don't need to remap it if it contains only zeros.
189 */
190 addr = kmap_atomic(page);
191 dirty = !!memchr_inv(addr, 0, PAGE_SIZE);
192 kunmap_atomic(addr);
193
194 if (dirty)
195 return false;
196
197 pte_clear_not_present_full(pvmw->vma->vm_mm, pvmw->address, pvmw->pte, false);
198 dec_mm_counter(pvmw->vma->vm_mm, mm_counter(page));
> 199 count_vm_event(THP_SPLIT_UNMAP);
200
201 return true;
202 }
203
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33350 bytes --]
next prev parent reply other threads:[~2021-07-31 15:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 6:39 [PATCH 0/3] mm: optimize thp for reclaim and migration Yu Zhao
2021-07-31 6:39 ` Yu Zhao
2021-07-31 6:39 ` [PATCH 1/3] mm: don't take lru lock when splitting isolated thp Yu Zhao
2021-07-31 6:39 ` Yu Zhao
2021-07-31 6:39 ` [PATCH 2/3] mm: free zapped tail pages " Yu Zhao
2021-07-31 6:39 ` Yu Zhao
2021-08-04 14:22 ` Kirill A. Shutemov
2021-08-08 17:28 ` Yu Zhao
2021-08-08 17:28 ` Yu Zhao
2021-08-05 0:13 ` Yang Shi
2021-08-05 0:13 ` Yang Shi
2021-08-08 17:49 ` Yu Zhao
2021-08-08 17:49 ` Yu Zhao
2021-08-11 22:25 ` Yang Shi
2021-08-11 22:25 ` Yang Shi
2021-08-11 23:12 ` Yu Zhao
2021-08-11 23:12 ` Yu Zhao
2021-08-13 23:24 ` Yang Shi
2021-08-13 23:24 ` Yang Shi
2021-08-13 23:56 ` Yu Zhao
2021-08-13 23:56 ` Yu Zhao
2021-08-14 0:30 ` Yang Shi
2021-08-14 0:30 ` Yang Shi
2021-08-14 1:49 ` Yu Zhao
2021-08-14 1:49 ` Yu Zhao
2021-08-14 2:34 ` Yang Shi
2021-08-14 2:34 ` Yang Shi
2021-07-31 6:39 ` [PATCH 3/3] mm: don't remap clean subpages " Yu Zhao
2021-07-31 6:39 ` Yu Zhao
2021-07-31 9:53 ` kernel test robot
2021-07-31 9:53 ` kernel test robot
2021-07-31 15:45 ` kernel test robot [this message]
2021-07-31 15:45 ` kernel test robot
2021-08-03 11:25 ` Matthew Wilcox
2021-08-03 11:36 ` Matthew Wilcox
2021-08-08 17:21 ` Yu Zhao
2021-08-08 17:21 ` Yu Zhao
2021-08-04 14:27 ` Kirill A. Shutemov
2021-08-08 17:20 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107312353.0jHXbIPP-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.