From: Nathan Chancellor <nathan@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub
Date: Mon, 16 Aug 2021 16:42:47 -0700 [thread overview]
Message-ID: <20210816234247.139528-1-nathan@kernel.org> (raw)
Without this, there is a warning in nearly every fs/f2fs/ file when
F2FS_FS_COMPRESSION is not set:
In file included from fs/f2fs/super.c:31:
fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
^
1 warning generated.
Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 0c978f934dcc..fe1097e678da 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4248,7 +4248,7 @@ static inline void f2fs_put_page_dic(struct page *page)
WARN_ON_ONCE(1);
}
static inline unsigned int f2fs_cluster_blocks_are_contiguous(struct dnode_of_data *dn) { return 0; }
-static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
+static inline bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
static inline int f2fs_init_compress_inode(struct f2fs_sb_info *sbi) { return 0; }
static inline void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi) { }
static inline int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi) { return 0; }
base-commit: f4b05791dda93edb03ebb6b48f1be104b2e64274
--
2.33.0.rc2
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub
Date: Mon, 16 Aug 2021 16:42:47 -0700 [thread overview]
Message-ID: <20210816234247.139528-1-nathan@kernel.org> (raw)
Without this, there is a warning in nearly every fs/f2fs/ file when
F2FS_FS_COMPRESSION is not set:
In file included from fs/f2fs/super.c:31:
fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
^
1 warning generated.
Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 0c978f934dcc..fe1097e678da 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4248,7 +4248,7 @@ static inline void f2fs_put_page_dic(struct page *page)
WARN_ON_ONCE(1);
}
static inline unsigned int f2fs_cluster_blocks_are_contiguous(struct dnode_of_data *dn) { return 0; }
-static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
+static inline bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
static inline int f2fs_init_compress_inode(struct f2fs_sb_info *sbi) { return 0; }
static inline void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi) { }
static inline int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi) { return 0; }
base-commit: f4b05791dda93edb03ebb6b48f1be104b2e64274
--
2.33.0.rc2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2021-08-16 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 23:42 Nathan Chancellor [this message]
2021-08-16 23:42 ` [f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub Nathan Chancellor
2021-08-17 0:33 ` Jaegeuk Kim
2021-08-17 0:33 ` [f2fs-dev] " Jaegeuk Kim
2021-08-17 0:34 ` Nathan Chancellor
2021-08-17 0:34 ` [f2fs-dev] " Nathan Chancellor
2021-08-17 18:58 ` Jaegeuk Kim
2021-08-17 18:58 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816234247.139528-1-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.