All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org, eizan@chromium.org,
	kernel@collabora.com, drinkcat@chromium.org,
	jitao.shi@mediatek.com, chunkuang.hu@kernel.org,
	hsinyi@chromium.org, matthias.bgg@gmail.com,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware
Date: Thu, 30 Sep 2021 10:31:50 +0200	[thread overview]
Message-ID: <20210930103105.v4.7.Idbb4727ddf00ba2fe796b630906baff10d994d89@changeid> (raw)
In-Reply-To: <20210930083150.3317003-1-enric.balletbo@collabora.com>

Reset dsi0 HW to default when power on. This prevents to have different
settingis between the bootloader and the kernel.

As not all Mediatek boards have the reset consumer configured in their
board description, also is not needed on all of them, the reset is optional,
so the change is compatible with all boards.

Cc: Jitao Shi <jitao.shi@mediatek.com>
Suggested-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---

(no changes since v3)

Changes in v3:
- Fix typo in the commit description

 drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 93b40c245f00..5d90d2eb0019 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -11,6 +11,7 @@
 #include <linux/of_platform.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 
 #include <video/mipi_display.h>
 #include <video/videomode.h>
@@ -980,8 +981,10 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data)
 	struct mtk_dsi *dsi = dev_get_drvdata(dev);
 
 	ret = mtk_dsi_encoder_init(drm, dsi);
+	if (ret)
+		return ret;
 
-	return ret;
+	return device_reset_optional(dev);
 }
 
 static void mtk_dsi_unbind(struct device *dev, struct device *master,
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org, eizan@chromium.org,
	kernel@collabora.com, drinkcat@chromium.org,
	jitao.shi@mediatek.com, chunkuang.hu@kernel.org,
	hsinyi@chromium.org, matthias.bgg@gmail.com,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware
Date: Thu, 30 Sep 2021 10:31:50 +0200	[thread overview]
Message-ID: <20210930103105.v4.7.Idbb4727ddf00ba2fe796b630906baff10d994d89@changeid> (raw)
In-Reply-To: <20210930083150.3317003-1-enric.balletbo@collabora.com>

Reset dsi0 HW to default when power on. This prevents to have different
settingis between the bootloader and the kernel.

As not all Mediatek boards have the reset consumer configured in their
board description, also is not needed on all of them, the reset is optional,
so the change is compatible with all boards.

Cc: Jitao Shi <jitao.shi@mediatek.com>
Suggested-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---

(no changes since v3)

Changes in v3:
- Fix typo in the commit description

 drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 93b40c245f00..5d90d2eb0019 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -11,6 +11,7 @@
 #include <linux/of_platform.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 
 #include <video/mipi_display.h>
 #include <video/videomode.h>
@@ -980,8 +981,10 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data)
 	struct mtk_dsi *dsi = dev_get_drvdata(dev);
 
 	ret = mtk_dsi_encoder_init(drm, dsi);
+	if (ret)
+		return ret;
 
-	return ret;
+	return device_reset_optional(dev);
 }
 
 static void mtk_dsi_unbind(struct device *dev, struct device *master,
-- 
2.30.2


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org, eizan@chromium.org,
	kernel@collabora.com, drinkcat@chromium.org,
	jitao.shi@mediatek.com, chunkuang.hu@kernel.org,
	hsinyi@chromium.org, matthias.bgg@gmail.com,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware
Date: Thu, 30 Sep 2021 10:31:50 +0200	[thread overview]
Message-ID: <20210930103105.v4.7.Idbb4727ddf00ba2fe796b630906baff10d994d89@changeid> (raw)
In-Reply-To: <20210930083150.3317003-1-enric.balletbo@collabora.com>

Reset dsi0 HW to default when power on. This prevents to have different
settingis between the bootloader and the kernel.

As not all Mediatek boards have the reset consumer configured in their
board description, also is not needed on all of them, the reset is optional,
so the change is compatible with all boards.

Cc: Jitao Shi <jitao.shi@mediatek.com>
Suggested-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---

(no changes since v3)

Changes in v3:
- Fix typo in the commit description

 drivers/gpu/drm/mediatek/mtk_dsi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 93b40c245f00..5d90d2eb0019 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -11,6 +11,7 @@
 #include <linux/of_platform.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 
 #include <video/mipi_display.h>
 #include <video/videomode.h>
@@ -980,8 +981,10 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data)
 	struct mtk_dsi *dsi = dev_get_drvdata(dev);
 
 	ret = mtk_dsi_encoder_init(drm, dsi);
+	if (ret)
+		return ret;
 
-	return ret;
+	return device_reset_optional(dev);
 }
 
 static void mtk_dsi_unbind(struct device *dev, struct device *master,
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-09-30  8:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30  8:31 [PATCH v4 0/7] Add support to the mmsys driver to be a reset controller Enric Balletbo i Serra
2021-09-30  8:31 ` Enric Balletbo i Serra
2021-09-30  8:31 ` Enric Balletbo i Serra
2021-09-30  8:31 ` [PATCH v4 1/7] arm64: dts: mediatek: Move reset controller constants into common location Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31 ` [PATCH v4 2/7] dt-bindings: mediatek: Add #reset-cells to mmsys system controller Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30 19:40   ` Rob Herring
2021-09-30 19:40     ` Rob Herring
2021-10-04 16:47   ` Rob Herring
2021-10-04 16:47     ` Rob Herring
2021-10-04 16:47     ` Rob Herring
2021-09-30  8:31 ` [PATCH v4 3/7] dt-bindings: display: mediatek: add dsi reset optional property Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31 ` [PATCH v4 4/7] arm64: dts: mt8173: Add the mmsys reset bit to reset the dsi0 Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31 ` [PATCH v4 5/7] arm64: dts: mt8183: " Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31 ` [PATCH v4 6/7] soc: mediatek: mmsys: Add reset controller support Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-09-30  8:31 ` Enric Balletbo i Serra [this message]
2021-09-30  8:31   ` [PATCH v4 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware Enric Balletbo i Serra
2021-09-30  8:31   ` Enric Balletbo i Serra
2021-10-08 13:16 ` [PATCH v4 0/7] Add support to the mmsys driver to be a reset controller Matthias Brugger
2021-10-08 13:16   ` Matthias Brugger
2021-10-08 13:16   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210930103105.v4.7.Idbb4727ddf00ba2fe796b630906baff10d994d89@changeid \
    --to=enric.balletbo@collabora.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drinkcat@chromium.org \
    --cc=eizan@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=jitao.shi@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.